Received-SPF: pass (google.com: domain of linux-kernel+bounces-61089-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <359993c5-3387-443c-8cef-30ee7ad1f521@ti.com>
Date: Mon, 12 Feb 2024 09:40:17 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 0/5] arm64: dts: add description for solidrun am642 som
 and hummingboard evb
Content-Language: en-US
To: Josua Mayer <josua@solid-run.com>, Nishanth Menon <nm@ti.com>,
        Tero Kristo
	<kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni
	<alexandre.belloni@bootlin.com>
CC: Yazan Shhady <yazan.shhady@solid-run.com>,
        <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-rtc@vger.kernel.org>,
        "Krzysztof
 Kozlowski" <krzysztof.kozlowski@linaro.org>,
        Suman Anna <s-anna@ti.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        MD Danish Anwar
	<danishanwar@ti.com>, Andrew Davis <afd@ti.com>
References: <20240211-add-am64-som-v5-0-790ed7121249@solid-run.com>
From: Vignesh Raghavendra <vigneshr@ti.com>
In-Reply-To: <20240211-add-am64-som-v5-0-790ed7121249@solid-run.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Hi Josua,

On 11/02/24 20:37, Josua Mayer wrote:
> This series adds DT bindings and dts descriptions for SolidRun AM642
> based SoM and Hummingboard EVB.
> 
> Additionally a commit from downstream vendor kernel are included,
> enhancing support for pru based ethernet.
> I wasn't sure how to properly annotate it in commit description /
> signed-off area ...:
> 
> 1. add description for "Industrial Ethernet Peripherals" (IEP) to am64
>    https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/arch/arm64/boot/dts/ti/k3-am64-main.dtsi?h=ti-linux-6.1.y-cicd&id=5afb73d82a014b59462162d960b350b8c58e5ae6
>    IEP is already supported in-tree by a driver, and used in
>    k3-am65-main.dtsi.
> 
> Unfortunately dtbs_check reported many problems, I put some remarks:
> 
> - 'mux-controller' does not match any of the regexes
>   The expectation seems to be that a mux-controller at minimum has an
>   address, something to put behind an @. However this is a gpio mux, not
>   sure how to name it better.
> 

I don't see this warning locally. Are you using updated dt-schema? reg
is not necessary gpio-mux as per gpio-mux.yaml

> - unevaluated properties: interrupts, interrupt-parent
>   sensors and flash yaml are missing interrupt descriptions, but these
>   parts definitely have an interrupt signal in this solidrun board.
> 

Please add them to appropriate schema as necessary

> - wrong names for pinctrl nodes
>   Other TI DTSs consistently end with *-pins-default. Should a different
>   naming convention be used?
> 

No, pinctrl nodes need to end in -pins. All TI boards have been updated
to new schema [0] and sysconfig tool on dev.ti.com/sysconfig generates
appropriately. Please fix


> - cdns,phy-type required property
>   inherited from k3-am64-main.dtsi
>   there is a PHY_NONE value in dt-bindings/phy/phy.h,
>   but not allowed in phy-cadence-torrent.yaml
>

Sorry, I didnt get what's the issue wrt cdns,phy-type ?


Note, I really don't want to accept patches that add new dtbs_check
issues especially for nodes that already have YAML bindings. Please
update the .yaml files as necessary.

[0]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a49568115143435390f20965902809471b6f830c


-- 
Regards
Vignesh