Received-SPF: pass (google.com: domain of linux-kernel+bounces-61123-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 11 Feb 2024 23:07:40 -0800
From: Andi Kleen <ak@linux.intel.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: hapter@420blaze.it, mingo@redhat.com, tglx@linutronix.de, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: arch/x86/kernel/sys_x86_64.c: rationale for 0x40000000 for
 MAP_32BIT's start address?
Message-ID: <ZcnDvPxwd8ELjbtb@tassilo>
References: <a5c2f06ba401cdf13bc87749341b1605@420blaze.it>
 <ZcmF3SrTACMULEPb@archie.me>
 <dc60d456-3f02-4076-8adf-4688cfa03aeb@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dc60d456-3f02-4076-8adf-4688cfa03aeb@gmail.com>

> >> Unfortunately this does not supply a rationale for starting from 0x40000000,
> >> which seems very arbitrary, and the git commit has been there since the
> >> beginning of time (i.e. as far the the git history goes), so the git blame
> >> has not helped much to clarify it. I was also not able to find who "AK" was.
> > 
> > That was from commit 717db2f9f36805 ("[PATCH] x86-64 updates for 2.5.54")
> > in tglx/history.git repo [1], authored by Andi Kleen. Cc'ing him.
> > 
> 
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/arch/x86_64/kernel/sys_x86_64.c?id=717db2f9f36805d85c695771ea7d712812896aa7

I thought the comment was clear? The 1GB start is to avoid conflicts with the brk heap,
which grows up.

The flag is really obsolete, if you want limited relocations there are
better ways to do it that don't limit ASLR. 

It was originally because the custom module loader in X.org didn't support a PLT.


-Andi