Received-SPF: pass (google.com: domain of linux-kernel+bounces-61143-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 12 Feb 2024 08:15:58 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
CC: <shuah@kernel.org>, <fenghua.yu@intel.com>,
	<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v5 3/5] selftests/resctrl: Split
 validate_resctrl_feature_request()
Message-ID: <ikd2opu75n66j4a4rafz5garz2kuozssx4v73legg3prsh7m6n@v2frrzizkjgt>
References: <cover.1707487039.git.maciej.wieczor-retman@intel.com>
 <f914c55b9b9f635cff082b0b4a8b636598580821.1707487039.git.maciej.wieczor-retman@intel.com>
 <f65f7c8a-e2d8-444b-abbc-d28eba0f86f5@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f65f7c8a-e2d8-444b-abbc-d28eba0f86f5@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?h2L7k0mqnPy0V8gSs368U1dxwTTmY7UcYk+T7ijEnKnRCZtMUzpBDUquyp?=
 =?iso-8859-1?Q?8L43UnnYB6DjFaraZ+BmylaOrQEZFX3jDDLw16sQ6lKfOSIn0oFmjdXsZF?=
 =?iso-8859-1?Q?LorBKyBstcPC6nKnukbGGGV3vPC3QbowVarQjUlc2xsm88yvpq6ncA04kX?=
 =?iso-8859-1?Q?t7x0FlWdbDAjjiDXJHXo8/HLK9OsJM22RMz/0wCdRlO0D2elvxseYwxzpT?=
 =?iso-8859-1?Q?C1RuedYCBz7qxfCZHCx6nlck3mP8f51X/vsr4z/ywabRE+Y7L4dzJcNIiU?=
 =?iso-8859-1?Q?I2PsKC/5LVzW9d8Y7oesq2eKtkKCbtCpaCh3lgSDXR4mxPLDC0bVWNWEI5?=
 =?iso-8859-1?Q?MuLgu03pD+IuB7Uxy+FtxNh8l3Q/Dfz7V17f+VoNVOucvG8GMzvdU1j/jb?=
 =?iso-8859-1?Q?yy6xSnjxCQJI6dIPHDEPxC8YKCwTdkzLtszKrhX6H792awkY1zckPgsGY/?=
 =?iso-8859-1?Q?NS23He+1Eje2WI6xJIrwmhcEN+DnE10Lj19t8Afb2BQyWLmIxD9/XqPGzr?=
 =?iso-8859-1?Q?wZVdTrkF14Uf+MTGDmSI1HkRjC3ys5v9j59rA0OD5NcyohbsfYcjVRdxcB?=
 =?iso-8859-1?Q?WVR0e6KjKWTYIVEo1/YihhkThZdR5tV6sSrD7J7oQh3+ly0sVoXMLXngNG?=
 =?iso-8859-1?Q?S9zAF96Dh2QLCeGIPY1PyGaYbmUdtTxZyxn0rgh7CtWWmIhCi/V5cDVW9J?=
 =?iso-8859-1?Q?QHg5Y/BDSoIoEqwCH1fB34qEVo1VEsieAUqIEbcQP4tVKSHdb1ZVJU+Bu+?=
 =?iso-8859-1?Q?gUdRDC1WRf9Z/OdC4nQH0QlpXIPkBDWx4qrUjR3/Fz4vn65KPuUMefSlJz?=
 =?iso-8859-1?Q?ukedTIwhKSEJzY0Vc2hI8b1r2ehVVQHEH5vwyeyHAoofv4bqpcEqcuTutp?=
 =?iso-8859-1?Q?OhMgx5yfUiGw1N1eztaJ/KeFQGZd6VvN/9GG7nleS3aNDtiga5bSzYSkPI?=
 =?iso-8859-1?Q?qSbtBBdjD4eXQ36VKke6Qo01qsbRhgX5hZg4lyIxrZGmimojv4VYlrDWMW?=
 =?iso-8859-1?Q?bMtEB/tdhL1Wc6+QxDPb9rXx72FxA0IyswVb7W9wUq2FfhsKwWDU8H53JW?=
 =?iso-8859-1?Q?h8BR6wPKxi/MmH2s/NDqMJLHC6tZijlK8Im35eNaSwlbTQ24XSu7QkOVRJ?=
 =?iso-8859-1?Q?2zqsZ0CTBqMog5icTMd41YQiRitu4eOgtXq/2Y3pHV9rslZERlWOvZ/hKz?=
 =?iso-8859-1?Q?KXT+xSCn4QNTrdlEgN4b/LX4T72hXmU3Cb5vKyYbqd302woEuMrEIXqQ4a?=
 =?iso-8859-1?Q?D1G8sL5S7rSbKrBOFq/Ndh3fK1d3y5iFtNRh3N6wIyhaBNwU+hSI07K/uC?=
 =?iso-8859-1?Q?fpgZE1bMmfFpXl1hbJDsNG2LrDCtDF0JMbvsVyDUwLZiy3jYJCzlg2Y0k9?=
 =?iso-8859-1?Q?sgZv6tQQcDzszUr+eN0CNXXpC9r0OwizX/93NtIyM21Tjt+t6Z5RLc4DCV?=
 =?iso-8859-1?Q?IxEP0VzwCp1nkVEUA1YV7Dw2M8gvNak1xfjDzQ4jzwUpbd2p4yQwjvPjkG?=
 =?iso-8859-1?Q?nHk7LvCkf8o567ZPxbJkltMieWy4n3/i6SnCuDwzozRH+mGMBBcq4LlkQA?=
 =?iso-8859-1?Q?ryDT3u15D/zdVM1GSY+pmMwvOz2xxm/jNWA9Mzc40AKrWLJrQEI4MzEef5?=
 =?iso-8859-1?Q?pRL9sctYl+9YL235lHqXYzLHTcUMsqoIzcqska5iSnBkS0DhfyGWLz+/sI?=
 =?iso-8859-1?Q?I5o484+r7lmW8LukN64=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e8496a22-d461-479a-81de-08dc2b9a7b6c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 07:16:07.7474
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Khh5TrvPhP3A3IqnMjold4DiMIABl+vGNYUjdbavh/0Exu65iTNfz1kbdJUgWqKLJmLSbLqaTBjXIhdT+ZYYPWISlL8zuGg5C5Q5tmVEw7w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4788
X-OriginatorOrg: intel.com

Hi,

On 2024-02-09 at 09:20:27 -0800, Reinette Chatre wrote:
>Hi Maciej,
>
>On 2/9/2024 6:01 AM, Maciej Wieczor-Retman wrote:
>
>...
>
>> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
>> index 5116ea082d03..f434a6543b4f 100644
>> --- a/tools/testing/selftests/resctrl/resctrl.h
>> +++ b/tools/testing/selftests/resctrl/resctrl.h
>> @@ -136,7 +136,9 @@ int get_domain_id(const char *resource, int cpu_no, int *domain_id);
>>  int mount_resctrlfs(void);
>>  int umount_resctrlfs(void);
>>  int validate_bw_report_request(char *bw_report);
>> -bool validate_resctrl_feature_request(const char *resource, const char *feature);
>> +bool resctrl_resource_exists(const char *resource);
>> +bool resctrl_mon_feature_exists(const char *resource, const char *feature);
>> +bool resource_info_file_exists(const char *resource, const char *file);
>
>Portion of next patch sneaked in here.

Missed it, thanks for pointing that out!

>
>>  bool test_resource_feature_check(const struct resctrl_test *test);
>>  char *fgrep(FILE *inf, const char *str);
>>  int taskset_benchmark(pid_t bm_pid, int cpu_no, cpu_set_t *old_affinity);
>> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
>> index 8a183c73bc23..af4f800ab23d 100644
>> --- a/tools/testing/selftests/resctrl/resctrlfs.c
>> +++ b/tools/testing/selftests/resctrl/resctrlfs.c
>> @@ -708,20 +708,16 @@ char *fgrep(FILE *inf, const char *str)
>>  }
>>  
>>  /*
>> - * validate_resctrl_feature_request - Check if requested feature is valid.
>> - * @resource:	Required resource (e.g., MB, L3, L2, L3_MON, etc.)
>> - * @feature:	Required monitor feature (in mon_features file). Can only be
>> - *		set for L3_MON. Must be NULL for all other resources.
>> + * resctrl_resource_exists - Check if a resource is supported.
>> + * @resource:	Resctrl resource (e.g., MB, L3, L2, L3_MON, etc.)
>>   *
>> - * Return: True if the resource/feature is supported, else false. False is
>> + * Return: True if the resource is supported, else false. False is
>>   *         also returned if resctrl FS is not mounted.
>>   */
>> -bool validate_resctrl_feature_request(const char *resource, const char *feature)
>> +bool resctrl_resource_exists(const char *resource)
>>  {
>>  	char res_path[PATH_MAX];
>>  	struct stat statbuf;
>> -	char *res;
>> -	FILE *inf;
>>  	int ret;
>>  
>>  	if (!resource)
>> @@ -736,8 +732,25 @@ bool validate_resctrl_feature_request(const char *resource, const char *feature)
>>  	if (stat(res_path, &statbuf))
>>  		return false;
>>  
>> +	return true;
>> +}
>> +
>> +/*
>> + * resctrl_mon_feature_exists - Check if requested monitoring feature is valid.
>> + * @resource:	Resource that uses the mon_features file. Currently only L3_MON
>> + *		is valid.
>> + * @feature:	Required monitor feature (in mon_features file).
>> + *
>> + * Return: True if the feature is supported, else false.
>> + */
>> +bool resctrl_mon_feature_exists(const char *resource, const char *feature)
>> +{
>> +	char res_path[PATH_MAX];
>> +	char *res;
>> +	FILE *inf;
>> +
>>  	if (!feature)
>
>Now that resource is a new parameter should it be checked also? It is not obvious
>why only one parameter is checked.

Right, I'll add the check there.

>
>Reinette

-- 
Kind regards
Maciej Wiecz?r-Retman