Received-SPF: pass (google.com: domain of linux-kernel+bounces-61184-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <0d4edea8f075311d3ecedf2471cd6ea3d3a282cf.camel@huaweicloud.com>
Subject: Re: [PATCH v3 02/13] security: Introduce the digest_cache LSM
From: Roberto Sassu <roberto.sassu@huaweicloud.com>
To: Randy Dunlap <rdunlap@infradead.org>, corbet@lwn.net,
 paul@paul-moore.com,  jmorris@namei.org, serge@hallyn.com,
 shuah@kernel.org, mcoquelin.stm32@gmail.com,  alexandre.torgue@foss.st.com,
 mic@digikod.net
Cc: linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, 
 linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, 
 bpf@vger.kernel.org, zohar@linux.ibm.com, dmitry.kasatkin@gmail.com, 
 linux-integrity@vger.kernel.org, wufan@linux.microsoft.com,
 pbrobinson@gmail.com,  zbyszek@in.waw.pl, hch@lst.de, mjg59@srcf.ucam.org,
 pmatilai@redhat.com,  jannh@google.com, dhowells@redhat.com,
 jikos@kernel.org, mkoutny@suse.com,  ppavlu@suse.com, petr.vorel@gmail.com,
 petrtesarik@huaweicloud.com, Roberto Sassu <roberto.sassu@huawei.com>
Date: Mon, 12 Feb 2024 09:02:19 +0100
In-Reply-To: <e8378ba2-ccd1-48fe-973d-38986fc0716d@infradead.org>
References: <20240209140917.846878-1-roberto.sassu@huaweicloud.com>
	 <20240209140917.846878-3-roberto.sassu@huaweicloud.com>
	 <e8378ba2-ccd1-48fe-973d-38986fc0716d@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-02-09 at 15:00 -0800, Randy Dunlap wrote:
> Hi--
>=20
> On 2/9/24 06:09, Roberto Sassu wrote:
> > diff --git a/security/digest_cache/Kconfig b/security/digest_cache/Kcon=
fig
> > new file mode 100644
> > index 000000000000..0c47d5151f07
> > --- /dev/null
> > +++ b/security/digest_cache/Kconfig
> > @@ -0,0 +1,17 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +config SECURITY_DIGEST_CACHE
> > +	bool "Digest_cache LSM"
> > +	default n
> > +	help
> > +	   This option enables an LSM maintaining a cache of digests
> > +	   (e.g. of file content or metadata).
> > +
> > +	   This LSM can support other kernel components in making access
> > +	   control decisions.
> > +
>=20
> nit:  -ESTYLE.
> coding-style.rst says:
>=20
> Lines under a ``config`` definition
> are indented with one tab, while help text is indented an additional two
> spaces.
>=20
> > +config DIGEST_LIST_DEFAULT_PATH
> > +	string
> > +	default "/etc/digest_lists"
> > +	help
> > +	   Default directory where digest_cache LSM expects to find digest
> > +	   lists.
>=20
> Same comment for patch 03/13.
> Same comment for patch 04/13.

Hi Randy

thanks, will apply your suggestions to the next version.

Roberto