Received-SPF: pass (google.com: domain of linux-kernel+bounces-61190-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 12 Feb 2024 08:11:10 +0000
From: Conor Dooley <conor.dooley@microchip.com>
To: Inochi Amaoto <inochiama@outlook.com>
CC: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd
	<sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Chen
 Wang <unicorn_wang@outlook.com>, Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
	Jisheng Zhang <jszhang@kernel.org>, Liu Gui <kenneth.liu@sophgo.com>, Jingbao
 Qiu <qiujingbao.dlmu@gmail.com>, <dlan@gentoo.org>,
	<linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v7 3/8] clk: sophgo: implement clk_ops for CV1800 series
 clock controller driver
Message-ID: <20240212-list-grumble-819f7988aaad@wendy>
References: <IA1PR20MB49533B0C8B05FF5679E0C2F4BB442@IA1PR20MB4953.namprd20.prod.outlook.com>
 <IA1PR20MB49534558A17C332722AF5BC2BB442@IA1PR20MB4953.namprd20.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="g/NQAsoQx7SfAKyW"
Content-Disposition: inline
In-Reply-To: <IA1PR20MB49534558A17C332722AF5BC2BB442@IA1PR20MB4953.namprd20.prod.outlook.com>

--g/NQAsoQx7SfAKyW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 08, 2024 at 04:48:51PM +0800, Inochi Amaoto wrote:
> Add clk_ops implement of pll and ip clocks for the clock controller.
>=20
> Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> Link: https://github.com/milkv-duo/duo-files/blob/6f4e9b8ecb459e017cca1a8=
df248a19ca70837a3/duo/datasheet/CV1800B-CV1801B-Preliminary-Datasheet-full-=
en.pdf

On 64-bit with clang:
drivers/clk/sophgo/clk-cv18xx-ip.c:745:6: warning: variable 'flags' is used=
 uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
drivers/clk/sophgo/clk-cv18xx-ip.c:745:6: warning: variable 'flags' is used=
 uninitialized whenever '||' condition is true [-Wsometimes-uninitialized]
on 32-bit there's also:
drivers/clk/sophgo/clk-cv18xx-pll.c:28:2: warning: comparison of distinct p=
ointer types ('typeof ((rate)) *' (aka 'unsigned long *') and 'uint64_t *' =
(aka 'unsigned long long *')) [-Wcompare-distinct-pointer-types]
drivers/clk/sophgo/clk-cv18xx-pll.c:28:2: error: incompatible pointer types=
 passing 'unsigned long *' to parameter of type 'uint64_t *' (aka 'unsigned=
 long long *') [-Werror,-Wincompatible-pointer-types]

Cheers,
Conor.

--g/NQAsoQx7SfAKyW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZcnSngAKCRB4tDGHoIJi
0opHAQC3h+Tx3CIi4UWF2q9YXffVkxcQyWOu5A5XV45+p/LBvAD9Ft5wyfLaV0oR
K9Bd0hf1eg8NOcyQIXKmbekTDXSUhQs=
=SAO8
-----END PGP SIGNATURE-----

--g/NQAsoQx7SfAKyW--