Received-SPF: pass (google.com: domain of linux-kernel+bounces-61186-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 12 Feb 2024 08:03:44 +0000
From: Conor Dooley <conor.dooley@microchip.com>
To: Eric Chan <ericchancf@google.com>
CC: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
	<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv/fence: Consolidate fence definitions and define
 __{mb,rmb,wmb}
Message-ID: <20240212-projector-dangle-7815fa2f7415@wendy>
References: <20240209125048.4078639-1-ericchancf@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="ebJOijojLM2Tum/8"
Content-Disposition: inline
In-Reply-To: <20240209125048.4078639-1-ericchancf@google.com>

--ebJOijojLM2Tum/8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 09, 2024 at 12:50:48PM +0000, Eric Chan wrote:
> Disparate fence implementations are consolidated into fence.h.
>=20
> Introduce __{mb,rmb,wmb}, and rely on the generic definitions
> for {mb,rmb,wmb}. A first consequence is that __{mb,rmb,wmb}
> map to a compiler barrier on !SMP (while their definition remains
> unchanged on SMP).
>=20
> Introduce RISCV_FULL_BARRIER and use in arch_atomic* function.
> like RISCV_ACQUIRE_BARRIER and RISCV_RELEASE_BARRIER, The fence
> instruction can be eliminated When SMP is not in use.
>=20
> Also clean up the warning with scripts/checkpatch.pl.
>=20
> Signed-off-by: Eric Chan <ericchancf@google.com>

In all configs:
=2E./arch/riscv/include/asm/fence.h:7:10: error: expected expression before=
 '__asm__'
https://patchwork.kernel.org/project/linux-riscv/patch/20240209125048.40786=
39-1-ericchancf@google.com/

Cheers,
Conor.

--ebJOijojLM2Tum/8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZcnQ4AAKCRB4tDGHoIJi
0sdrAP43QWVvr0zKgeBa6w6Y/sgMo/4Pcvh3acMhUeUKhio0qAD9H+0DWZR1hpVa
voHkI4IVSQqkjJRiydpEv2XrMfDviA0=
=ib6c
-----END PGP SIGNATURE-----

--ebJOijojLM2Tum/8--