Received-SPF: pass (google.com: domain of linux-kernel+bounces-61268-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 12 Feb 2024 17:57:22 +0800
From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>, Alex Elder <elder@linaro.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Wolfram Sang <wsa@the-dreams.de>, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v3 23/24] gpio: remove the RW semaphore from the GPIO
 device
Message-ID: <20240212095722.GB388487@rigel>
References: <20240208095920.8035-1-brgl@bgdev.pl>
 <20240208095920.8035-24-brgl@bgdev.pl>
 <20240210053730.GA187163@rigel>
 <CAMRc=Mcq2Obf58=iLHpm5B2_KkHCqRevFWupbBuKmNs_BV6i2g@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMRc=Mcq2Obf58=iLHpm5B2_KkHCqRevFWupbBuKmNs_BV6i2g@mail.gmail.com>

On Mon, Feb 12, 2024 at 10:53:07AM +0100, Bartosz Golaszewski wrote:
> On Sat, Feb 10, 2024 at 6:37 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > On Thu, Feb 08, 2024 at 10:59:19AM +0100, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > With all accesses to gdev->chip being protected with SRCU, we can now
> > > remove the RW-semaphore specific to the character device which
> > > fullfilled the same role up to this point.
> > >
> >
> > fulfilled
> >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > > ---
> > >  drivers/gpio/gpiolib-cdev.c | 1 -
> > >  drivers/gpio/gpiolib.c      | 4 ----
> > >  drivers/gpio/gpiolib.h      | 5 -----
> > >  3 files changed, 10 deletions(-)
> > >
> > > diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> > > index ccdeed013f6b..9323b357df43 100644
> > > --- a/drivers/gpio/gpiolib-cdev.c
> > > +++ b/drivers/gpio/gpiolib-cdev.c
> > > @@ -24,7 +24,6 @@
> > >  #include <linux/pinctrl/consumer.h>
> > >  #include <linux/poll.h>
> > >  #include <linux/rbtree.h>
> > > -#include <linux/rwsem.h>
> > >  #include <linux/seq_file.h>
> > >  #include <linux/spinlock.h>
> > >  #include <linux/timekeeping.h>
> >
> > Shouldn't this be part of the rwsem -> srcu switch in the previous
> > patch?
> >
>
> That other patch was already huge. I figured this should be separate.
>

To be clear, I mean just this header removal, not the whole patch.

Cheers,
Kent.