Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2369260rdb; Mon, 12 Feb 2024 02:31:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGaH33ltQO/ieJOzQuxkc/CqMLPmbIhuqbYUJaf0INwNrjTaLCB756GNytAHzm+kcXwh/sm X-Received: by 2002:a05:6871:3a20:b0:21a:c53:273b with SMTP id pu32-20020a0568713a2000b0021a0c53273bmr5954246oac.51.1707733880018; Mon, 12 Feb 2024 02:31:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707733879; cv=pass; d=google.com; s=arc-20160816; b=HWy6y7fsjMHuI1YP+AmxT3CjTDK5bGF2gAkUgu2Z5p6GqTtRx37YnE5xu72BBmb6L2 QalHNulMpUIW01GPLEVwCxzCVYrTUFEWG32d4CdfpFQKZI5MLUWv33rOJx7Yqbzd9kNz ZuG0XyAwk/FNHchFsF3wgPzny3SfFzvQtVmmn50e3nyXnRt/nwHRIonoStdl6DLFUa1T klUpeL6yGWDqQVoj8NiUzMXZlyW7q3Isz8z126g9KANJDM2nuNBCPSK8QrhxGV7UxYW5 aXizXt7MU7rn8V/cwedFB2NjS5ypjLZt7bF5J0tc7ORB7MBOujOcDBZz1SUYO07BFfOJ D2nQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature; bh=0KQsUMRuvZ9A1LtHxdaXPH5EiJdnjk1zjtv1t86DCpQ=; fh=Pgw2MqpU/RYxpt8Mo0yXSyxsaLK/QPf2+iuB/siEwWw=; b=RG7LEBLaUm8P20+rIKgbtQzH7RsAzOhekLQ6ZWxZPjw7lLNfk5UCXByMwORtvfQfCu p9L48Ob5ykrA8S0ehsIsJDv8Dxg9GTn8iWuwbR//nSwJYcROUdBIsEmbruhHKoQZ4xJD bdVTMzQM/cYCx4CMZOaNLkjnJidFOH4lX/Bl3jkLaIWLsDxh/V1HPPvndwK/7fLQ4/pt gp0EKXogBoQZKf3x31tG+1A5pdud21WjNcocp0SNPk2OnWo1D4weF6J0NAKUzRNvzssB aIn5QkNPG7glrQIpVZhWScndfGqRiwJtsgfQJHKGEAsCgutBX/grTs6U41EzsQnxtWa4 S58w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="pOhO/3Jd"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="pOhO/3Jd"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-61313-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61313-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de X-Forwarded-Encrypted: i=2; AJvYcCWJbkL7jnFtK+1fa9caq+myovaGPcHJbC5wXil997oZwllzUz4a8EyrRKSphsGqiDvW6Zg4Dz19Yu3IBm/+QRKvoc8EyGifA0WNfqqvgg== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e12-20020ac8598c000000b0042c6af552b5si74566qte.63.2024.02.12.02.31.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 02:31:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-61313-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="pOhO/3Jd"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="pOhO/3Jd"; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-61313-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61313-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 84BBA1C208BE for ; Mon, 12 Feb 2024 10:31:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BD16A1BDC2; Mon, 12 Feb 2024 10:31:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="pOhO/3Jd"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="NeUOnyoA"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="pOhO/3Jd"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="NeUOnyoA" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93284182AF for ; Mon, 12 Feb 2024 10:31:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707733872; cv=none; b=HWzWl14ts4a6K1FwHeMwbrPTNPCsYkSVsQg+9CyB9eMqZmYZcrKRgLaGi4rX7ewe+pnbLCvi2Uqok/8RSqYWNsrJqFf0lVr1LXXPNu/Wg5UeeVCBWeNLeTbDcSRxYrVbXEAFFhnFwGZbB/Hx+hN4Y2Y6bsn1gqRj4MfA7arDPwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707733872; c=relaxed/simple; bh=0KQsUMRuvZ9A1LtHxdaXPH5EiJdnjk1zjtv1t86DCpQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CBu2voL5+0LLHHrd0ibR1HWkabgF5OPOVjJB+u8fZZHI260Ro0/wj9HAc+bwO4mhB+MhBlafHKIzUByGIgcQz2qYdJ1RUCaSPkrDB4IAE6NMSkN2taQJEdw2HvaIzS2YOMEvhRIgGShprwhCwR99HYGz0DvRXFXwGCMa1TcI3+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=pOhO/3Jd; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=NeUOnyoA; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=pOhO/3Jd; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=NeUOnyoA; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BE93922150; Mon, 12 Feb 2024 10:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707733868; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KQsUMRuvZ9A1LtHxdaXPH5EiJdnjk1zjtv1t86DCpQ=; b=pOhO/3JdQaXLpYApqTZSH8xxg2XOuI9uLnL6Htd2aZVny8ClVeaJT8STJeCK/R6Z0EuwIf 6Z2/hFB3sOEwyNxOn5SRGiXMVut6/IsTb0Pig1o3rbpBPa5OIlSBaTgPd3OR5R9ltOCGHX VQ8jhAC64ORNcW+70T7hMublScVcOcg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707733868; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KQsUMRuvZ9A1LtHxdaXPH5EiJdnjk1zjtv1t86DCpQ=; b=NeUOnyoAlr116GKVt4Qmx/2tGtja7xZ5TOeZ9xTAceoEA9B/Tl5duJAvWJvv/N02BtYe3K /uQTc9H4xTmfUdCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707733868; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KQsUMRuvZ9A1LtHxdaXPH5EiJdnjk1zjtv1t86DCpQ=; b=pOhO/3JdQaXLpYApqTZSH8xxg2XOuI9uLnL6Htd2aZVny8ClVeaJT8STJeCK/R6Z0EuwIf 6Z2/hFB3sOEwyNxOn5SRGiXMVut6/IsTb0Pig1o3rbpBPa5OIlSBaTgPd3OR5R9ltOCGHX VQ8jhAC64ORNcW+70T7hMublScVcOcg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707733868; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KQsUMRuvZ9A1LtHxdaXPH5EiJdnjk1zjtv1t86DCpQ=; b=NeUOnyoAlr116GKVt4Qmx/2tGtja7xZ5TOeZ9xTAceoEA9B/Tl5duJAvWJvv/N02BtYe3K /uQTc9H4xTmfUdCA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id AE1C913A0E; Mon, 12 Feb 2024 10:31:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id paoQKWzzyWWqCQAAn2gu4w (envelope-from ); Mon, 12 Feb 2024 10:31:08 +0000 Date: Mon, 12 Feb 2024 11:31:08 +0100 From: Daniel Wagner To: Keith Busch Cc: Hannes Reinecke , James Smart , Christoph Hellwig , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH v5 12/12] nvmet-fc: use RCU list iterator for assoc_list Message-ID: References: <20240131085112.21668-1-dwagner@suse.de> <20240131085112.21668-13-dwagner@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -3.78 X-Spamd-Result: default: False [-3.78 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.98)[99.92%] X-Spam-Flag: NO On Tue, Feb 06, 2024 at 11:22:49AM -0800, Keith Busch wrote: > That said, the rcu_read_lock() seems like it should be moved to > nvmet_fc_assoc_exits() since that's the only part reading rcu protected > structures. FTR, here is a fix: https://lore.kernel.org/linux-nvme/20240212102940.11137-1-dwagner@suse.de/