Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2387791rdb; Mon, 12 Feb 2024 03:18:35 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW8dIRDoY7gmnYgf5tnbHnYA9uY9k2/zHc9jcfyt0hJhPp+aqcK7NW8KqfTF8CKVsEw6o3IuR6p2RZfjGVfYaZzjRp5vV4XQvEk1j+G6Q== X-Google-Smtp-Source: AGHT+IEpM8MIwWyJqbTLC7+K4NUVTQxLVDFiPwjiZ+HG3lCl03AKYConR/NPG0JrbBqzkqXDNpy7 X-Received: by 2002:a05:6830:1217:b0:6e2:e14c:1fdc with SMTP id r23-20020a056830121700b006e2e14c1fdcmr3657656otp.22.1707736714932; Mon, 12 Feb 2024 03:18:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707736714; cv=pass; d=google.com; s=arc-20160816; b=ibh3BHds7r9CBd3KvGllvF5sOnqlS7nAYUv13Q/yKz2kxilyOXSWA4dyXpJZ1YS6WA qYbq/uCFt+ekrtkD1/aUgAnM9NQe6gLd8Vc5QvTVsTAfsuq6VY5Qsn+9Hr+2DfNg8YSJ oK7rYi9ggB7n7jym7E5r+Uui/+CVn8bNCVI+JYs5ckAnVSFZOYC/dq5BWo68JHmKDEYj ndvBuFvXbMZZGGXg1ozTtTOoWds02wkbSiDo4fIGdO7/r2r44auX3gT/lz71Wrvagv2L uOrafez86SV7lCYpgeP0nQOquEJmICzaeuzDH2MLExY1PKF4l5RpzHRExeMWws/VHyMm 6B2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=fg3i5iS6DyUPk7IG+bZwdzOWeGLyzl5eDtcjw3HsDcs=; fh=KJqSxgPEfQe+DA10RQg259YOePonTSk0o9IdKEsCL2k=; b=MwrdrAF+igSm8yeqDikpUurck2ClYEVho5QQ9ALqCIBQZJ0y/GLue9fQtk1xLtEw05 5M1reNdJChVm+JLLa50v+tY3j7DgKb14QILkoDoK7iVEzyUXUaxtJECZOhAG4ja9sVcp Nqz/G3SA0z/33xzPHej+osYlLdW/Cuc+LD5gbwzlsP1guizGl3P+HwTqCxB5i0Zh7xtY Lz5YUG6IeIwuDbF/SCow2uRB5m7vDWIdlBC+8e8zQwbQx0Txf57R3cgpTce48DJ8WWa9 Mtw/tBnZd2/ZjKX8G1imptq3hqQ1APVv6iWN7+Da1PpUzmC19Nq2ARqtPtQLNbvYoErk RYYQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m1OuXjK8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-61408-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61408-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUxeVQqMbUwcd6hpNY7KTDCMo9tsSjt7qyG1PLfNvyOobohuqGvWVXMg7gWqFmVKhM2SuaH7F7cwIgdH9SEQmmLRHzaQhlUnYiDEOoOWA== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id ee11-20020a05620a800b00b0078633c00aa1si488235qkb.492.2024.02.12.03.18.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 03:18:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-61408-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=m1OuXjK8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-61408-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61408-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A8C6E1C217C2 for ; Mon, 12 Feb 2024 11:18:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6511338FA9; Mon, 12 Feb 2024 11:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m1OuXjK8" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89E722BAE7; Mon, 12 Feb 2024 11:18:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707736706; cv=none; b=N41Dt154xHFD4JxPseBTjjhulTok+VEX1BoraXj5KeG5nh6h7V9fD+TrOTr3NUHJeVsx8vPu2BbkMx14UDD4T07S85Esdtk6Lc+qqfIPZhvtfpeWx3ZzJZtzfSEp0pC8lsauMfc1X6xQ2uz5iURx/3sRTQMJlizV4A6amKRG06w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707736706; c=relaxed/simple; bh=1lR4IsJGmLUexDJX/zjNYB7tgsa4JkZ3HcVTMHB2dNc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=QIAs2vceSqIax5QePmVlBWZewiSyRJLN286BXnyu068jFSeuO1vaBLyFgL+C3BqGLYfS3fULK7JNV+6wC0ZTQSf+L6bRUr8foj3oxfeB0bf+KAcGu1PBtE/4atHoEKiWZ4j9fBrcLnWiv/7e/ML/ZlZtYfmy2SjqWbjpOgSoJcc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m1OuXjK8; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2547EC433F1; Mon, 12 Feb 2024 11:18:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707736706; bh=1lR4IsJGmLUexDJX/zjNYB7tgsa4JkZ3HcVTMHB2dNc=; h=From:To:Cc:Subject:Date:From; b=m1OuXjK8CZ+NAI6SOCsY1TaOBBI3XiORFTXfFMQ9vxA3c3yftkO8wpysTgFM97Q3q bJUqMUv9ebPvJdBSdzXnkFLHSJgYchoroVRa8XgogGgE8l064Eo3Ghdhf3jg5hwyJl 4fqFxaCSroYO4hMXj0JJr2eCkQeJH2FsKa/XxCMLTF08OZi4sDZhk5d4EIO8VIn81v 9kacs51BlOrxwHS56vkiZ6hTcegnAOltkl8drmJ0SKdBFZ0zjLBdIfO6cP9mvxB/gj zi1/nt8vcFiDJd/NTcmShtimOwOfvSTY+uyVdS4rcFPqrYrg+WxiRuF1nN9IH6umil 1JgxnCfdxJT7g== From: Arnd Bergmann To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , =?UTF-8?q?Duje=20Mihanovi=C4=87?= , Linus Walleij Cc: Arnd Bergmann , Flavio Suligoi , Hans de Goede , Jianhua Lu , "Matthew Wilcox (Oracle)" , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] backlight: ktd2801: fix LED dependency Date: Mon, 12 Feb 2024 12:18:12 +0100 Message-Id: <20240212111819.936815-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann The new backlight driver unconditionally selects LEDS_EXPRESSWIRE, which is in a different subsystem that may be disabled here: WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=y] Selected by [y]: - BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y] Change the select to depends, to ensure the indirect dependency is met as well even when LED support is disabled. Fixes: 66c76c1cd984 ("backlight: Add Kinetic KTD2801 backlight support") Signed-off-by: Arnd Bergmann --- drivers/video/backlight/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig index 230bca07b09d..f83f9ef037fc 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -185,7 +185,7 @@ config BACKLIGHT_KTD253 config BACKLIGHT_KTD2801 tristate "Backlight Driver for Kinetic KTD2801" - select LEDS_EXPRESSWIRE + depends on LEDS_EXPRESSWIRE help Say Y to enable the backlight driver for the Kinetic KTD2801 1-wire GPIO-controlled backlight found in Samsung Galaxy Core Prime VE LTE. -- 2.39.2