Received-SPF: pass (google.com: domain of linux-kernel+bounces-61420-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <d698b3a0-c4a9-1ff1-dbf0-f795b5d4f29c@amd.com>
Date: Mon, 12 Feb 2024 16:54:31 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] iommu/amd: Mark interrupt as managed
Content-Language: en-US
To: Mario Limonciello <mario.limonciello@amd.com>, joro@8bytes.org,
 suravee.suthikulpanit@amd.com
Cc: will@kernel.org, robin.murphy@arm.com, iommu@lists.linux.dev,
 linux-kernel@vger.kernel.org
References: <20240122233400.1802-1-mario.limonciello@amd.com>
From: Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <20240122233400.1802-1-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a1RUOGFDUml2NHp5SlhuNEpiZm9sSEMxOW9qMGtCVVNPdmhWcUNXRy9SdjYw?=
 =?utf-8?B?ODdhcjNwQnhVQUlhSWphcnhJNVR1Y1hsalJxWE4yaXd6enkzVjQ0RDlqT3gy?=
 =?utf-8?B?MitHNHN2d1lzK3NWVzg1UkNicXBoODJ5L2Nlc0FidHVzOVBaM3lReWhJSHVO?=
 =?utf-8?B?Rk54bEpjZGtzeWRSdVpEZGt4TzN5YWZONFFyNHRja0loK3FESTNyaVN5YTl2?=
 =?utf-8?B?bGFwNmNuZUkrMnljUjJRd05kWTF2azFORHl1ZGNjMFJKekpSYURhSXpUcklj?=
 =?utf-8?B?QkJMcDc4aFNOa21kNEx4VlpLZnVTUnh1VUJlcTVzSHRvZ21paDF4ZytCek9G?=
 =?utf-8?B?aDRDTkMxRVgxdDlRbVRBbEFEZ25jOEpCMUlRVHp2OVA1N0NodTdWQTJZcW40?=
 =?utf-8?B?UGZsM3lZTEl1a1JyUU8rdUUwZXlwVWg5bXpIanZCOFpGY0hZSFFLd2ZKV3hJ?=
 =?utf-8?B?R3ZXT3FpU2dRRXBFNUJMWVRqdlhQanM3b3RpVmNSSWtiN1MvdXc5dVBRQnc4?=
 =?utf-8?B?Q29BSWhQc1J0Q0ZvVGRZb0tqcTNkUXJHZUNYSUtaUituYTdPU0VLOWs4Rzhj?=
 =?utf-8?B?V3pMSXQ1U091dHhGMVpoTExrdUExR2hmZHdwalJQRGFjT2R0bFBSK0dWUU5Q?=
 =?utf-8?B?ZFBRS3cwNTB5MVZpVHVrdVVhajB2aDliVEtkSVh2ajQzenBWK0c1K0VBb3A4?=
 =?utf-8?B?aFhBM1FIeGtlZUx1eDJRV3FsS1lzWXErcE9RNWNBeWxqVjE5c2ZDQmh4a2F1?=
 =?utf-8?B?M1grajJrUnRZSWxUNkN3Z1ZRMFFmeDV2MFhlUEF3cnFmbVhJODhQaGFOM1Ro?=
 =?utf-8?B?UFlIZ1h6R0pubEJQUFB3Wnh4TVc2bjJ4Rnk2T2RGdkcwd1FjR3R2Um9valY1?=
 =?utf-8?B?aSthMWtZa3V2NHdMN0l6YXgvWXNidTA2WXRQc2RjRE1abEIrZjNpOUtOQVlj?=
 =?utf-8?B?RWc3Y0lqQll3MFFQdG1VSlVEd21ZRmFSV1pUeWdaclRWcmY3TER1WERMOVhE?=
 =?utf-8?B?eDhmVWN5Q2Q4dklnQ1lsZ0JCbTZEdENnakRQRTRNYlpLRFRTRWVOUUx0ZXp6?=
 =?utf-8?B?bTBFZjNhRWs1NVNNZHpmdjBZUGFEMzYxUnNVTHMvV2kwV2h3T2NjaGRqQWwx?=
 =?utf-8?B?RFc5NUhWUlFETnlvQ3didHY2VEtXbENjdVBBUDVJZkJuc1Z5dkQvdHNpeU9j?=
 =?utf-8?B?SHpMY3NEVjkreTg0WmJhSFlDTFJCQUhibHdKVWh2TGhBbEh4ck5Wd0dkREJS?=
 =?utf-8?B?SUhVZUNjVTFQK1E4MnFKc3F4b2xVZW50a1UvU29NbFlaMnNON2RyakV3TEFN?=
 =?utf-8?B?U2xRV3pZdUxodWREREhlK1BqNlY5WHV4TFpiT1cvdVRPV0lCWGk3M3RYOU84?=
 =?utf-8?B?TlcrN2dPYUFPWTlpa1p1RDFoRy9VNHZpVGxBb0ZLNGtOUThBWE9HcGlSNWRa?=
 =?utf-8?B?Z25aV2MrWjZWYjRXYXBoa1kwb1BVYU03Z1NtNlIxUTFUSXVFalNzUlhwOWVr?=
 =?utf-8?B?VFZlVlU2bXh1WU9CbTI4U1pFMlpRR0E0bVBraUtWK1gwYXBqYUdtUVRMRElq?=
 =?utf-8?B?QzI3aitMYXZYSnh4cVVRUFpORzZoQmdjNEtRSmJvU2ZpVDNzWVFMRGI5TUxw?=
 =?utf-8?B?QVNpUkI4aDA2QjBEeHY0M1VZZFpjM0ZNbWZtMzV3cVhGZVVFb0IxV0M1NFAv?=
 =?utf-8?B?VlVjTWVFc0xON09RRkNmWlRLd3QwdVZpa256MTJQTndWYVowZS9iUUZqb05M?=
 =?utf-8?B?WENmTnp5OFFGRUZRRnd2dXJrRzhiTU5kQndiY29qWmVuWExMM3JDWTUzblFY?=
 =?utf-8?B?K3NodDVUSE5OczVkb3dSazRHOXdxWk85ZndyeXlOMjVHVmpWdjd6bVlqaitO?=
 =?utf-8?B?cXZSTkFMN09oTy9sbVJyeDVlRVdjSjJPcUVHNjhYKytyeUhRMEp5UnIxN2xo?=
 =?utf-8?B?cjd4cmVWL1lxd0RiYmp3NS9XZzJFRzB1ckkvUlRiU1RLTDZsb2p3b2ZTbU1n?=
 =?utf-8?B?a1BNd2thUEhGVDlEemxXN3hXaUQ0N1NhaW1rclhIZGd2SHBkVVF5d3ZXYWNK?=
 =?utf-8?B?VlpPWTJtbXhqK3BrVFdnNTJtMXFrSDBVM2QydHgwZ3pVVVgvM3dCbFZGV3N4?=
 =?utf-8?Q?qk97NqsjJ0wtJri6DqES86B1m?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 323348ff-ce8c-4611-0845-08dc2bbd33d8
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6043.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 11:24:40.1347
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AkQVMoR+b62OvbZPjLC4+LsuQX4WJ3HEdLPy1SiCHlXGtmhTdrk6wbEsinY33uT6rQSuGamzZeiAwZNAzym6TQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9110


On 1/23/2024 5:04 AM, Mario Limonciello wrote:
> On many systems that have an AMD IOMMU the following sequence of
> warnings is observed during bootup.
> 
> ```
> pci 0000:00:00.2  can't derive routing for PCI INT A
> pci 0000:00:00.2: PCI INT A: not connected
> ```
> 
> This series of events happens because of the IOMMU initialization
> sequence order and the lack of _PRT entries for the IOMMU.
> 
> During initialization the IOMMU driver first enables the PCI device
> using pci_enable_device().  This will call acpi_pci_irq_enable()
> which will check if the interrupt is declared in a PCI routing table
> (_PRT) entry. According to the PCI spec [1] these routing entries
> are only required under PCI root bridges:
> 	The _PRT object is required under all PCI root bridges
> 
> The IOMMU is directly connected to the root complex, so there is no
> parent bridge to look for a _PRT entry. The first warning is emitted
> since no entry could be found in the hierarchy. The second warning is
> then emitted because the interrupt hasn't yet been configured to any
> value.  The pin was configured in pci_read_irq() but the byte in
> PCI_INTERRUPT_LINE return 0xff which means "Unknown".
> 
> After that sequence of events pci_enable_msi() is called and this
> will allocate an interrupt.
> 
> That is both of these warnings are totally harmless because the IOMMU
> uses MSI for interrupts.  To avoid even trying to probe for a _PRT
> entry mark the IOMMU as IRQ managed. This avoids both warnings.
> 
> Link: https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/06_Device_Configuration/Device_Configuration.html?highlight=_prt#prt-pci-routing-table [1]
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Patch looks good to me.

Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>

-Vasant

> ---
>  drivers/iommu/amd/init.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
> index c83bd0c2a1c9..40979b0f5250 100644
> --- a/drivers/iommu/amd/init.c
> +++ b/drivers/iommu/amd/init.c
> @@ -2068,6 +2068,9 @@ static int __init iommu_init_pci(struct amd_iommu *iommu)
>  	/* Prevent binding other PCI device drivers to IOMMU devices */
>  	iommu->dev->match_driver = false;
>  
> +	/* ACPI _PRT won't have an IRQ for IOMMU */
> +	iommu->dev->irq_managed = 1;
> +
>  	pci_read_config_dword(iommu->dev, cap_ptr + MMIO_CAP_HDR_OFFSET,
>  			      &iommu->cap);
>  
> 
> base-commit: 75f74f85a42eb294b657f847c33e1bb7921dbec9