Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755754AbXLVX3q (ORCPT ); Sat, 22 Dec 2007 18:29:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753617AbXLVX3j (ORCPT ); Sat, 22 Dec 2007 18:29:39 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:49008 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752472AbXLVX3i (ORCPT ); Sat, 22 Dec 2007 18:29:38 -0500 Date: Sat, 22 Dec 2007 23:29:22 +0000 From: Al Viro To: Linus Torvalds Cc: Theodore Tso , Ingo Molnar , Andi Kleen , Christoph Lameter , Peter Zijlstra , Steven Rostedt , LKML , Andrew Morton , Christoph Hellwig , "Rafael J. Wysocki" Subject: Re: Major regression on hackbench with SLUB (more numbers) Message-ID: <20071222232922.GO8181@ftp.linux.org.uk> References: <1198275391.30889.3.camel@lappy> <1198275453.30889.4.camel@lappy> <20071221225413.GA26189@elte.hu> <20071222100326.GF26157@elte.hu> <20071222192550.GD28891@thunk.org> <20071222215009.GN8181@ftp.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071222215009.GN8181@ftp.linux.org.uk> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1686 Lines: 35 On Sat, Dec 22, 2007 at 09:50:09PM +0000, Al Viro wrote: > On Sat, Dec 22, 2007 at 01:00:09PM -0800, Linus Torvalds wrote: > > > > Another problem with using /sys/slab is that it is downright *ugly*. > > > Why is it for example, that /sys/slab/dentry is a symlink to > > > ../slab/:a-0000160? > > > > That's the only really ugly thing there. Otherwise, it's pretty nice, but > > having a million files makes for problems when trying to send somebody > > else the full info. > > *raised brows* > > I would say that there's that really ugly thing with embedding kobject > into a struct with the lifetime rules of its own and then having that > struct kfree()d while kobject might still have references, but hey, > maybe it's just me and my lack of appreciation of the glory that is > sysfs. > > Al, too tired of ranting about sysfs being a major architecture > mistake and a recurring source of turds like that one... BTW, the fact that presence of that kobject is conditional makes life even uglier - we have to either kfree() or drop a reference to kobject leaving actual kfree() to its ->release(). While we are at it, when do we remove the symlinks? That got to add even more fun for the lifetime rules... Sigh... How does one set a script that would mail a warning upon git pull that introduces any instances of keyword from given set? I hadn't noticed that slub was using sysfs when it went into the tree back in May ;-/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/