Received-SPF: pass (google.com: domain of linux-kernel+bounces-61435-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Sven Eckelmann <sven@narfation.org>
To: syzbot <syzbot+a6a4b5bb3da165594cff@syzkaller.appspotmail.com>,
 Eric Dumazet <edumazet@google.com>
Cc: a@unstable.cc, b.a.t.m.a.n@lists.open-mesh.org, davem@davemloft.net,
 kuba@kernel.org, linux-kernel@vger.kernel.org, mareklindner@neomailbox.ch,
 netdev@vger.kernel.org, pabeni@redhat.com, sw@simonwunderlich.de,
 syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [batman?] BUG: soft lockup in sys_sendmsg
Date: Mon, 12 Feb 2024 12:23:51 +0100
Message-ID: <2173575.irdbgypaU6@ripper>
In-Reply-To:
 <CANn89iKPYAY226+kV9D0jUn6Kfjq1gQJBAjSRxxFgQJK-QbLwA@mail.gmail.com>
References:
 <000000000000ae28ce06112cb52e@google.com>
 <CANn89iKPYAY226+kV9D0jUn6Kfjq1gQJBAjSRxxFgQJK-QbLwA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart13450391.uLZWGnKmhe";
 micalg="pgp-sha512"; protocol="application/pgp-signature"

--nextPart13450391.uLZWGnKmhe
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"; protected-headers="v1"
From: Sven Eckelmann <sven@narfation.org>
Subject: Re: [syzbot] [batman?] BUG: soft lockup in sys_sendmsg
Date: Mon, 12 Feb 2024 12:23:51 +0100
Message-ID: <2173575.irdbgypaU6@ripper>
MIME-Version: 1.0

On Monday, 12 February 2024 11:41:38 CET Eric Dumazet wrote:
> This patch [1] looks suspicious

Shouldn't be caused by this - but this might be another way to trigger the 
problem. The problem would be visible even without it when a mtu is explicitly 
set. But the reproducer is not available so I can't actually check what is 
going on.

> I think batman-adv should reject too small MTU values.

You are refering to the size calculated by 
batadv_tt_local_table_transmit_size(), right? And yes, I would agree that it 
looks suspicious and might not have been correctly integrated in 
batadv_max_header_len() when commit a19d3d85e1b8 ("batman-adv: limit local 
translation table max size") introduced the code. But I think we also need to 
remove interfaces again when receiving NETDEV_CHANGEMTU and an interface is 
not having the correctly sized anymore. So have to check how to do this the 
best way.

Kind regards,
	Sven
--nextPart13450391.uLZWGnKmhe
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAmXJ/8cACgkQXYcKB8Em
e0ZZFw/+N3em2ptTXcnr3+ApNV8/D8QriRS0O6mBuF8Hijfj6xnYM1hPFaRImy21
WtJjnb2ti7uavNtiBKGR71EUpLW8nNsdI/tB/Pc3ndzy/AOMN9/+JqQE6ekD9K0I
n7rKn5MqBoYjIPMB06lm26Cgx5WyDr3Lkuu3S2OCP3mZZ9+g/p3T0ALJR1c1dkSd
iTM9Yl5zapFzbtebJEa3ywLfeWVApBh0sTpWgfkevsS1OnkRnep59h/KnOa4oBt/
V/BuknZ+m8McCLySH8DuuY0XBvah+mWHMGoGY3qpoeqCo447axPSweIAAXs143t3
ujigchJGL1eaKtOvc/ZeOr2jSwPqmiqIeMN+g7S/mHe7GIW+l6fzH0ZfYm+EADCa
8yJmtZhhwRtSB5j0QsDDEquWlykluoN+jkB2ysTkb3ATY1S+K1ICVZpVMtZ6jCZr
PK68KmxnUFaGXdwKAMpDtDi50roDis7kafjRuIT+rSiTsTkR/uEJ7G4AZs7ca0xz
PfGS7dnXprXm+y/2pQuVXNUzcsuaZxCXzHtjEuzaCEec4qMq4a9QYRrHCLH5xQHE
LxkEvQ2TElGKTzFiOi2daRAreLUv5iQ6U9Y9taiL8AMsKaIjmDUdOmBAUFPhFHDX
ixcgudSFeAbYp0bGwjpqdvXkftitKiGESCAvgEDl+MIhIIK/4jI=
=4r6M
-----END PGP SIGNATURE-----

--nextPart13450391.uLZWGnKmhe--