Received-SPF: pass (google.com: domain of linux-kernel+bounces-61449-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <73cdc81b-f58f-4eb5-b6ad-3011768781bd@quicinc.com>
Date: Mon, 12 Feb 2024 19:45:00 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8650: Add dma-coherent property
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>
CC: <quic_kuiw@quicinc.com>, <quic_ekangupt@quicinc.com>, <kernel@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        "Aiqun Yu
 (Maria)" <quic_aiquny@quicinc.com>,
        Neil Armstrong
	<neil.armstrong@linaro.org>
References: <20240125102413.3016-1-quic_lxu5@quicinc.com>
 <20240125102413.3016-3-quic_lxu5@quicinc.com>
 <069b82ac-b59c-4665-8a77-6c11a2463faa@linaro.org>
 <690e64d6-8888-4f99-9ee0-c731aeea7762@linaro.org>
 <7edfed88-d84f-41e1-8c10-4af6efe53c4c@quicinc.com>
 <ed9bf914-8b3e-401e-93c0-77eae97e2ab8@linaro.org>
From: Ling Xu <quic_lxu5@quicinc.com>
In-Reply-To: <ed9bf914-8b3e-401e-93c0-77eae97e2ab8@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

在 2024/2/12 19:41, Krzysztof Kozlowski 写道:
> On 12/02/2024 12:31, Ling Xu wrote:
>> 在 2024/2/12 19:10, Krzysztof Kozlowski 写道:
>>> On 12/02/2024 12:00, Krzysztof Kozlowski wrote:
>>>> On 25/01/2024 11:24, Ling Xu wrote:
>>>>> Add dma-coherent property to fastRPC context bank nodes to pass dma
>>>>> sequence test in fastrpc sanity test, ensure that data integrity is
>>>>> maintained during DMA operations.
>>>>>
>>>>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
>>>>> ---
>>>>>  arch/arm64/boot/dts/qcom/sm8650.dtsi | 13 +++++++++++++
>>>>
>>>> This wasn't ever tested:
>>>>
>>>> sm8650-qrd.dtb: remoteproc@32300000: glink-edge:fastrpc:compute-cb@1:
>>>> 'dma-coherent' does not match any of the regexes: 'pinctrl-[0-9]+'
>>>>
>>>> Ling,
>>>> How is this testing-patches-before-sending work in different teams? Do
>>>> you have such requirement?
>>>
>>> No clue if the original DTS change should be reverted or these are in
>>> fact DMA coherent, but let's choose one path...
>>>
>>> https://lore.kernel.org/linux-devicetree/254c1d14-25e3-4f4c-9e79-4ef7cec4d22f@linaro.org/T/#t
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> Hi Krzysztof,
>> Add dma-coherent: true in this file: Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml at line number 89 can pass the DTcheck.
> 
> I don't understand your comment. Did you read the link above?
> 
> Anyway, I was asking: are you testing the patches before sending?
> 
> Best regards,
> Krzysztof
> 
Yes, I tested before sending.
-- 
Thx and BRs,
Ling Xu