Date: Sat, 22 Dec 2007 16:25:16 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-kernel Mailing List <linux-kernel@vger.kernel.org>,
       Michael Halcrow <mhalcrow@us.ibm.com>, mike@halcrow.us,
       Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH] (UPDATED) ecryptfs: check for existing key_tfm at mount
 time
Message-Id: <20071222162516.df6fe557.akpm@linux-foundation.org>
In-Reply-To: <476D4C8D.9080602@redhat.com>
References: <476B4CB9.9070700@redhat.com>
	<20071221205618.d04bea09.akpm@linux-foundation.org>
	<476D4C8D.9080602@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 696
Lines: 18

On Sat, 22 Dec 2007 11:42:37 -0600 Eric Sandeen <sandeen@redhat.com> wrote:

> Andrew Morton wrote:
> 
> > It would all look a lot more solid if this locking was retained and both
> > ecryptfs_tfm_exists() and ecryptfs_add_new_key_tfm() were designed to be
> > called under key_tfm_list_mutex.
> 
> Hmm good point, sorry for missing that.  How's this look?

key_tfm_list_mutex gets used in fs/ecryptfs/main.c but it is static in
fs/ecryptfs/crypto.c

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/