Received-SPF: pass (google.com: domain of linux-kernel+bounces-61519-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 12 Feb 2024 13:07:02 +0100
From: Christian Brauner <brauner@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: NeilBrown <neilb@suse.de>, Jeff Layton <jlayton@kernel.org>, 
	Arnd Bergmann <arnd@arndb.de>, Luca Vizzarro <Luca.Vizzarro@arm.com>, 
	Tom Talpey <tom@talpey.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] filelock: ignore 'lock' argument to for_each_file_lock()
Message-ID: <20240212-packpapier-messstation-c5a0c081a0c7@brauner>
References: <20240212112620.1272058-1-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240212112620.1272058-1-arnd@kernel.org>

On Mon, Feb 12, 2024 at 12:26:11PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> When CONFIG_FILE_LOCKING is disabled, ceph causes a warning about
> a variable that is only used insode of the for_each_file_lock()
> loop:
> 
> fs/ceph/locks.c: In function 'ceph_count_locks':
> fs/ceph/locks.c:380:27: error: unused variable 'lock' [-Werror=unused-variable]
>   380 |         struct file_lock *lock;
> 
> Rather than working around this in ceph, change the macro definition
> to still contain a reference to the variable in order to shut up the
> warning.
> 
> Fixes: 75cabec0111b ("filelock: add some new helper functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Yup, seems good to me.