Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2438691rdb; Mon, 12 Feb 2024 05:09:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IHGXkPkD+iGGkV9DMRYQgdYM/Fm1IIRevi+GJvNvPMZ7CvU9WFQf/0kKp1Cu4sZmyqk9t3S X-Received: by 2002:a17:906:d293:b0:a3c:10a4:7a91 with SMTP id ay19-20020a170906d29300b00a3c10a47a91mr5352909ejb.13.1707743370626; Mon, 12 Feb 2024 05:09:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707743370; cv=pass; d=google.com; s=arc-20160816; b=q4XtzMQjAcM3HT7DNDtiiZIzDvewZRVAnYLBW8+wxT0GisHkIOfBfwQkIjW7GuZUkm XnsfIOxWLTc0oxXxWH/XeTpT3v0DcB++phjOmjA+xRaxU7pSd0FZmamEourUE9q29XRj 7wJdUyoOSSG6OZItMiD/U/CJe4oRCNHBiW9OUb9UWuKsmJu+OlMKVBQlcW9OH+luVFjg hk+eMyKHt9UCT34vh6tdi7Wms+vCzfcFiAQXSlmxFne2M75TJBNpiKErFWGWJJTvWvLv UndYAwqWthdaO/IqbWWRH3PcNL+iDq2rNfn+qcWZGkd7Hami4WkfTjzZRC3+8lgmz0AM YU8w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=gQx+LiMAM/c0foWRq6VR5uxmlCN3VUOeX2bUv5xHFdk=; fh=CeddOx57637PAstTFW1rNHAeDol4zQ8tOI5TeqQoz18=; b=RfaKJVHArXBTgfhbLfBzaz2pgt07rXHL6JiY7WuYVf55Tw9ApMK0OFLpy8i2x/RKZ1 8URhQwxeNEDZicuICXk1Am6FLa7rLT4L0kedPfxCZWB2VVzdzk6jOWMWKk5cwGsXJOQm 5pwQAe3C4sRUGHLf1u0XnFcg9/hfNCy463Op/ZBFd1XDGtAXtOyur+TJIjeTIW6aLMk9 EerDAHcB3oJ7P4bKuaLjb3rplQvOOAzpRSzZTvWEsmM1LDOTFKADqmrSfLWo6Midit9s QAt+uX19KCU+hSKG+07GktBOBVvTmGEM3BK73FRDeIahg9QeCRa0FpXZuT2JASBGxbvt PG1A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RS06yfiY; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-61603-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61603-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCVvIak14djHUVIEuLmUij1X2Qr16X16wvmJz9x2xHHfEgAo2AcBuBz1KihLdiQC7kIvR7RN2Y5rkJ/VzDWjBAlmZ/ouuuYugf0f12NoGQ== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id xo19-20020a170907bb9300b00a3ccf19f6c4si182799ejc.472.2024.02.12.05.09.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 05:09:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-61603-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RS06yfiY; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-61603-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61603-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3FEB81F2165A for ; Mon, 12 Feb 2024 13:09:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2ECEE3A1B8; Mon, 12 Feb 2024 13:09:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RS06yfiY" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56C503A8C3 for ; Mon, 12 Feb 2024 13:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707743365; cv=none; b=rhx4nzO+vPfZ2z1RDTcf85okz/Di1vwsJdZuHNXoklSfC1xUOq9d/AzwYPcZ+sU/x2vSCCAyScfd/GdvC7lhoiJDWkPp+1s46DNVjEq2n+gvHeIHBHPzyl6zKV0gKr4jmCaQyVQChdSldNEIDLeiMvcyRogcCQGNnsnhE95/b6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707743365; c=relaxed/simple; bh=ZFSAXopDMZCjTdY1fpM24iNylF7FaL1HTB5ZZDomxNQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f6yn3eWRLCVl/WYnsisHaq1Da/TTHIoT7dDKujhttlB1Cj78WxNZ89rZslaP0xgF1xhCyjDrvqguBAwwtFDINkhKoJZl3WCqRedmpfiXvWduoXtpwZKjGugGR0g484VL5qXSCH7b7lA/mXeTFpH2YjWg8yA6+163rxeMzAHM9HQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RS06yfiY; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53FF8C433F1; Mon, 12 Feb 2024 13:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707743364; bh=ZFSAXopDMZCjTdY1fpM24iNylF7FaL1HTB5ZZDomxNQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RS06yfiYLA34+Q0JfqmqTs3avQfnhukBM9eJp0xzhNEYh/5m7/2ze+OWWO8JW/9Wv NGz78mqefrRGea7knKfGZEWP+Pl6l8qW6eRSulJbpbCHMNxB3rGLL1I/cSYG2gzrJz JtVmJpb0qfVdVd0SJ8Cpka1BXfofdmHwTCZYxBOeJVBTihguUoiht5EwRiIIuPqYK9 gkSA5OENh5lL5dmpVP2u2VPvoiYU3xIpE5V4EuxNzbYA+BcLqL7FAbtz3A4cCPWsBc uGFU7NS0xtfO7h+DRMxUk64UE3hJoo42KSWQWmxHRNz0bxhSyb9GNREFKlpZ2K9duY beshAT02c0Shg== From: Christian Brauner To: Jeff Layton Cc: Christian Brauner , Arnd Bergmann , Tom Talpey , Luca Vizzarro , Chuck Lever , Alexander Aring , linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] filelock: always define for_each_file_lock() Date: Mon, 12 Feb 2024 14:09:06 +0100 Message-ID: <20240212-seicht-ruhig-d577ffd40f50@brauner> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240212-flsplit3-v1-1-019f0ad6bf69@kernel.org> References: <20240212-flsplit3-v1-1-019f0ad6bf69@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1184; i=brauner@kernel.org; h=from:subject:message-id; bh=ZFSAXopDMZCjTdY1fpM24iNylF7FaL1HTB5ZZDomxNQ=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaSekqhO8Q5/+1M6yCZ/5wb+/4fVFBWzjK5wm/224GUyu xU88e3HjlIWBjEuBlkxRRaHdpNwueU8FZuNMjVg5rAygQxh4OIUgIkEezL8s9+h8Gmj14Ut99NY q45FilxNf1KkqJB/LpxR4qj6tIYDNgz/tH9c8PmUblq1IUJQ0iF+zd7Vas6h9/LS732pfNJv8sq LFQA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit On Mon, 12 Feb 2024 07:24:05 -0500, Jeff Layton wrote: > ...and eliminate the stub version when CONFIG_FILE_LOCKING is disabled. > This silences the following warning that crept in recently: > > fs/ceph/locks.c: In function 'ceph_count_locks': > fs/ceph/locks.c:380:27: error: unused variable 'lock' [-Werror=unused-variable] > 380 | struct file_lock *lock; > > [...] Thanks Jeff and thanks Arnd! --- Applied to the vfs.file branch of the vfs/vfs.git tree. Patches in the vfs.file branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.file [1/1] filelock: always define for_each_file_lock() https://git.kernel.org/vfs/vfs/c/582a3bf999df