Received-SPF: pass (google.com: domain of linux-kernel+bounces-61696-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240129212350.33370-1-wsa+renesas@sang-engineering.com> <20240129212350.33370-2-wsa+renesas@sang-engineering.com>
In-Reply-To: <20240129212350.33370-2-wsa+renesas@sang-engineering.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 12 Feb 2024 14:29:46 +0100
Message-ID: <CAMuHMdXuWHCLa8HFXBZK4M4fqivudxjHcqqUyZ2=a3=OfFLPYQ@mail.gmail.com>
Subject: Re: [RFC PATCH 1/2] arm64: dts: renesas: ulcb-kf: adapt 1.8V HDMI
 regulator to schematics
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>, 
	Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Wolfram,

Thanks for your patch!

On Mon, Jan 29, 2024 at 10:23=E2=80=AFPM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> It is named T1.8V in the schematics. Also add properties dcoumenting it

documenting

> is always on, also during boot.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -32,11 +32,13 @@ hdmi1_con: endpoint {
>                 };
>         };
>
> -       hdmi_1v8: regulator-hdmi-1v8 {
> +       t1v8: regulator-t1v8 {

"t1p8v"?
Or "reg_t1p8v", as the former is a rather short name, causing conflicts?

>                 compatible =3D "regulator-fixed";
> -               regulator-name =3D "hdmi-1v8";
> +               regulator-name =3D "t1v8";
>                 regulator-min-microvolt =3D <1800000>;
>                 regulator-max-microvolt =3D <1800000>;
> +               regulator-boot-on;
> +               regulator-always-on;
>         };
>
>         pcie_1v5: regulator-pcie-1v5 {
> @@ -154,11 +156,11 @@ hdmi@3d {
>
>                                 pd-gpios =3D <&gpio_exp_75 5 GPIO_ACTIVE_=
LOW>;
>
> -                               avdd-supply =3D <&hdmi_1v8>;
> -                               dvdd-supply =3D <&hdmi_1v8>;
> -                               pvdd-supply =3D <&hdmi_1v8>;
> +                               avdd-supply =3D <&t1v8>;
> +                               dvdd-supply =3D <&t1v8>;
> +                               pvdd-supply =3D <&t1v8>;
>                                 dvdd-3v-supply =3D <&reg_3p3v>;
> -                               bgvdd-supply =3D <&hdmi_1v8>;
> +                               bgvdd-supply =3D <&t1v8>;
>
>                                 adi,input-depth =3D <8>;
>                                 adi,input-colorspace =3D "rgb";

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds