Received-SPF: pass (google.com: domain of linux-kernel+bounces-61703-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 12 Feb 2024 13:35:12 +0000
From: Mark Brown <broonie@kernel.org>
To: Dhruva Gole <d-gole@ti.com>
Cc: =?iso-8859-1?Q?Th=E9o?= Lebrun <theo.lebrun@bootlin.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Tawfik Bayouk <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH] spi: spi-mem: add statistics support to ->exec_op() calls
Message-ID: <5c1a5edd-adfd-44f2-a993-bc3f43222a3a@sirena.org.uk>
References: <20240209-spi-mem-stats-v1-1-dd1a422fc015@bootlin.com>
 <20240212111355.gle4titwolqtzwpi@dhruva>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="qfEan8YTTsWnxYla"
Content-Disposition: inline
In-Reply-To: <20240212111355.gle4titwolqtzwpi@dhruva>


--qfEan8YTTsWnxYla
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 12, 2024 at 04:43:55PM +0530, Dhruva Gole wrote:
> On Feb 09, 2024 at 14:51:23 +0100, Th=E9o Lebrun wrote:

> > +	/*
> > +	 * We do not have the concept of messages or transfers. Let's consider
> > +	 * that one operation is equivalent to one message and one transfer.

> Why 1 message _and_ 1 xfer and not simply 1 xfer?
> Even in the example of testing that you showed above the values for
> message and xfer are anyway going to be same, then why have these 2
> members in the first place? Can we not do away with one of these?

If the device supports regular SPI operations as well as spi-mem
operations then this will ensure that the spi-mem stats fit in with the
other operations.  If it only supports spi-mem operations it would not
matter so much.

--qfEan8YTTsWnxYla
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXKHpAACgkQJNaLcl1U
h9ApIAf8CFpmSqm+vuO7RrlK573k/K80dAGpyOYDvb4SkGCshATMJ3VLM50ZvVR5
BXdev13tBegdvN5gg+i9FeFLYGyBVJDpCsNedg/1aXvSrofa4n97zB4p3E/s+ndv
egC/u9kawfrOJ5k7PEr7pVmlP2ZaajCvuSTq/huoD8zePvEWUOgaqTehpmxqhNVa
g/oxTEBTv0biZHC6z8PMrffb6ugnVf2ppSlfYL8GF8ceoONUMHvmL+yPq0H83u+a
3bXyC65cZOs+Xa5GextzRqeTHt0uk1V0tXisJSNkIxU+gRsZDvI1e6ZfBlTTWE5+
5hFP8z4lVCFXvdaNAjcryp1E7xKOgw==
=nLML
-----END PGP SIGNATURE-----

--qfEan8YTTsWnxYla--