Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2470893rdb; Mon, 12 Feb 2024 06:08:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXz5c3tCNyBbLLu3ZnT021lEUfkYhgNg71VHxzynU7avpcW+UH3f1hPYcYQQEuuvrNZfQixa1DQO2q0vHwEI0Ik8WdfQ7WKsIDIDztFKQ== X-Google-Smtp-Source: AGHT+IHPptLBQnE4XwDihVLiz0tuJLs+dQ4wsYVwDPW59Y/H1g1dFpWstme4oV1NAtihPXL+krhq X-Received: by 2002:a05:620a:5687:b0:785:4726:c803 with SMTP id wg7-20020a05620a568700b007854726c803mr7253856qkn.1.1707746914494; Mon, 12 Feb 2024 06:08:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707746914; cv=pass; d=google.com; s=arc-20160816; b=ZcO1AogjXNGdOfrKUl22IvQM6nVdF89jTPY2+NzpL6fK3r/ODrwA9jShoyl16De11O djZdfMGv9ycTZFp2ErJMUGVSAo/QEcqQeRkFtx1/OZEY4+OeMirheMxRDPWsfrbxz51t VXcyTsd/f9JozhraX/3FWjpaE8sI6lTwKIYRo8eGGwS38xpVd3QrmNCKyMzoDDHUmB3x KTYH8BJQzUVNVNHxDUuqJCK3KnHnrR/HIKqLAg5bj3uROTxEabo636vdBeJyzHGV8Boa CMaR0udJGf7sqnDCuyH9rRbGHT58Tq0+Z87KcbVH20V5VRPp5CA1funylHFcnmkPVDqM NqvQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=3fwygQHFsBzQHW5VKr94J8/MYzLiHXjL2S+HWa6z3Po=; fh=ltwoVcTZ2byDnMKHTTgYgb7NQbWoPeFgEnfwMR0qnPM=; b=aVCZThKj5Kb62S7A+DaiajfFsPZyf8iJB0w9ci034QP/cAdvC7xJ392KsGGFY7U0kJ j9uhCy3WJsz0GnZ0OxhC9VCTai3fNyx1BeFdPxjt4JZX5RQyrVIttDGrfbkEflPKz1TY ud35kikL6ifQoPW1LIhlq2DIbdLuYrHjMvwYkxVMpo4fe1eniSyF/1O14zcPiIFPc+ao u24XNlpcPjHNBKDNwo38Qdx8VxlxySMlyARN+K710sLb07h6t0ODTDgFm7hqrcHiscSK iKQ+b1MHhM3SDHNg8jlGpPRipfEQBHvPSAQY7yLH6S1J+S4hQnUuSoHDWxyoL/pSAeZr mPTA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="WSa0/Y2x"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-61786-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61786-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=2; AJvYcCVHBDi6r23qd4ffIgOlgdD7E6ZAB7iP/l6Rzjjbs0oxaDRjWZdM99kFDeX78pB0jC4vEMd0nvJtDw5Ts0+my0qbDyPSMkpPlQZdaL6aUg== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id o8-20020a05620a228800b0078351e1950esi5734100qkh.420.2024.02.12.06.08.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 06:08:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-61786-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="WSa0/Y2x"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-61786-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61786-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 348461C23864 for ; Mon, 12 Feb 2024 14:08:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1104D3D0B8; Mon, 12 Feb 2024 14:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WSa0/Y2x" Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 807873D0B5 for ; Mon, 12 Feb 2024 14:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707746622; cv=none; b=ZLx+U7j0El+zzq7h6Cg7yGg8CEZH+W/ZagK3nCfYLwY8IhwzTfgA/gSWGehy7p+yJaCt9d0G7aJWPWJo4Q/M0LEJwZkuZB3xkbAQ8O1a38bZAXcKFMl5gt1cOL2WMuWD/SPbWT4i/yAWtmGy5gs+s2QLWjnufgj61LizaugB1jA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707746622; c=relaxed/simple; bh=6tebE1i+8uRkrGpkVZOD3OOkqyqqHXPKa5dm8fJa6M0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lXajdFyEY8BHMlKtrxYRBOdLQ3C5DaaZcefA53QAJHM2QSQQXyEi8dD242WssIzecAxFimcdAhI5lw46N1c50a8Ndih2y32XaxVycKDFCkxocTyKGsKyV0UqRMWvsebBYUikQqwt16WCoB82NCiW8zH52R+XM9hv7P7TzlylxCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WSa0/Y2x; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4114e0a2978so2953075e9.3 for ; Mon, 12 Feb 2024 06:03:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707746618; x=1708351418; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3fwygQHFsBzQHW5VKr94J8/MYzLiHXjL2S+HWa6z3Po=; b=WSa0/Y2xruKgwRhYkos26f5TnMdopytcyGZ/2b+X46r6Cj4iGnC6XYt9Ef9bdzuc6Q j7UDZQKQXJxWsa4115fJrL/GBXqdJzEg6JRGq1TyipXHvbFmjnkKLCJ5m5yVJoyEb1Tp cz1HdlK0VQPYoGgEdS5EJtGQfuKwMOUIvG5Vnc09wsB5+BMb8p0WsS4hwcDFQ0MYuaoE FQr/f/LGOpqTiZRlQNoKyI3qs85Dqy0N6dCD1tkgvkVbkKtiAHJp87l5bJOkl3L/aixP DBo/4TUBJc0/k2Bn/dslunQ1SxkKvec0swzuQlIuRtqD9yyAa/RSBkuInAh+ljrvJhPM HW6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707746618; x=1708351418; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3fwygQHFsBzQHW5VKr94J8/MYzLiHXjL2S+HWa6z3Po=; b=htJmgRZcgwJwrKU14ev5CeI9EFJK3IF1IpC0+oJ8qxNbV1pX0zjvdt380g5PIdwWdo D1hxnfasuKVVgNzTvDef7oXRGfvE4suNMoQz33MWZk1Cf3AU0n+H4U7nrLEu+T6Cs1fH dasrECsV2ktNde3tj5NojgJr2hkqlsSWBnYbvBvoGuU/tMR8pTSMeLdhw+uaDWwkVFL7 l9JnBJa3lIaRowXSQ8Ih37WySqE+AWuUrAmcaxV/+DzErBrZml9H7DE62o26cSbCy+Fk xx5N6QYCZMm4FN3B/NdkoTwdbtMsiEWhSBMwnc2CqbGd7r1i/vgR0rNnNkhP2ostVmkG jsoA== X-Forwarded-Encrypted: i=1; AJvYcCWkFInIiQ3GO+rkhAeGOVPcyfW59sg0DuDn8B83w/GNRxQGi4ub95HJhXuAT+z1DrmWOqXJmwzqcuZsPmXp8AhlXxbtA3SrmjRvXE6A X-Gm-Message-State: AOJu0Yx4R1iZIPWFWaJAhn+PkKPwrAf+ha/6kdxBnlawwC06G7IpfMpp n/fAaBt8rRE+FyDxeh3WRtFG7HtxQeGtC5wbfwtRidNQJPUT9Ke0Ygav3IILwYc= X-Received: by 2002:a05:600c:470c:b0:411:6f3f:4950 with SMTP id v12-20020a05600c470c00b004116f3f4950mr661113wmo.32.1707746617687; Mon, 12 Feb 2024 06:03:37 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVdE45X2RafVhK2EB+ykUZM9RvsPvrceDujHA//0jL+xxiP+4n1I1kYEwYqurMODq5CHI+cESHCgB6fBwCHf9Xe22zXIx2Qp7f/YjU3mw8LTOD+1vj7bezY4XjEO/3zcENm4GqTW3M5CvhgMXi2jzkXChD/FxCupB7nqxUz2UJrXQ894bvh8F2cTIt65lcSMSVyaCrkdNQHSBj0maQ8PTDCMQhiTq9z7/kEIBba3MjC3wq2yDG2cGt+iUjz3oYUZ41m5M2zPFExn19FZe1ndbXtsVXM0miaZC/FNF5xb74Pvce3Jx5iD2XfkIocvW09knSlasadcXCVOllRvE0g+sp95i61XerBAXzF5ujl16KXolDWSLmQIkPAuoYnUcur2Hd99mN6/F4KMfLmZUBYSFidrpIF/TuzVyhDsCgSUqS0xc/eTw+0Feg1mV0kWGx5zQf0KW0KcDfdwYogWTmSPBIXsB9t/lCNYk28KW54EHhxKJrkZDT77HYOskEsNcJPwo9mLRbeBizP1ItF0+EynUm+c7Vau4Z0qk7sXwd/MeJ8T69ADyktROfI0c6uoFQWETNzeeYhs9bF7BLRi1ZfttHOMOngSAvkfRCz/eVue91GbMmKMmk= Received: from ta2.c.googlers.com.com (105.168.195.35.bc.googleusercontent.com. [35.195.168.105]) by smtp.gmail.com with ESMTPSA id v9-20020a5d4b09000000b0033b843786e1sm2135356wrq.51.2024.02.12.06.03.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 06:03:35 -0800 (PST) From: Tudor Ambarus To: broonie@kernel.org, robh@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, semen.protsenko@linaro.org, conor+dt@kernel.org Cc: alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, devicetree@vger.kernel.org, arnd@arndb.de, Tudor Ambarus Subject: [PATCH v2 00/12] spi: s3c64xx: remove OF alias ID dependency Date: Mon, 12 Feb 2024 14:03:19 +0000 Message-ID: <20240212140331.915498-1-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver was wrong as it assumed that the alias values in devicetree have a particular meaning in identifying instances. This immediately breaks when there is a dtb file that does not use the same alias values, e.g. because it only needs some of the SPI ports. Tested gs101 SPI with spi-loopback-test, all went fine. I updated exynos850 as it uses the same USI.SPI_VERSION as gs101. Maybe Sam can test exynos850, if not, we can drop that patch (12/12). v2: - update bindings to consider the asymmetric case where the RX FIFO depth can differ from the TX FIFO depth - update commit message in patch 11/12 to describe the GS101 change (I was wrongly mentioning exynos 850). Tudor Ambarus (12): spi: dt-bindings: introduce FIFO depth properties spi: s3c64xx: define a magic value spi: s3c64xx: allow full FIFO masks spi: s3c64xx: determine the fifo depth only once spi: s3c64xx: retrieve the FIFO depth from the device tree spi: s3c64xx: allow FIFO depth to be determined from the compatible spi: s3c64xx: let the SPI core determine the bus number spi: s3c64xx: introduce s3c64xx_spi_set_port_id() spi: s3c64xx: get rid of the OF alias ID dependency spi: s3c64xx: deprecate fifo_lvl_mask, rx_lvl_offset and port_id spi: s3c64xx: switch gs101 to new port config data spi: s3c64xx: switch exynos850 to new port config data .../bindings/spi/spi-controller.yaml | 27 ++++ drivers/spi/spi-s3c64xx.c | 142 ++++++++++++++---- 2 files changed, 138 insertions(+), 31 deletions(-) -- 2.43.0.687.g38aa6559b0-goog