Received-SPF: pass (google.com: domain of linux-kernel+bounces-61713-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240129212350.33370-1-wsa+renesas@sang-engineering.com> <20240129212350.33370-3-wsa+renesas@sang-engineering.com>
In-Reply-To: <20240129212350.33370-3-wsa+renesas@sang-engineering.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 12 Feb 2024 14:37:31 +0100
Message-ID: <CAMuHMdUkBMZkQuJ-+echU2JFKQ-KxQH6R-GUUokd_tz72TsWSw@mail.gmail.com>
Subject: Re: [RFC PATCH 2/2] arm64: dts: renesas: ulcb-kf: adapt sound 5v
 regulator to schematics
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>, 
	Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Wolfram,

Thanks for your patch!

On Mon, Jan 29, 2024 at 10:23=E2=80=AFPM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Sound uses the standard 5V supply, so rename the fixed regulator as
> such. Also add properties dcoumenting it is always on, also during boot.

documenting

> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Or shall we move the regulator to ulcb.dtsi? I tend to leave it here
> because 5V are not used on ULCB, but I am open to change it.

I think it's fine to keep it here, as the regulator (U59) that generates
5V from 12V is present on the Kingfisher board.  However, according
to the schematics, 5V is generated by the PMIC on the ULCB too, and
both 5V nets are connected through the board-to-board connectors?

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.9.

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds