Received-SPF: pass (google.com: domain of linux-kernel+bounces-61814-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1705965634.git.isaku.yamahata@intel.com> <591420ca62f0a9ac2478c2715181201c23f8acf0.1705965635.git.isaku.yamahata@intel.com>
In-Reply-To: <591420ca62f0a9ac2478c2715181201c23f8acf0.1705965635.git.isaku.yamahata@intel.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Mon, 12 Feb 2024 15:18:14 +0100
Message-ID: <CABgObfaEz8zmdqy4QatCKKqjugMxW+AsnLDAg6PN+BX1QyV01A@mail.gmail.com>
Subject: Re: [PATCH v18 032/121] KVM: x86/mmu: introduce config for PRIVATE
 KVM MMU
To: isaku.yamahata@intel.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	isaku.yamahata@gmail.com, erdemaktas@google.com, 
	Sean Christopherson <seanjc@google.com>, Sagi Shahar <sagis@google.com>, Kai Huang <kai.huang@intel.com>, 
	chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 23, 2024 at 12:55=E2=80=AFAM <isaku.yamahata@intel.com> wrote:
>
> From: Isaku Yamahata <isaku.yamahata@intel.com>
>
> To keep the case of non TDX intact, introduce a new config option for
> private KVM MMU support.  At the moment, this is synonym for
> CONFIG_INTEL_TDX_HOST && CONFIG_KVM_INTEL.  The config makes it clear
> that the config is only for x86 KVM MMU.

Better, just put this as:

config KVM_MMU_PRIVATE
    bool

but also add a reverse dependency to KVM_INTEL:

config KVM_INTEL
     tristate "KVM for Intel (and compatible) processors support"
     depends on KVM && IA32_FEAT_CTL
     select KVM_MMU_PRIVATE if INTEL_TDX_HOST
     ...

This matches the usage of kvm-intel-$(INTEL_TDX_HOST) in the Makefile.

Paolo

> Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
> ---
>  arch/x86/kvm/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index cd3de7b9a665..fa00abb9ab39 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -189,4 +189,8 @@ config KVM_MAX_NR_VCPUS
>           the memory footprint of each KVM guest, regardless of how many =
vCPUs are
>           created for a given VM.
>
> +config KVM_MMU_PRIVATE
> +       def_bool y
> +       depends on INTEL_TDX_HOST && KVM_INTEL
> +
>  endif # VIRTUALIZATION
> --
> 2.25.1
>