Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2489640rdb; Mon, 12 Feb 2024 06:39:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWqr4jIAdOUr2oTimBRcjooOqkxnRv8PABR7OYzed2HmWhZ3dgOS0NClPHSQWnDdIwZZwYqvM3nIDr3BDndproCG4cfthD8Bl6Ks1WRkQ== X-Google-Smtp-Source: AGHT+IHEy8KxpH00w8tbYLn9ZTzRhLirsJNv2Hk1AmkxVpH4G7tIZih9tUUBnT6IKs9hitR9I3mt X-Received: by 2002:a2e:2c05:0:b0:2d0:8f01:f4d8 with SMTP id s5-20020a2e2c05000000b002d08f01f4d8mr4516648ljs.18.1707748756943; Mon, 12 Feb 2024 06:39:16 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707748756; cv=pass; d=google.com; s=arc-20160816; b=fjdxcAvz7dnrsJP+pKIa8SAZqVIUUjR6x/EpGMKiwaJeap7uDawKuVr/87z2msUZgJ wmAAlIxrtPgXGibWy5sPvwD+Myper/L8EvM1Z9v94S/aEi+F5lZvvrieDqvrJGOB7Fpy 7b3TVxQ3EOugGUj7DNPgrdKj8MF9VS34AS/QYZX1+/Gai2J0Mxj1UOTH7uCBwcPOpydv tu7n7VD/eF95qLlT0j7p1TyAceS+ol+vRrAxPVC5CzdjvoBBtSUWmNWJVCjRGzr9Z3YO Xb9uMbvyLuEkYzuC0N/RF5URchasVze8e3iUasnPLOSPTx6poQ59wal5pPA1jonhfF54 r+Aw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:autocrypt:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Y+gbeoJv3wGJ+0epN3kfaDD6Jx00JkVHjH8YrcFZjjU=; fh=IW/qslwrxPgFlLPF5eW/pzme6nRvz6lCLwaXh7WYlyo=; b=gwAew4+bRMOYMAMhiYXNEp76mXNHCEl5x4ZQ5boh4KpQlT4dkKJQiRIRA7gykEnN9B 0/wFborIz5yu2vXBig/ZNgN5W4Mt77S22VFzSWNcHUvupPgp/8AMMexPew5jdY4JJK2z H1f2prh7HIb7u2OVmV1CNp41V33DAFOu6HN4qhEjiWkscd8Fm300ptZrRjeYslr2DFZI aLp0/lOcN7jmIVnceKa8od607bEXi6+wHbsftBpQgO5O7N7DD0t/PHLh6dvokhHfAWnP iidhokRva+c/OBLZGgBaY5MRVUIakSxZJahAXy1SfxITIz9hUKlhAMA4ktaAhQLc8ZC6 IC+Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=skole.hr); spf=pass (google.com: domain of linux-kernel+bounces-61831-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61831-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCWRY+eyEwYlK/3UUU8VEBflF/BJH4CBIMCFp5LYjBaFiHvGfhHD41B7bKb3naNH7Zxsv+uJ+1PRkRhwUVbQWrKlI7vFigth7ajhYZTvGQ== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id u13-20020a50eacd000000b00561a837743csi1216429edp.12.2024.02.12.06.39.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 06:39:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-61831-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=skole.hr); spf=pass (google.com: domain of linux-kernel+bounces-61831-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61831-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5E10A1F221ED for ; Mon, 12 Feb 2024 14:39:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C3ACA3B2A1; Mon, 12 Feb 2024 14:39:10 +0000 (UTC) Received: from mx.skole.hr (mx2.hosting.skole.hr [161.53.165.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53FEA3AC14; Mon, 12 Feb 2024 14:39:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=161.53.165.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707748750; cv=none; b=qJcDgDat0A8VtOzntVOuQjEW8QI6T0QrOkU8AkTq5XlBpCQpIZo5mCKCkjDHc5eWuc6IAw27gH9jEBiizpm6X50tzWwDKAZxVBHO5oIn+EIik2ICE8iMI5eeJULcv7jhYkFWeSOyY9dslemyLK7OZh8zu3fQUnxMYcXGENnH90g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707748750; c=relaxed/simple; bh=bhdRHyoW7lPVIkTI8IjDK4sPL6Ctj/nSJiAUABT6vdc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Rh5ps9diC055XoLKLTDU+OFFuuBRYvIDEsblB285BRF9liqRz7RAP9YYcBHBXSJKSR69jqR46Zx6M1zKMKYKcqLTg5g2egxR7grLgHcd8UyHe2O+ohODCfNlyC+0mA89p90VZep5GmOoat8vWZ9bnGlGFNqwvI2BWA03j30+TGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=skole.hr; spf=pass smtp.mailfrom=skole.hr; arc=none smtp.client-ip=161.53.165.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=skole.hr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=skole.hr Received: from mx2.hosting.skole.hr (localhost.localdomain [127.0.0.1]) by mx.skole.hr (mx.skole.hr) with ESMTP id 2BAEB84EA7; Mon, 12 Feb 2024 15:32:42 +0100 (CET) From: Duje =?utf-8?B?TWloYW5vdmnEhw==?= To: Arnd Bergmann , Daniel Thompson Cc: Lee Jones , Jingoo Han , Helge Deller , Linus Walleij , Arnd Bergmann , Flavio Suligoi , Hans de Goede , Jianhua Lu , "Matthew Wilcox (Oracle)" , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] backlight: ktd2801: fix LED dependency Date: Mon, 12 Feb 2024 15:31:50 +0100 Message-ID: <4869921.GXAFRqVoOG@radijator> In-Reply-To: <20240212124428.GB4593@aspen.lan> References: <20240212111819.936815-1-arnd@kernel.org> <20240212124428.GB4593@aspen.lan> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Autocrypt: addr=duje.mihanovic@skole.hr; keydata= mQINBGBhuA8BEACtpIbYNfUtQkpVqgHMPlcQR/vZhB7VUh5S32uSyerG28gUxFs2be//GOhSHv+ DilYp3N3pnTdu1NPGD/D1bzxpSuCz6lylansMzpP21Idn3ydqFydDTduQlvY6nqR2p5hndQg6II pmVvNZXLyP2B3EE1ypdLIm6dJJIZzLm6uJywAePCyncRDJY0J7mn7q8Nwzd6LG74D8+6+fKptFS QYI8Ira7rLtGZHsbfO9MLQI/dSL6xe8ZTnEMjQMAmFvsd2M2rAm8YIV57h/B8oP5V0U4/CkHVho m+a2p0nGRmyDeluQ3rQmX1/m6M5W0yBnEcz5yWgVV63zoZp9EJu3NcZWs22LD6SQjTV1X8Eo999 LtviIj2rIeCliozdsHwv3lN0BzTg9ST9klnDgY0eYeSY1lstwCXrApZCSBKnz98nX9CuuZeGx0b PHelxzHW/+VtWu1IH5679wcZ7J/kQYUxhhk+cIpadRiRaXgZffxd3Fkv4sJ8gP0mTU8g6UEresg lm9kZKYIeKpaKreM7f/WadUbtpkxby8Tl1qp24jS1XcFTdnjTo3YB2i2Rm9mAL2Bun9rNSwvDjE fjMt5D5I+CIpIshaQwAXwRTBJHHAfeEt62C1FQRQEMAksp4Kk1s2UpZkekZzNn48BnwWq75+kEj tuOtJIQGWTEHBgMG9dBO6OwARAQABtClEdWplIE1paGFub3ZpxIcgPGR1amUubWloYW5vdmljQH Nrb2xlLmhyPokCTgQTAQgAOAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBFPfnU2cP+EQ+ zYteJoRnrBCLZbhBQJg01LLAAoJEJoRnrBCLZbhMwoQAJBNKdxLxUBUYjLR3dEePkIXmY27++cI DHGmoSSTu5BWqlw9rKyDK8dGxTOdc9Pd4968hskWhLSwmb8vTgNPRf1qOg2PROdeXG34pYc2DEC 0qfzs19jGE+fGE4QnvPCHBe5fkT2FPCBmNShxZc1YSkhHjpTIKHPAtX1/eIYveNK2AS/jpl23Uh hG9wsR2+tlySPNjAtYOnXxWDIUex8Vsj2a2PBXNVS3bRDeKmtSHuYo7JrQZdDc0IJiRm0BiLEOI ehTtcYqYr1Ztw7VNN2Mop/JG2nlxXNaQmyaV6kF/tuaqn1DJQcb0OxjAXEUMaICYJOwS9HSt26n uwo8dUiUPLQTih/wm6tyu2xrgMwqVT5jiKIssSS+7QNTsmldubRSYjFT49vwkVoUQ6Z3UO6BVdd f3OG4meE0S5uQc7Moebq67ILxfQ8XsDvdvEliVuHh89GAlQOttTpc6lNk8gCWQ+LFLvS66/6LFz mK1X4zC7K/V6B2xlP4ZIa3IC9QIGuQaRsVBbbiGB3CNgh0Sabsfs4cDJ7zzG1jE7Y4R9uYvdSFj Liq5SFlaswQ+LRl9sgzukEBTmNjdDVhufMY2jxtcMtck978E1W1zrg94iVl5E0HQZcpFHCZjRZX Fa42yPsvVkFwy4IEht9UJacMW9Hkq5BFHsdToWmg7RY8Mh04rszTiQJUBBMBCAA+AhsDBQsJCAc CBhUKCQgLAgQWAgMBAh4BAheAFiEEU9+dTZw/4RD7Ni14mhGesEItluEFAmCVBxAFCQXW6YEACg kQmhGesEItluFXIg//QnqY5RrQ1pLw2J51UwFec4hFMFJ6MixI9/YgizsRd2QLM7Cyi+ljkaHFQ mO4O5p0RsbF/2cc4u1D+MhQJGl6Ch6bdHoiWFrNUexgBUmflr4ekpI+GIFzikl6JTYHcRfkjobj 0Tmr8zWoxzcdFhrzGn5/6AH3GxudpUr6WQD5iDSe43T7ZcY8zHfD+9zcsZ2LHhRhpHU0q+ERQw+ Rnh7C3urXlrAlFzuKuPh2tHT76glRaledJ8cK34vHNi73TYpsFy4tfhAPhHwBogtjBf63jBOd/E S6wuYpKwcfNXo9EuEpJzJOitFwOvAra5AbCE+N/C/IOu2aFeOyu2SbHro06+Eyf/jy1A2t+LgLb E5cZu5ETyicfpN8L7m7wTTXTSx0NhETNWfgV95RUI6WIW5N4OCOVo8d/GOMVEYqMoDZndQin9B3 lDgojyagdzhXljP2BqavKdnPWbcKQ+JViR+e7EjLWVifgZkAvEhyirbTKYsgKkaRxoQP68U0bEy ukygDZRdzBmWaZPqBOzA5AH+OYiYVzzFqdBAHr2+z4mTN6W0td7CFDRAS2RzQApO3B1QH408Ke9 Oy69HwG+gdlfwloN6JTvgr5vQc8T6e3iC3Be/guLyW5UbLPxyFHimznVOizDYbZO1QSZMqk4G9I gA8e05P8dxEQJUsdZFtDdNPOYm5Ag0EYGG4DwEQAMD0bO0u9apmI1WOk41IdU1Hc76HLUA9jsiB ffA9yZ1OpnFEIAwSeUO8PFK7W5YPdRreNsUvMmBiLJid9y0tW5sACjSrH+amCQl0hJ3KlEkr+Vu Wga1a+Ye0qzg87bQae769RhwzEPvQvvNoTxTtvT5Alg2p3JSv5d/wC2Tu9IoFKkDAIoCFsvytuZ r2LuH3oK57oThhbEogYXR7YJ0JIwVg7nOQXnqpUTzxkh/73FKN6Bx01m37pB3wTe8w3w8r8WOip oRU+aPWhafDNFrdyBfSVOAw3fmX9yAfFfZo4w9OTdkrLLdK6SmX7mqiMstoZnvZIpLRk/L0ZNrJ 8fAVD+fEcpUiCoKwiiY0QFCWumMXITeD4zlo/Y6lQKhUp6EY0kcjG1D7n5sBR5oQcsC9PlH9a12 L+tNIfljayiEVobmkPwGf5p3sxOqeks6WWoB9+ZIk888kQdI/b7VA/86QvsTqubpJtr5uVNtyyj ZYTBHFnEGcA5+Rs2K/8TWFYDEBZiybfpCxrYT2RdTF7ef2wQZAiNZhzaEwxr7S4YTFuCwwqaKLt vckGv2fsFUy3qe28tw93oCNQxSqgOq6RD0HfblViXeioyP1nWVLAx6paS7d38TT6cz0HJCtOMFn S+UpJDv2x3gReCPBoqRx7LV4aYMyGy4pzwes+yO87hxULtw/ABEBAAGJAjYEGAEIACAWIQRT351 NnD/hEPs2LXiaEZ6wQi2W4QUCYGG4DwIbDAAKCRCaEZ6wQi2W4de4D/0aCxE4dTmO1xQ6BDXlKp DCegk8dIqrxK8Edbdq9/WGSO6Js0QfIL50IHAR739FbScT4+oSObeg0ap9kCGfW0AXGZaU82Ed1 5u+MzgksHE+t8cgULTKjqqt+PXq0yxZfLwI9itTa3zE2d6Uxd4Vzq77jjQuDL6o3zM6BQTJGYxx S6mELElcnMlo9lIZKzCAHaIkkMlMNBfvm8Q92aCuQ75xjWhis9K9lyV9cQZfu8AyP4zMGFk50Z5 tEF2UFylqKu+v8FZiezviwu9NsZegIY4DRaPWF5GWmFhYU4e9gBFG5xhEoIlO+etu1nSE1UJk+r mvJL20uKNUPnhXTJaQTzACpA1/2FqDnOUUx8qOYqmHMlFuy2qUh/QHShjc2AtngTFZrzAnGz6ni lRl32b7p8N+KaO4u2UGmGOwd/CuCzr2DxGomUSyCwOta7vOxator+NPK48roa417gBZ6ZFRplma ExicLFSnwBdGC3NnDa+yoRHKXHVSDfkb/FEhWuN/1tTZ96uxVYtHcln+snB2N6/hwmrOon2cHNu UeTLcrVyqI0Qz8JT4ksGxkxziO2L/e0O/xUp9mLAswixWt8+BMz/3sIJbdAPBVyt5QbHzWR6aID B5cQ1aQwZB8n7yt8B0sd/uIQItYu2urJ9gVAJkaEDms8+vbtOM4totXk5swwGxRg== Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Monday, February 12, 2024 1:44:28 PM CET Daniel Thompson wrote: > On Mon, Feb 12, 2024 at 12:18:12PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The new backlight driver unconditionally selects LEDS_EXPRESSWIRE, which > > is in a different subsystem that may be disabled here: > > > > WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE > > > > Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=y] > > Selected by [y]: > > - BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y] > > > > Change the select to depends, to ensure the indirect dependency is > > met as well even when LED support is disabled. > > > > Fixes: 66c76c1cd984 ("backlight: Add Kinetic KTD2801 backlight support") > > Signed-off-by: Arnd Bergmann > > --- > > > > drivers/video/backlight/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/video/backlight/Kconfig > > b/drivers/video/backlight/Kconfig index 230bca07b09d..f83f9ef037fc 100644 > > --- a/drivers/video/backlight/Kconfig > > +++ b/drivers/video/backlight/Kconfig > > @@ -185,7 +185,7 @@ config BACKLIGHT_KTD253 > > > > config BACKLIGHT_KTD2801 > > > > tristate "Backlight Driver for Kinetic KTD2801" > > > > - select LEDS_EXPRESSWIRE > > + depends on LEDS_EXPRESSWIRE > > As far as I can tell this resolves the warning by making it impossible > to enable BACKLIGHT_KTD2801 unless a largely unrelated driver > (LEDS_KTD2692) is also enabled! > > A better way to resolve this problem might be to eliminate the NEW_LEDS > dependency entirely: I believe this would be the best thing to do here. Making LEDS_EXPRESSWIRE user selectable doesn't make much sense to me as the library is rather low- level (a quick grep turns up BTREE as an example of something similar) and IMO the GPIOLIB dependency should be handled by LEDS_EXPRESSWIRE as it's the one actually using the GPIO interface (except maybe for KTD2692 as it has some extra GPIOs not present in the other one and thus handles them itself). Regards, -- Duje