Received-SPF: pass (google.com: domain of linux-kernel+bounces-61854-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 12 Feb 2024 16:00:36 +0100
From: Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To: "Jan Kratochvil (Azul)" <jkratochvil@azul.com>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-mm@kvack.org, containers@lists.osdl.org, Waiman Long <longman@redhat.com>
Subject: Re: [PATCH v2] Port hierarchical_{memory,swap}_limit cgroup1->cgroup2
Message-ID: <ked455hccs23ghrqug3ieqck6qmmlip5htgszjvz7n3cvhvaeo@7kkg6faezy2a>
References: <ZcmaPqZ9HzoN0GFM@host1.jankratochvil.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="udftjw4lcp7jj2yb"
Content-Disposition: inline
In-Reply-To: <ZcmaPqZ9HzoN0GFM@host1.jankratochvil.net>


--udftjw4lcp7jj2yb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello.

Something like this would come quite handy.

On Mon, Feb 12, 2024 at 12:10:38PM +0800, "Jan Kratochvil (Azul)" <jkratoch=
vil@azul.com> wrote:
> which are useful for userland to easily and performance-wise find out the
> effective cgroup limits being applied.

And the only way to figure out inside cgroupns.

> But for cgroup2 it has been missing so far, this is just a copy-paste of =
the
> cgroup1 code while changing s/memsw/swap/ as that is what cgroup1 vs. cgr=
oup2
> tracks. I have added it to the end of "memory.stat" to prevent possible
> compatibility problems with existing code parsing that file.

I was thinking of memory.max.effective (and others).

- no need to (possibly flush) stats when reading memory.stat
- can be generalized also for pids controller (and other "limiting" control=
lers)=20
- analogous to precedent of cpuset.cpus.effective

Whereas, using v1 approach in v2:
- memory.stat mixes true stats and limits,
- memmory.stat is hierarchical by default, no need for the prefix.

What do you think of the separate .effective file(s)?

Thanks
Michal

--udftjw4lcp7jj2yb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZcoykQAKCRAGvrMr/1gc
jrcRAQCmHQ3zahZOyBX4mYSsgAGeyZnpqwR6DtFU4iC+td8H0gD8CMLymLYdXAGC
I89BNel0pL7qDQzxSuSAVFvoyZhlRws=
=v9Sh
-----END PGP SIGNATURE-----

--udftjw4lcp7jj2yb--