Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2506510rdb; Mon, 12 Feb 2024 07:07:40 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW2xlskhouIsJzHPeKd12DojDE+PP1r6vvlpXohUzZzCj7kn2I6QikRfC+JGFFAcMCpha8CSG6CB27nTj2x/YiD6qGqgdMzbH17NO65pQ== X-Google-Smtp-Source: AGHT+IER4MGLR3tDHVvSVGsKjz9c2XxWrrGOI8V54DUcakVe0HD6WPT5evw70j1xg7/yPQM1gRGC X-Received: by 2002:a05:620a:1471:b0:785:7d89:6b8e with SMTP id j17-20020a05620a147100b007857d896b8emr7388504qkl.55.1707750460663; Mon, 12 Feb 2024 07:07:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707750460; cv=pass; d=google.com; s=arc-20160816; b=yR1QxN90ixi66DIeqNU5gV6Q7HflP1jL7BaG68f8ksPRc5jlTLod7rhPN+7KtFHPBV L7erzqf5McEwkbJfD7PG27d0YEpz48L4osajrdLgjDjdtZyROXn88XMwvc0j6C3jOFRR 95W2PtFMUwVOgbgOBXo/e9qBSuTNznkhwE8D/D8gG25jjZdIka4zZmnPxsznKQdwBkEX tzzhPLDhv00ua+oaHdRQWVfA58F6sPlShHbxs6l2sMlt34n+X3tQhUuC6EpA9chJMw72 IDM2DyQni8+izAOUku8JtsXPf6lg7O9VSxMTJrAw/scfbjUiI6WrRx0Lq4POwjawWXdp DlhQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wnB39ES76DNPpISASYCOBAKMF2MUBv8m38PEbyYRN+0=; fh=0ocFWIlgBLAqSyoNSeWk5uJ2AriHheLH07QnhlNhs3s=; b=RNR1LZccBcRTUm6knJdplt0B/BaF63ryDEOzTkNniVNOgWVh+eMyIihpmDoPcrlYu9 br+wT5r81bTy891/gQB0+TO+ZsypXsGXJZWDMS0Hf7IzQxo85QT7b++3eTRJMsW3j5HL hZTMH/Bp40teCnEQQgSqxRb/hf1em/fhEA0RuqEaKQdZ49FJoEkPfOlR/zPjj3cZ7lqK iK4cCK4t7yg5dd3t0jbqneUnknUWBN0HnKU+KpqqCUjbj3Uv0D0bo++SIiKg7dSTOPlF 5jLxF6dWoKHtHFcCQ00JqhAsF1mijUjKAay9VRnZUb6HuL1WLvfP4sCDIOUK0MNf/1A4 rYKg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=lkif+SG5; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-61871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61871-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch X-Forwarded-Encrypted: i=2; AJvYcCW01CsFecC+iKvSTZgUuoCH3aozOZYUtGh0GHRFHVt79E3U0sBFSXwiRbI9a9rAHmrKbAQE/7eOMn/igqtp1VnkDIBymNd2PazKjtQ4NA== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id az44-20020a05620a172c00b00785da900320si1273884qkb.78.2024.02.12.07.07.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 07:07:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-61871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=lkif+SG5; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-61871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61871-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6A1531C21736 for ; Mon, 12 Feb 2024 15:07:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AE2F23C689; Mon, 12 Feb 2024 15:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="lkif+SG5" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 843BC3C06A; Mon, 12 Feb 2024 15:07:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707750432; cv=none; b=u/LOBevsmRRvAwbsTOnefqBx5ecjY9/A47XWN/yY/NwQulVsPnasFWx5drXuAJmrG2KEa6IprCIDcnOUSWJDgCWaZJlO7gkUDlU8in7diHsWZEJvIcCNISrtObuJic6zOLwO11aoLk9ZHqgHXSlQrX1jL77DeTs+WvKE8w/dqoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707750432; c=relaxed/simple; bh=wQOq4bOK/MtslhyaEgSZoHnk92FEKvYn7lNpICXclX0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=teSwNA1nzlijXRNjNVp3ij9MacyVsdIM+YjGTafvE26GKr0SRgoXhkaszPnBMguB50OCo5L7/RNUuyfTjwmjCxMiZer/vZirj18BXGtVjd3S8VSMjre5olrChiRbjY4I6e7Sg7xx2T/qQGby3Ofm8FvruYQH5rWDM6wzXlOcBkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=lkif+SG5; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=wnB39ES76DNPpISASYCOBAKMF2MUBv8m38PEbyYRN+0=; b=lkif+SG5mbcCnNZEqgRMOrKSxA 220hgrFv/zNRNFObsNsagKTn6t8p3HCdkdXxJsCEcXQx/MM+mgTUddfTaYp+JHWThBAAbF9Bqi1S0 HLdJMD2lBbHX6JCuuzEAlj/AIs11BZ/k/FCJPoETDGG5yGvMwCT1KWaUJ1W3BjPJKIFo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rZXtm-007aK5-DX; Mon, 12 Feb 2024 16:07:10 +0100 Date: Mon, 12 Feb 2024 16:07:10 +0100 From: Andrew Lunn To: POPESCU Catalin Cc: "davem@davemloft.net" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "afd@ti.com" , "hkallweit1@gmail.com" , "linux@armlinux.org.uk" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , GEO-CHHER-bsp-development , "m.felsch@pengutronix.de" Subject: Re: [PATCH v4 2/2] net: phy: dp83826: support TX data voltage tuning Message-ID: <1412f8bc-6555-4e80-8e44-dda2292ac458@lunn.ch> References: <20240212074649.806812-1-catalin.popescu@leica-geosystems.com> <20240212074649.806812-2-catalin.popescu@leica-geosystems.com> <186cf83c-b7a7-4d28-a8b1-85dde032287b@leica-geosystems.com> <10ed19e3-01a9-4fcb-819f-686c6d0bf772@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > I see. Then, I should not disable WOL in config_init, since this > callback is also called on the resume path : > mdio_bus_phy_resume->phy_init_hw->config_init. > However, this contrasts with the rest of the driver and my patch is not > anymore about just adding support for tuning of TX voltage levels ... So wait until your patch is merged and then follow up with another patch disabling WoL. Patches get merged pretty quickly, so there is plenty of time before the next merge window. Andrew