Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2509452rdb; Mon, 12 Feb 2024 07:11:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNHJsD/KQ1h+TOEiTX1XmjMhVRtuv5JFGpjNm5JvGMahHloiikBK8pHjrVG6B3dt7eWL7s X-Received: by 2002:a05:6358:618c:b0:176:470f:9275 with SMTP id w12-20020a056358618c00b00176470f9275mr7969249rww.21.1707750706444; Mon, 12 Feb 2024 07:11:46 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707750706; cv=pass; d=google.com; s=arc-20160816; b=Grpzt8a8qh/g+e188zUbyl8B9z9f6uTB0JmyD4ZLfJh2KspMHTQbmAmoO7gGlsI069 lh1qUd95wyBYuIHiOu/RdcIfxxL7HOs8z9MT4uvLzW6JlpNVW6i75v5aDQ+uURVH6MXU X9dXlNv+/PsIycvR3QUabbF/qaGwj9Xm5N8MIMAktGexqoZRdkEIz/LCEL4msKcHajet y2F7P7B95CRgPU4KxM4y7B5peZQTIPwn+WemqH0q4rkYG354Sfo3ikqZWTtO2t10pKvt /o2xgGAnVqqoX6//tXR0d4Vp+GuZuq6MSk1mP3LUQn+cXqMu5aHZ2ZHAckvfv+WksGWC ux8A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ss2Gdsb9s4ZaDWMsTt+eMw+ubVBWFoCUmo1ODydN/mM=; fh=DN9tLF5k2TVBQ38ocdV0fn2HRiN4OfyyIpSpzRTlySk=; b=YTjqiYtt5zDO8PP3xNCQBED3J0QxXdhYmxLP4qLYRpVFO3O084fJMSSfmOoppT1/5J q48SHP5yRk35Emh4wNajsndjo8HYMxC9LMj4hnv3zvnJhG3BdxDZbG2vfivL5/iKkmKG Toy0a7GL+enQJiEc8gSHCf8EwZoFR+PBJX9Wr3mYgIgpYv6XRWu91NLihpEafO7ks0UD u1aIVZf+I4saUsXekMyhbn8Iv2bz0S43sdV7+1/Z0I2AShUdUZTKgQdJVbyEz+JZKxdf YgAiWowadqy5Vbo2G5PuoNuJx/k/TAOtR67e6s7HVOwNyyaVP5BeQiNIt+zSu8mBNnzc 4gJA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=NslzxFXW; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-61877-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61877-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch X-Forwarded-Encrypted: i=2; AJvYcCX7YYeDofV7sfsHHTkqHLD2041HCyPw6njneAmlXbdM6PmYW8MTLV2iW8RjkhexZIy0Dcfty7SrVBV2kaVWdb0l868vHz1V3YeYad2JKQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h10-20020ac846ca000000b0042c5f2ec553si565822qto.562.2024.02.12.07.11.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 07:11:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-61877-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=NslzxFXW; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-61877-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-61877-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 070A71C21AEE for ; Mon, 12 Feb 2024 15:11:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8E2AA3C694; Mon, 12 Feb 2024 15:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="NslzxFXW" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 294E43BB47; Mon, 12 Feb 2024 15:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707750687; cv=none; b=nNki16YOWys2BY1lRuZlGn+Lfe7UgdJcUCn12/kV45h5s+RVxzK8l/AX4d4RzQXJWxhe+x0gGLV4O444xAyPh1QNHyE3Pi29gSyZCr4z4uMkkNW1V6UQYvf32yLa8DQz3mr7dHMhQUpqPkHdyxxF9wO382Vyu1OO1AhiEQnlnvw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707750687; c=relaxed/simple; bh=Z6PbrS/54nr3uTDQ/r5+bbWElRXdrXgp6MGlAFsN3TE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nqq5tH8bFURoASiy9XT3MQxCAR/Cn1PvWmMV/+hRcfdCSTAWMSzOgyuYqE1LY5U9UGUHnFwXI3Gz/lY3UAkc9zweZ/ReQd4fs3n4huFwNPlda9UrzibdKzRXU9IxDas4xgQ/wcSdVjzykzJypEd+B9/Dilsb7kYWwTms+4CDCwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=NslzxFXW; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ss2Gdsb9s4ZaDWMsTt+eMw+ubVBWFoCUmo1ODydN/mM=; b=NslzxFXW4ui1gaNavsjs4QcwMT ef+/bfTQUiNfNdWJNJfyzZZ9IJmo9X7HOu/t0+uEK8HM4UOVzMZ6rYnJECu+Y4U3KgMfXlIfNVBI8 MjkEebpguYjvxTgUqs38DyyeCaYsysHpkwp3CFhEMszREnHc3AyX+A4zGSeZqlq4cKJ0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rZXQl-007a9N-Lw; Mon, 12 Feb 2024 15:37:11 +0100 Date: Mon, 12 Feb 2024 15:37:11 +0100 From: Andrew Lunn To: POPESCU Catalin Cc: "davem@davemloft.net" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "afd@ti.com" , "hkallweit1@gmail.com" , "linux@armlinux.org.uk" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , GEO-CHHER-bsp-development , "m.felsch@pengutronix.de" Subject: Re: [PATCH v4 2/2] net: phy: dp83826: support TX data voltage tuning Message-ID: <10ed19e3-01a9-4fcb-819f-686c6d0bf772@lunn.ch> References: <20240212074649.806812-1-catalin.popescu@leica-geosystems.com> <20240212074649.806812-2-catalin.popescu@leica-geosystems.com> <186cf83c-b7a7-4d28-a8b1-85dde032287b@leica-geosystems.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <186cf83c-b7a7-4d28-a8b1-85dde032287b@leica-geosystems.com> On Mon, Feb 12, 2024 at 02:15:47PM +0000, POPESCU Catalin wrote: > I just figured out that I forgot to disable WOL in the callback config_init. > It looks the PHY driver should explicitly disable WOL feature at init, > and leave it to ethtool to be enabled. > I will provide a v5 ASAP to fix that. WoL is a bit murky. On x86, it can be the BIOS which configures WoL, behind the back of Linux. That is not something i would actually recommend, so disabling it at boot does make sense. But consider suspend and resume. If the PHY is used for WoL, the WoL settings should be kept through suspend/resume. So you need to be careful where you disable it, so its only disables on boot, not resume. Andrew