Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751997AbXLWFBJ (ORCPT ); Sun, 23 Dec 2007 00:01:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750777AbXLWFA4 (ORCPT ); Sun, 23 Dec 2007 00:00:56 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:51451 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbXLWFA4 (ORCPT ); Sun, 23 Dec 2007 00:00:56 -0500 Date: Sat, 22 Dec 2007 21:00:30 -0800 (PST) From: Linus Torvalds To: Jeff Garzik cc: Arjan van de Ven , linux-kernel@vger.kernel.org, gregkh@suse.de, linux-pci@atrey.karlin.mff.cuni.cz, Benjamin Herrenschmidt Subject: Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue In-Reply-To: <476DE98F.2010009@garzik.org> Message-ID: References: <20071222043139.0cd59804@laptopd505.fenrus.org> <476D1D16.5090703@garzik.org> <20071222064719.73fdd9a4@laptopd505.fenrus.org> <476DB95F.3090801@garzik.org> <476DDFEE.3010009@garzik.org> <476DE98F.2010009@garzik.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 32 On Sat, 22 Dec 2007, Jeff Garzik wrote: > > But regardless of problems, enabling should be done globally, not per > device... I'm ok with trying the "globally" idea, but it has to be "globally but only if absolutely required". And quite frankly, how do you tell whether it's absolutely required or not? I have an idea: the drivers that really need it will do a "please enable MMCONFIG, because I will need it" thing? Ok? And then, since we *need* such a "pci_enable_mmconfig()" call anyway, why not let the driver give which device it controls too, so that we can print out the information (in case the machine then hangs immediately afterwards), and perhaps - if it is shown to help - only do the MMCONFIG cycles for that particular device? Sounds like a plan? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/