Received-SPF: pass (google.com: domain of linux-kernel+bounces-61914-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <8eefeeb7-f8e8-49f4-b83c-e67a9e728f41@mailbox.org>
 <20240209154336.7788-1-torvic9@mailbox.org> <d06441c9-db33-4c44-81cd-dc1052f48e43@amd.com>
In-Reply-To: <d06441c9-db33-4c44-81cd-dc1052f48e43@amd.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Mon, 12 Feb 2024 16:41:49 +0100
Message-ID: <CAJZ5v0hPkOAkWaDFu79RAcyht5r9CK8pwuVpumL5==1D9cFMYQ@mail.gmail.com>
Subject: Re: [PATCH v3] cpufreq: amd-pstate: Fix min_perf assignment in amd_pstate_adjust_perf()
To: Mario Limonciello <mario.limonciello@amd.com>, Tor Vic <torvic9@mailbox.org>
Cc: Perry.Yuan@amd.com, ray.huang@amd.com, gautham.shenoy@amd.com, 
	rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org, 
	linux-pm@vger.kernel.org, Oleksandr Natalenko <oleksandr@natalenko.name>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 9, 2024 at 4:50=E2=80=AFPM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> On 2/9/2024 09:42, Tor Vic wrote:
> > In the function amd_pstate_adjust_perf(), the 'min_perf' variable is se=
t
> > to 'highest_perf' instead of 'lowest_perf'.
> >
> > Cc: <stable@vger.kernel.org> # 6.1+
> > Fixes: 1d215f0319c2 ("cpufreq: amd-pstate: Add fast switch function for=
 AMD P-State")
> > Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> > Reviewed-by: Perry Yuan <Perry.Yuan@amd.com>
> > Signed-off-by: Tor Vic <torvic9@mailbox.org>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> > ---
> > v2->v3: Resend with git, misconfigured mail client borked v2
> > v1->v2: Add Perry's 'Reviewed-by' and 'Cc: stable' tag
> > ---
> >   drivers/cpufreq/amd-pstate.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.=
c
> > index 08e112444c27..aa5e57e27d2b 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -577,7 +577,7 @@ static void amd_pstate_adjust_perf(unsigned int cpu=
,
> >       if (target_perf < capacity)
> >               des_perf =3D DIV_ROUND_UP(cap_perf * target_perf, capacit=
y);
> >
> > -     min_perf =3D READ_ONCE(cpudata->highest_perf);
> > +     min_perf =3D READ_ONCE(cpudata->lowest_perf);
> >       if (_min_perf < capacity)
> >               min_perf =3D DIV_ROUND_UP(cap_perf * _min_perf, capacity)=
;
> >

Applied as 6.9 material, thanks!