Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756114AbXLWFW6 (ORCPT ); Sun, 23 Dec 2007 00:22:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751458AbXLWFWv (ORCPT ); Sun, 23 Dec 2007 00:22:51 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:46144 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbXLWFWv (ORCPT ); Sun, 23 Dec 2007 00:22:51 -0500 Message-ID: <476DF0A3.9070701@garzik.org> Date: Sun, 23 Dec 2007 00:22:43 -0500 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Linus Torvalds CC: Arjan van de Ven , linux-kernel@vger.kernel.org, gregkh@suse.de, linux-pci@atrey.karlin.mff.cuni.cz, Benjamin Herrenschmidt Subject: Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue References: <20071222043139.0cd59804@laptopd505.fenrus.org> <476D1D16.5090703@garzik.org> <20071222064719.73fdd9a4@laptopd505.fenrus.org> <476DB95F.3090801@garzik.org> <476DE07A.4000204@garzik.org> <476DE19F.5040702@garzik.org> <476DEC66.9050701@garzik.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 28 Linus Torvalds wrote: > On Sun, 23 Dec 2007, Jeff Garzik wrote: >>> And yes, if you want the capability following to notice automatically when >>> capabilities really do go into the 0x100+ range, that's fine. I suspect >> Yes, we /must/ do this checking, if we don't already. > > Hell no. If the user asked for mmconfig to be disabled, it needs to be > disabled, because it may well be broken and non-working. It's better to > not see some capabilities than to lock up the machine. I think my short response created confusion. I was only saying that we should check for capability overruns, if we don't already[1]. I wasn't saying anything about mmconfig in that sentence, sorry. Let's pop this sub-thread off the stack, and jump to your "Sounds like a plan?" train of thought. Jeff [1] Lioc's response seems to imply my worry about overruns is unfounded. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/