Received-SPF: pass (google.com: domain of linux-kernel+bounces-61949-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Frank Li <Frank.Li@nxp.com>
Date: Mon, 12 Feb 2024 11:19:08 -0500
Subject: [PATCH v2 2/2] usb: dwc3: apply snps,host-vbus-glitches workaround
 unconditionally
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240212-vbus-glitch-v2-2-d71b73a82de1@nxp.com>
References: <20240212-vbus-glitch-v2-0-d71b73a82de1@nxp.com>
In-Reply-To: <20240212-vbus-glitch-v2-0-d71b73a82de1@nxp.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
 Rob Herring <robh@kernel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
 Conor Dooley <conor+dt@kernel.org>, Felipe Balbi <balbi@kernel.org>, 
 Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, 
 linux-kernel@vger.kernel.org, imx@lists.linux.dev, 
 Frank Li <Frank.Li@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OXJFTWFaYmFOZTVqMSsvRm9WN040aXZzcmdxSEpManJkZjlTWFlvOEo0VEJW?=
 =?utf-8?B?a3RiUnVEYlhoZjhWbFRpZXRIOVUrdjJtNG9uWEN2SU9nZE0zVzl3eTJKSW0v?=
 =?utf-8?B?ZWdqUm1Wb2w0V2NjL1hTODJCbEJ5RW13M09ZalRvbTFxT2tzTFdKYnVQM0pW?=
 =?utf-8?B?cEZMaVd0bnFhY0JTUy8yOFd0ZXlRT3RaTStRN1JGQlhGY3NiWGlydGRuQU5x?=
 =?utf-8?B?RXIrV2U2L0QxRjUyOW9RVDNIbHFlelhOL1hmMVcwN1RQZGxUZVZCVzZSclBX?=
 =?utf-8?B?R0V2STlMZHJ2ZE5pTmE5WHZjNDBvbGxMZHI1ZkJKM2JaWmtQSG1ZY2RIdk9u?=
 =?utf-8?B?UUk4K2h5T2RPYWRkem8ydmJKR2pKc1FFK2VlRUxBYTQxc0ZMSkpMMS9taVZ4?=
 =?utf-8?B?ZytoWHczcXJ6Snk0WkZwWHVyU1VCR3NrY05jTjFISHU0MU9IQ0ppenlmR1pV?=
 =?utf-8?B?SmVjTzQrWlhCU2Z2eEtkTzViZllRR3NvM01MVjdFVDErUEFaajdYc285N2tF?=
 =?utf-8?B?dDdKRWRVYjZ1azV4NStGNzdGY2dSbDA4TzVXQ0dwZzU2OUpmYmdnTkdDcFpV?=
 =?utf-8?B?WXpZNmxjQks4NGQ3N1UrUW5NMDlXc2dvRkJSRUxQdW9zaUd0dFNsd2Z4ak1i?=
 =?utf-8?B?dzJkTUxGczV2dlY4SUpYYUxnTEdFc0JUOUZncmh0Wk1JWDJJRWhXakhOVUJK?=
 =?utf-8?B?UDRsTlZPbW1mTytTTzUybFhJUldsVDAyRGZ5NEVkT1MyTExFbzBsR1IyYWND?=
 =?utf-8?B?QVl4WFdNWmUyZzVsb0Znbkp4QTNpWmRoUjFsdkVzdXFqY290dThDcytmcDlq?=
 =?utf-8?B?M2JnUkdrdk53dmlnVTBJdkJDSWVRcWtuQzNHT0htVFVxQkw0Uk9ZNFgvRVJ4?=
 =?utf-8?B?ak9UMFN4aWROeE00dTcvNncycWVYUVp1TFZQZTgwS3JIaW5BYWh6R2hnWGg1?=
 =?utf-8?B?bklBUnVOdnpYclFHVkF0dy8zUzBTMVJGQWtnNmQvdER0Ly9CT2xtTDdvdGgv?=
 =?utf-8?B?V1YvSlYweTZ2TVFTNUFFTzlBTC80RHRUcHIrYUFqUjA5S3pUa21nZWJuNzU0?=
 =?utf-8?B?bVM5YnB3dDFsc2NtWGhINXF2NlArcXB6OGxPa3JzVVliQUl5RWtoTFNIeVJ2?=
 =?utf-8?B?VHZpTWVWYjhFWXVNSW5yVG9HdW5BckhnbmIyczlpWU12UGZxV3dXSm9hZEhL?=
 =?utf-8?B?cVlWbWtpQUZQaVlSQ0I5TE5EZXJHQVpJR3NkUzRqWm8zSW9FdmxpLzJpdE1j?=
 =?utf-8?B?QWNUZGFsSzgrL3VDZGx6aldtbHBIUS9rSkhHOEh0cVdmaGRyQjhkbS9qQWNj?=
 =?utf-8?B?VUwwaVdYOGNBaUpHcFpGYlJ2R2V2M1FzZ1FmVGVQZFVjOGVjT1k4Q3pORkxT?=
 =?utf-8?B?U2FwTnJyQURQUElMQVMwS1UzcEpSWDZCd1owc2ZGYUVGSGV4NENZcmdSRGZM?=
 =?utf-8?B?OEM2blBZNjF1S2NVSDRGeUZ0ekwxSHhCMW5CdTB3VWsxYTZrUlUyTEl6YXlW?=
 =?utf-8?B?TTh6cnM4M1F4aUM2bi85citUSDd2R0tGcktreGpTNlpjR2V5dlNhMmRqMWhH?=
 =?utf-8?B?NzZmV3FLazhCSUYxQXY1SU9mRUNHUnNHMTRGOHZwRGc0WDdWWDhNeGNRa0V1?=
 =?utf-8?B?aVRsNzNOd1ZWTm0xY3VOTUh6cXo4dGJRUjlWV2hWbW9CYVBaVkdVeitwUlN5?=
 =?utf-8?B?VUh5Y2ZmV2FKekhGQkZwS3Fxdm8yRXRPRjJBeDJhaDl4b1BON29BeklrL3Jp?=
 =?utf-8?B?Sjc2ZjJadjdWV2NKVXIrSUV6WC92YlkrOFlEZVlQZ0tmUHFYUFptUDZxR2l2?=
 =?utf-8?B?WXJ0bGFSSGtOOEE1Y3V6YkpGanM2TFhHOWROTnhyUFN6ZkhIaHdZbWJ5eWh5?=
 =?utf-8?B?YjFTTjhobElBNG45cisxT1hzUnFzYm96QWc2UXZMZEFWWlJiaDU3My9CWGY3?=
 =?utf-8?B?OU1jMzIvL010NFRNbCtnemNvemxKMnVvTXJoMXhSVkFDbGF6NnNuRDU0dTR2?=
 =?utf-8?B?NGQ4TGtQK2dnNUpHa01uTTkvMjlqVld1c0pPWDEwOTlRS2xYcEFrOTE0Wisy?=
 =?utf-8?B?Zk9LRHhGWXBtUDhVY2J6Y2k5cVFmZ3JhMitaN21BYm9pMkR2alF0ZW1GU2lO?=
 =?utf-8?Q?Gdjk=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11c26fc0-abe9-4f8c-b337-08dc2be66444
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 16:19:30.5521
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dZjJkGXhNVIGpybPBEctOi2EJrUCbA3u9IrvctqR/Uwc4qlEWa+zo/seKT8lLCTmAQpx3+TKyO1bF18mOWsTnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9049

Remove 'snps,host-vbus-glitches-quirk' and apply workaround
unconditionally.

It is safer to keep vbus disabled before handing over to xhci driver. So
needn't 'snps,host-vbus-glitches' property to enable it and apply it
unconditionally.

Remove all host_vbus_glitches variable and call
dwc3_power_off_all_roothub_ports() directly.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/usb/dwc3/core.c | 3 ---
 drivers/usb/dwc3/core.h | 2 --
 drivers/usb/dwc3/host.c | 3 +--
 3 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 3b68e8e45b8b9..3e55838c00014 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1626,9 +1626,6 @@ static void dwc3_get_properties(struct dwc3 *dwc)
 	dwc->dis_split_quirk = device_property_read_bool(dev,
 				"snps,dis-split-quirk");
 
-	dwc->host_vbus_glitches_quirk = device_property_read_bool(dev,
-				"snps,host-vbus-glitches-quirk");
-
 	dwc->lpm_nyet_threshold = lpm_nyet_threshold;
 	dwc->tx_de_emphasis = tx_de_emphasis;
 
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index df544ec730d22..e3eea965e57bf 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -1132,7 +1132,6 @@ struct dwc3_scratchpad_array {
  *	2	- No de-emphasis
  *	3	- Reserved
  * @dis_metastability_quirk: set to disable metastability quirk.
- * @host_vbus_glitches_quirk: set to avoid vbus glitch during xhci reset.
  * @dis_split_quirk: set to disable split boundary.
  * @wakeup_configured: set if the device is configured for remote wakeup.
  * @suspended: set to track suspend event due to U3/L2.
@@ -1354,7 +1353,6 @@ struct dwc3 {
 	unsigned		tx_de_emphasis:2;
 
 	unsigned		dis_metastability_quirk:1;
-	unsigned		host_vbus_glitches_quirk:1;
 
 	unsigned		dis_split_quirk:1;
 	unsigned		async_callbacks:1;
diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index ae189b7a4f8b8..98964e8dea1f7 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -114,8 +114,7 @@ int dwc3_host_init(struct dwc3 *dwc)
 	 * Some platforms need to power off all Root hub ports immediately after DWC3 set to host
 	 * mode to avoid VBUS glitch happen when xhci get reset later.
 	 */
-	if (dwc->host_vbus_glitches_quirk)
-		dwc3_power_off_all_roothub_ports(dwc);
+	dwc3_power_off_all_roothub_ports(dwc);
 
 	irq = dwc3_host_get_irq(dwc);
 	if (irq < 0)

-- 
2.34.1