Received-SPF: pass (google.com: domain of linux-kernel+bounces-61999-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Thomas Gleixner <tglx@linutronix.de>
To: "Zhang, Rui" <rui.zhang@intel.com>, "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>
Cc: "Raj, Ashok" <ashok.raj@intel.com>, "mhklinux@outlook.com"
 <mhklinux@outlook.com>, "arjan@linux.intel.com" <arjan@linux.intel.com>,
 "ray.huang@amd.com" <ray.huang@amd.com>, "thomas.lendacky@amd.com"
 <thomas.lendacky@amd.com>, "andrew.cooper3@citrix.com"
 <andrew.cooper3@citrix.com>, "Sivanich, Dimitri"
 <dimitri.sivanich@hpe.com>, "Tang, Feng" <feng.tang@intel.com>,
 "kan.liang@linux.intel.com" <kan.liang@linux.intel.com>, "Mehta, Sohil"
 <sohil.mehta@intel.com>, "peterz@infradead.org" <peterz@infradead.org>,
 "paulmck@kernel.org" <paulmck@kernel.org>, "kprateek.nayak@amd.com"
 <kprateek.nayak@amd.com>, "jgross@suse.com" <jgross@suse.com>,
 "andy@infradead.org" <andy@infradead.org>, "x86@kernel.org"
 <x86@kernel.org>
Subject: Re: [patch v2 21/30] x86/cpu/topology: Use topology bitmaps for sizing
In-Reply-To: <87fryjhmjs.ffs@tglx>
References: <20240118123127.055361964@linutronix.de>
 <20240118123649.739960607@linutronix.de>
 <7c8874d971c69fb4c22c1b771983f8d5109a9387.camel@intel.com>
 <87fryjhmjs.ffs@tglx>
Date: Mon, 12 Feb 2024 17:40:52 +0100
Message-ID: <87mss5k54b.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Fri, Jan 26 2024 at 21:22, Thomas Gleixner wrote:
> On Fri, Jan 26 2024 at 07:07, Zhang, Rui wrote:
>> Say, on my Adlerlake platform, which has 4 Pcores with HT + 8 Ecores,
>> cnta is 12, cntb is 16, and smp_num_siblings is set to 1 erroneously.
>>
>> I think we should use
>> 	smp_num_siblings = DIV_ROUND_UP(cntb, cnta);
>> here.
>
> Indeed. That's more than obvious.

I pushed out a new version which addresses this and also the fallout
Michael and Sohil reported:

  git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git topo-full-v3

I let the robot chew on it before posting it in the next days.

Thanks,

        tglx