Received-SPF: pass (google.com: domain of linux-kernel+bounces-62000-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <6da6439b-5ced-4c57-b48f-c0fa33f4d524@intel.com>
Date: Mon, 12 Feb 2024 08:41:16 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 5/5] selftests/resctrl: Add non-contiguous CBMs CAT
 test
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
CC: <shuah@kernel.org>, <fenghua.yu@intel.com>,
	<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
References: <cover.1707487039.git.maciej.wieczor-retman@intel.com>
 <2c1011e7630605365b67caa6ddfe4e8ee2ba5bff.1707487039.git.maciej.wieczor-retman@intel.com>
 <b63354ab-458a-46a5-a80a-971845f1de9d@intel.com>
 <gybtxxilnj3wychwz5cdzltwzhhazx2dvzkyk7r3afqnkilja3@e3btzsz6odc3>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <gybtxxilnj3wychwz5cdzltwzhhazx2dvzkyk7r3afqnkilja3@e3btzsz6odc3>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEkvU1loYnBvQWV1TXhiaDArbWdNbjdRMHpla2luNUM0Y2ttNjZZMHMwWmZV?=
 =?utf-8?B?ZGozOUNEQkQyTkpCbkhjNnhtRGtJUlF1Y053MC8xQUxoM0FxTnFRQXF1VUsv?=
 =?utf-8?B?aStZaWhzeXBCa0ttNkpLdVVrRmhmaVdmUlNnOWRxaW5vcTJLNkp2d3ZYWGJ1?=
 =?utf-8?B?RUs4WjJMc1lVQzNrbmRrRjBlbkVqUmtHMVpwNGhkWGJUazZ2akl3ZU4xUlBK?=
 =?utf-8?B?VTBYNlFQOFdEUlE3ZFU5S3pPb3l2NU9OS2ljUWxMN2RubUhUMDk4NFJJTlN1?=
 =?utf-8?B?bE5VQUNzNjZ1eWFCRjJ4N0ZnMjVqVGFCbW5TTEsyWlQwRkJhRzhkZ3UxNWh4?=
 =?utf-8?B?bDRKRTdGUXdxTjlaMTRsNTJJeEZ0S1hYSjR1MFlKSGpjS1RSb2RxVmVKQXQx?=
 =?utf-8?B?VytSYUJyY1U2TmhpUEszOUJlTCtPYjNYcDMrUjhEQ3MrSjdwK0tXcXJqQlkv?=
 =?utf-8?B?ZnBUajBBMHZCaS9qMFRkTkNpalM0WHN0RXB2NDVJVjVyQ3JXVW9LZzhDSVhH?=
 =?utf-8?B?WGNCV1NXc1hSbWFUcllGalQ3STh1YldiQlM0UkNVcG80U1Nab0RuZjhXbVlr?=
 =?utf-8?B?b3ExNExpRWd4Q0RROW1wY0o3RWFhRURPNVpwZjhwZmhBZkRCcS82aFcyNWJI?=
 =?utf-8?B?VlNZUUZsRHZNZXB1c1dFL2lCSDBHUzNMMkxoQlprNks2RDgxc3pWbG8xYkNW?=
 =?utf-8?B?VU14RnhzZkxPL0poVFBWZmFNb3VWNy8xZ2dUczVzTzBIZHBXUEc2WjlTOTdm?=
 =?utf-8?B?b0dHdzdpSythUmpVcnRKMDdyQ1pHeGp6MGdmdnNXVmtvVVlzVC9pSTMwcnFp?=
 =?utf-8?B?amo5aGNldGJVWkYvNjh2d2NQQS85NUVBNGRtQWtzR21JTElwWHVmazJxSmll?=
 =?utf-8?B?Q0d3d25rL1hLUDdHbnRkMzhTeFJiTFd4SHlrdTRqVUdxTVRseTlzelFVUDYy?=
 =?utf-8?B?WU10SDlucW1GekljbEJ3SDRMT3F0ZGRtcG04bFRDdlltc1dXc2p1cG1TbXFi?=
 =?utf-8?B?Ny9RM1dtajhUcTVaYWZLWVBIbXVXVVhaK0FEV2RiNnpGbjExV3lpbFJMekFn?=
 =?utf-8?B?UGJLWlNuaGR6eElKQnFWODB5Z1VaekV1ZVNhRkQwY0M2TUMzMlZUQmhVVlAv?=
 =?utf-8?B?b2VqUjNyZTIxR0xDdHVzWUFMSUdXRGNmK1RuY1dpT0V5eGNUeEFnSE8vRUtK?=
 =?utf-8?B?WGRaSmx1OEFkc1dhem8rSUY4dlVhVFpib3pyWG5saTFkZHdadkpob2lkcWJW?=
 =?utf-8?B?TjNvWjlrbmJwZ0VGRVZHamhNM01RTUR0ZFVVbkwwS2xicXI2SlJPWkYwSzZj?=
 =?utf-8?B?R2NMM09Ma2gzMStYZ2RETWprYi9LMXAxTXRTOWtheEhIbVdRQmlKcjMyMldr?=
 =?utf-8?B?RFdzakZ3Z2dUVm1EVnhIYkdFcXFSdm1MWEI4cGVMR1VaYnB6ZzU2bGZrVUM0?=
 =?utf-8?B?YkdsOXNzMll1b0V2NFFsUEppSFhIRnlaTDR0VkY3TEJJaG1LZ0tISGFPVlgx?=
 =?utf-8?B?MmVrR3NvdlNEamdpMlVJbFRadGZLeG5STFhSWDNLb3o0SEc0TjJDdGdtNmxv?=
 =?utf-8?B?WFFLVVdBaWxMUzFnZjhQYXRZQXMyQjdabThXd1BFSVBucW51MHBBWURJKzFX?=
 =?utf-8?B?NGdNUUdvNnRPMG96Zy9hUllGMkpwSnNsZU1TTDUrZ3JTb0RFZ3hDL3lQRFBS?=
 =?utf-8?B?WFdoTEpJKzF2N2ZZalVtejhPNUxWTFdLNFFrVEE5YzRPOGZwRUZqWkJOLzE1?=
 =?utf-8?B?UlVJWU5QTk9mMkRyWFhkbm1BSE4vNnlaNllhWS9GQXArMWprUkMrbzkvYW9J?=
 =?utf-8?B?S1N3UjREWWJrc0JIZlB6NTRMSW5ZVndQSGUxNU0xQllrWXYxRlBWemFpMW5E?=
 =?utf-8?B?OS9zZUIvZlk4QjFwS2FKb2tvZzgyeGdSRTBzL3dVQytJRExpd21RRmxFUkl5?=
 =?utf-8?B?UG9pMjQxeXk0bnpvOW13VEVFOVRDUjk1aGNRakMwU0ZGcyszLzgxWmdrZElB?=
 =?utf-8?B?STlmVHZZb1pZcGwzWTIwRUxFRUlrY21jOXJZb05FWW5WcTVLa3BkTThzZVNv?=
 =?utf-8?B?bktmbGJMdEF2OVo3cFB5cEwwTjB4ZngybEFUOE5RL25sa0FRWkV3SzBPd3Ni?=
 =?utf-8?B?U0NHVjZrMXpiWFQycytXVDFDZmNYRlZMRm1tMVFzZDNqRGFGdWNLclZmR0R6?=
 =?utf-8?B?OFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ec3f66f0-61b9-48e7-6920-08dc2be97027
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 16:41:19.0909
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bzBuQKyFgphZ8t2rvihC2dv2zcIJsHpZYCRAgFvF49vYulXbmSpBUQ/YJXgha2eBb4xkjNZ0wIxwyHOayCGCn11GVOOfrehtCAsOV+cad1c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5313
X-OriginatorOrg: intel.com

Hi Maciej,

On 2/11/2024 11:38 PM, Maciej Wieczor-Retman wrote:
> Sure, I guess I could make the check 'if (bit_center < 3)' to also check if the
> full_cache_mask isn't too short for some reason (since later 2 is substracted
> from bit_center for the 'hole' bit shift).

Thank you.
 
> Or would this need some comment as well (why exactly the '3' is there, maybe
> write something about about the minimal full_cache_mask length for this test)?

The use of "Or" and "as well" makes it unclear what you propose. I do
think the check in addition to a comment will be helpful.

Thank you.

Reinette