Received-SPF: pass (google.com: domain of linux-kernel+bounces-62009-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Content-Type: multipart/signed;
 boundary=7c640255eac135c68b597b52d418781ce4ba02d5840e4f5c2d60ce4c9520;
 micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk
Mime-Version: 1.0
Date: Mon, 12 Feb 2024 17:50:19 +0100
Message-Id: <CZ3974AW5FT3.39WK876PU00AZ@gmail.com>
Cc: <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7
From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Jon Hunter" <jonathanh@nvidia.com>, "Svyatoslav Ryhel"
 <clamor95@gmail.com>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley"
 <conor+dt@kernel.org>, "Shubhi Garg" <shgarg@nvidia.com>
References: <20240212071843.6679-1-clamor95@gmail.com>
 <20240212071843.6679-2-clamor95@gmail.com>
 <8ffbe7ae-67e9-4a3f-9866-3cd744729971@nvidia.com>
In-Reply-To: <8ffbe7ae-67e9-4a3f-9866-3cd744729971@nvidia.com>

--7c640255eac135c68b597b52d418781ce4ba02d5840e4f5c2d60ce4c9520
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

On Mon Feb 12, 2024 at 5:14 PM CET, Jon Hunter wrote:
>
> On 12/02/2024 07:18, Svyatoslav Ryhel wrote:
> > Correct codename of Tegra Note 7 is "tegratab", while model
> > name should be "NVIDIA Tegra Note 7". Fix this inconsistency.
> >=20
> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > ---
> >   arch/arm/boot/dts/nvidia/Makefile                            | 4 ++--
> >   .../{tegra114-tn7.dts =3D> tegra114-nvidia-tegratab.dts}       | 5 ++=
+--
> >   2 files changed, 5 insertions(+), 4 deletions(-)
> >   rename arch/arm/boot/dts/nvidia/{tegra114-tn7.dts =3D> tegra114-nvidi=
a-tegratab.dts} (98%)
> >=20
> > diff --git a/arch/arm/boot/dts/nvidia/Makefile b/arch/arm/boot/dts/nvid=
ia/Makefile
> > index 7a422f150488..474f3fbbd99d 100644
> > --- a/arch/arm/boot/dts/nvidia/Makefile
> > +++ b/arch/arm/boot/dts/nvidia/Makefile
> > @@ -2,8 +2,8 @@
> >   dtb-$(CONFIG_ARCH_TEGRA_114_SOC) +=3D \
> >   	tegra114-asus-tf701t.dtb \
> >   	tegra114-dalmore.dtb \
> > -	tegra114-roth.dtb \
> > -	tegra114-tn7.dtb
> > +	tegra114-nvidia-tegratab.dtb \
> > +	tegra114-roth.dtb
> >   dtb-$(CONFIG_ARCH_TEGRA_124_SOC) +=3D \
> >   	tegra124-apalis-eval.dtb \
> >   	tegra124-apalis-v1.2-eval.dtb \
> > diff --git a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts b/arch/arm/boot/=
dts/nvidia/tegra114-nvidia-tegratab.dts
> > similarity index 98%
> > rename from arch/arm/boot/dts/nvidia/tegra114-tn7.dts
> > rename to arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> > index bfbdb345575a..30b2ed91be23 100644
> > --- a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts
> > +++ b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts
> > @@ -5,8 +5,9 @@
> >   #include "tegra114.dtsi"
> >  =20
> >   / {
> > -	model =3D "Tegra Note 7";
> > -	compatible =3D "nvidia,tn7", "nvidia,tegra114";
> > +	model =3D "NVIDIA Tegra Note 7";
> > +	compatible =3D "nvidia,tegratab", "nvidia,tegra114";
> > +	chassis-type =3D "tablet";
>
> No mention of adding the chassis-type in the commit message. Seems like=
=20
> that should be a separate change.

Agreed. Along with Krzysztof's comments maybe this should just be a
single patch that updates the model property and adds the chassis-type.
We haven't used chassis-type before, but I see that the devicetree
specification has it marked as "optional-but-recommended", so maybe we
should make a pass over all files and add these as appropriate.

Thierry

--7c640255eac135c68b597b52d418781ce4ba02d5840e4f5c2d60ce4c9520
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmXKTEsACgkQ3SOs138+
s6FMYxAAtw170jJGnf2jjS+4ueekSK3Ym6O38q1r0QQu8S71dwn7SHUFfxLmnvzT
b4eTV+3mSt9S1z2YGxseXo9YCV21ZmhOBqCtjpgnE3hf/yoBCMt6oOGw5O5TYtl7
5Aa7fTdSBEWvG3zKT39kR73o0TtVn4FV5XecsZIu7922LA7IEqAEkb53T4p7mmTo
lHmI6qUTzISgYO2T7JhAPTUsh+R3F66HM0mnDTU6s59Leaazi1WfoWX2gufWfDWP
aUGXb0O+lTJKVIzE83vbGgPeC5MSYMHXlGe9bPIkaThJjbUnO066bUwEZ7e6F/WJ
V+169e6ueZdPNxr7A/gDVbFN28e3KHbYon7khgdJZOPpfp2TWN0EGfkPPj5Jhdya
dMnqvOLEt7OTWbDIcjfIzPNPsiKETsOMN9YrTYkCvJN3yOelvFF+oogrvDCkWFpn
48WFVAxUq83nmPz1Rv71mpwWH2sySWhf6Oe5QesaDxmfaL8gIpmL1MPbtB3o8kz1
U8LZ0G1+5HPUUsyvQDU6BPaU5TQqS9zqu0/YSwQydlAp/ZZ36H5xwkeMN2PBMNr+
LKMJl2Sz5FmM0FkIWTkYEfPmCqQSE0i6vNeZqH8Y++qPXfnTCzoGNiBUouME4Cp+
t5Yh3PnHtu3sCM6rmfWApTqRsJ10UBuDd7fF8BKFlf+tVeBG9Kk=
=U8Ue
-----END PGP SIGNATURE-----

--7c640255eac135c68b597b52d418781ce4ba02d5840e4f5c2d60ce4c9520--