Received-SPF: pass (google.com: domain of linux-kernel+bounces-62086-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <5eb8850b-ada0-4945-b81a-995fd0b8b134@amd.com>
Date: Mon, 12 Feb 2024 11:22:56 -0600
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v15-RFC 6/8] x86/resctrl: Introduce snc_nodes_per_l3_cache
Content-Language: en-US
To: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
 Reinette Chatre <reinette.chatre@intel.com>,
 Peter Newman <peternewman@google.com>, Jonathan Corbet <corbet@lwn.net>,
 Shuah Khan <skhan@linuxfoundation.org>, x86@kernel.org,
 Shaopeng Tan <tan.shaopeng@fujitsu.com>, James Morse <james.morse@arm.com>,
 Jamie Iles <quic_jiles@quicinc.com>, Randy Dunlap <rdunlap@infradead.org>,
 Drew Fustini <dfustini@baylibre.com>, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org, patches@lists.linux.dev
References: <20240126223837.21835-1-tony.luck@intel.com>
 <20240130222034.37181-1-tony.luck@intel.com>
 <20240130222034.37181-7-tony.luck@intel.com>
 <89dc9022-c9a4-42dc-8710-be2d6d9a4e7c@amd.com>
 <ZcZ-cDqGLTtHpB1T@agluck-desk3>
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <ZcZ-cDqGLTtHpB1T@agluck-desk3>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?M2RCZk1ieTNiVHErU0xJbStmdkNGZWVIOVpCZmtyY0lXaFRKL0t5Wk9TV1VD?=
 =?utf-8?B?cGJjQ0NRV0FodktZdDJQVHFnYVVUK21YemluUm9hZWgxL1JCVDNyQ1Q4OWtS?=
 =?utf-8?B?NXU2RGJjSXdzdUJlRlNZeDJkVnNkdUlKcnFGY24vTHNYZ0dvZVduTGJpUHhB?=
 =?utf-8?B?bmIrK1duRThFNkpYcjdNUU1rWVdhWWMxRzRJKzZGd3lEMlhpUVl1UGZNWThN?=
 =?utf-8?B?SWVxSEhMZUZ1OG9ldm5ybUE3aWpyZGlrS0JDWHNxWXJaNFpMRGlLNDZKNWFX?=
 =?utf-8?B?ajJLV2c4eDhsRjF5RmFZeGJMU0gvOXh4REhwVDdMTlMrWGxNYVZQQndGUmxF?=
 =?utf-8?B?OFAxeEswMnQzc2FoWEIvbzJPa2JabGtEUjRVamdCS015MXl3Z21yV1E5Z2o2?=
 =?utf-8?B?MzFPU2RHZ0tPa2dvbGxPKzR5ZDdwQy9KU2ZubGpuWGJ4R2V6aXhBd2ZuQVg5?=
 =?utf-8?B?RTJWamhnL3hNdm1Sejk4emNsRG5heU5HK1puNnFEYnc3RFdNM0hiK2h2Ynk1?=
 =?utf-8?B?TStKb0R6MFBDSXY0OXc2QThOeWh1dEEveUZ4MGQvUHQ0cWF3MHN5cXh1U1FC?=
 =?utf-8?B?UU9sSk41MDM4bGJXaUdHRHBRRHdrclFIZGJZSEVmZTJ2Mit2WnMzUEJFdC9N?=
 =?utf-8?B?TTVqT1NhSHYwQjEyakdtTms4aG1LbDZ4dEdEQ01HTXM4QjlBT1hlemNjWlFt?=
 =?utf-8?B?d0FWTWI1Ri9xb1IzMWlPcExZYldySENhWXhDamRTVkYzRFZLdG8yVnN6Y29G?=
 =?utf-8?B?VGtGK0JWblVKVnVjUERtTUtnY3dWYjFDZ1hidFdxWG5SN2V6ZFdRMWNtQUJk?=
 =?utf-8?B?TjhPdUFDS2t6N0RPWGgwYlVOdlJJYnhiemZ1SUFQTjhKTU02YmxkTHlJU3RI?=
 =?utf-8?B?NkVJa0lzWXBQSEtOYUdVb1AzcHNqTGZacjNnT2VTMTMreEJVcFlSR2NRKzVP?=
 =?utf-8?B?ZEJYZXFXUTE1Vm1XZUxGVmNpMEJvNUl6eG85UllwWGhzdFN6RjZNWFVnaW52?=
 =?utf-8?B?dDBVM0JIampkQ1ZWaCthOFVGaVRRS2Z0V1RjUE8vMHVWVUlXUU9nM0V0bUlq?=
 =?utf-8?B?bSs4ZFYvaUZURi9FMnRTalpTd3Zxd2RTbTUwTXByTmRkSEhUaStyb3lCNE8x?=
 =?utf-8?B?eHRjUzRBRllLK1BVbm5neWQzUmpVYy9ONkRPWnRVSkZRbW9WaXBLb2Z0VUJp?=
 =?utf-8?B?VFE0WjJqeDRCcnBlMENGUUFZZEhtaUh2c2lKeFU3SnZQSlR5eVo3bzYwWGw2?=
 =?utf-8?B?UXJLVTNHKzZVRFZSb2YxN1hUdllURXBoTzJTcnpzUkIwM0FnS05EZTJUcUZV?=
 =?utf-8?B?bk5qK1RJaXRpSzlRb3p1c05sT09ibFhlL3QwR01VUkNSWHh5eFBWUVJ5eVc5?=
 =?utf-8?B?dWhyT0doNU5rUHZPaVRBSEdjWWd1WWEyOEVYbmxoTjh2T0dHTlZ2TVduV3lh?=
 =?utf-8?B?T2ZWM0lRaHdLUDJvWUlwTzFnN2FPb0hiaXUvbU1uejNzaFlsUTNzREpOOVlj?=
 =?utf-8?B?L1dXYm4xR2RKVXd6cFdXZE5NejNoTGd5aXplNTRXQlBZQS9qUVJFWFFOcDZL?=
 =?utf-8?B?WVMrQXROYTIzZ0NkRG5PdG5EZFZ4dmpDWVZucmhyRU5RU24xcTFVa0NzbmhS?=
 =?utf-8?B?L0VWUnJBdVpCeFBaTVdsTnpMYUJuZzB6NmhuSVNLWU9QaHZZemJMUmpRNkI5?=
 =?utf-8?B?Zk1HcitKMTN1VUc0aG0reFBxVlZJSnBmanRnY3ZyLzVBY1VLOWZwaDdnQ2Qx?=
 =?utf-8?B?YndxNThuMVQyVHdSODVtRFFzWkQrUS9Kbis3RHYrbVJJRStOUjNKVDU3Z1Ex?=
 =?utf-8?B?Um8zaUsvVXBhdmgvNGZIenhxS0JvUzlZNEdreXpTRGhVSy9TM0JQbGI5TzRP?=
 =?utf-8?B?bzZ3WkV1MHg0dGsyUUdKSC90YXhsaGk0OHNSSDNVbXNGOVdsaVRuTmtYUDJ2?=
 =?utf-8?B?MUF3K2VzdndMNVREeWk1T3M1VmJHaHdyc1JBN1UwTU9EVHR0eVdjM1ZNUDZJ?=
 =?utf-8?B?cDdNRUwzR2Fhbjk3eVNSbzFJSzUrUlNmRVJDNHZhRVUzajR6RlJ3WVJ5Y0VS?=
 =?utf-8?B?UTIyaGc1Skw5VGxtanNpYng1Q2NDVmVxTHFBZ3E2Kzhud3hjMDFEZUl2SERB?=
 =?utf-8?Q?nZY4=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29fc4ae0-9960-4249-6340-08dc2bef42d4
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 17:22:59.8887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TeuV3eKIbQ/TbIYMmBJ0+Xi6dODsrptrfTLemPfpTOL9j8x+FxDohfqed0LpKqGB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6676

Hi Tony,

On 2/9/24 13:35, Tony Luck wrote:
> On Fri, Feb 09, 2024 at 09:29:16AM -0600, Moger, Babu wrote:
>>>  
>>> +extern unsigned int snc_nodes_per_l3_cache;
>>
>> I feel this can be part of rdt_resource instead of global.
> 
> Mixed emotions about that. It would be another field that appears
> in every instance of rdt_resource, but only used by the RDT_RESOURCE_L3_MON
> copy.
> 
That was the comment I got earlier for my patches(search for global).

https://lore.kernel.org/lkml/47f870e0-ad1a-4a4d-9d9e-4c05bf431858@intel.com/
-- 
Thanks
Babu Moger