Received-SPF: pass (google.com: domain of linux-kernel+bounces-62076-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <88fbd6ba-6118-4a80-980b-122dac5b4d39@amd.com>
Date: Mon, 12 Feb 2024 11:16:05 -0600
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v15-RFC 5/8] x86/resctrl: Add "NODE" as an option for
 resource scope
To: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
 Reinette Chatre <reinette.chatre@intel.com>,
 Peter Newman <peternewman@google.com>, Jonathan Corbet <corbet@lwn.net>,
 Shuah Khan <skhan@linuxfoundation.org>, x86@kernel.org,
 Shaopeng Tan <tan.shaopeng@fujitsu.com>, James Morse <james.morse@arm.com>,
 Jamie Iles <quic_jiles@quicinc.com>, Randy Dunlap <rdunlap@infradead.org>,
 Drew Fustini <dfustini@baylibre.com>, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org, patches@lists.linux.dev
References: <20240126223837.21835-1-tony.luck@intel.com>
 <20240130222034.37181-1-tony.luck@intel.com>
 <20240130222034.37181-6-tony.luck@intel.com>
 <6628954f-c7e9-4040-9f03-7b5b6a6d082d@amd.com>
 <ZcZ7wEUzESxUhs-y@agluck-desk3>
Content-Language: en-US
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <ZcZ7wEUzESxUhs-y@agluck-desk3>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UUtodlpqaUgyMnVZeFJ6bmJmbzd5L1hrdlRleE4rcGhJZXNnMVdqeWlLNkVz?=
 =?utf-8?B?ZDRuNjk3bEE1alRJQUxDM3k1K01xMGU4QTd4ckJnNW16ZzBuZ2Y3WGFCSzZ3?=
 =?utf-8?B?emJsK3EvcG44VERjaGlXUTVtS29oL0RHZEgxNjdKelgwclhTSTV6MmhiZGFB?=
 =?utf-8?B?dWkwV3JGTHJ3T3JOUVRpV1JIMGszcVdqS1hWdlJmLzVTVCtmZ0ZmL28rbll3?=
 =?utf-8?B?bithdEpZUENOYmU3RStVZ0llejIrbWFJaWR5VG5tWi9KajFjT1BWcld0bmlQ?=
 =?utf-8?B?V1UrdGJoQkI2c0JpRVZxZCtGUFB1TGdXY0t3UllqMEtBTVM4YURubDMyOG1W?=
 =?utf-8?B?cSszTk9OeEl4VUV2Si9LWFF2SDk3bk94bEw0WTNuTkRvUWIvZmxFUlBGdDhU?=
 =?utf-8?B?WHNXZmpYWXBaK3pDcXNFNS9EcnRRKzJqUFArWnBOUEhFdE1SMHJiRjJxY1Ft?=
 =?utf-8?B?UWpHREdxaHZQUlF2M0F5UHhiQ1prSW5zM3MyWVhuS2RkRkNocXJxN0d2eGR2?=
 =?utf-8?B?Y3hNM3RJL0tUTVNWbWRNdlQ4d245bUt2SlZ0MUFaMDFMbm5XbmRvdFdUYWJO?=
 =?utf-8?B?MUJYRGZQQTd2bThvVzl2SmZreEFXMjVrSVVzOG5vaFh4MDZSOHNXQmY4WVpI?=
 =?utf-8?B?TENYVG1KelQzQ1VVc3JtMEpIRDZLdFJNUjlEVXhBd1hZcWZDZzFxZ1JFM0dj?=
 =?utf-8?B?eGlPWitYTXJBaDdBdGdETHA0ekVrVFU3MkQwamJQcXdNSUVMbUVxUk85d09Y?=
 =?utf-8?B?dmVhVHJseFJWS0psbjRjVjBvdWNud0VGdFVhZEdlUysxZzFWc3hyL09iNFdD?=
 =?utf-8?B?alg2dk5GYjZNd1VUWlQrSkNiTy9MSDU4dGJuaGdTTmlFSmF1YURCQ0ZPeU5M?=
 =?utf-8?B?bDdmaHRsRWRxQ0p2dENWSjNVRFRXUjl2endQOXZoY213ZEF2N2xyY2VvZkEx?=
 =?utf-8?B?dEdLNHIvQXhLYmNWTFlIc0tMczVVTTB0bWk5dWU4YVQ5TXRtK3N3SzJoWHdP?=
 =?utf-8?B?N3d3RHdPc1VDYnY2Z2l2YndZWjRLT2R0ZTJKdGV1ck5qblZ0a0RpS0lHR1Rr?=
 =?utf-8?B?NVQvZ2JnVk9PVUNCZnllU3o2SzdnQjB2UXd0aU9tOUVyOEl6VEYwcHdnRnRs?=
 =?utf-8?B?LzZocUpzNXEzc0FuSE02dVFnRzI3aEUyOXQ0bHJMUVhZSGlQeG0zWHpmT2FT?=
 =?utf-8?B?Ynhud2dBVmtaZUdMcExiUk1EdzQrTnBUME83VTlKbytvN2ppUTNxM0lwTWYy?=
 =?utf-8?B?ODdneUpyOVVpZkhUWFNjUTIraTF5bThtVlFRVk9pSEF3Wkx1NG5FNVJ5U2dy?=
 =?utf-8?B?RnVMSVdMbHc5YWFRdFdIV2htZlJBbDdYMHNoSzRMTkl4bnROUXdYVHhjeHBT?=
 =?utf-8?B?aDZKandQYktoRUdzMmZ2Yy9qaWZOSDRmbHZSR1RGdmRLM3NsRy85K21MZFJo?=
 =?utf-8?B?QS8vYXBKZXVpRi9URVdYYmdNcVhNNGlXak1Ed0F0RjEyR20xZGR4ZXdMS3VU?=
 =?utf-8?B?eEYzbVVhb1BQcng4SUl4Rm1VMTMxbUtRSEtVTTV6dXJmdVhtYTA3aUVvaFhI?=
 =?utf-8?B?NXVzcnJwMFF0c3E2LzFjRmwvN0RIUkhlbk1nM2VmWUVRR1JjeFhsQzhUa3Bi?=
 =?utf-8?B?YUw0NHkvR3lpU3NNUzZseHpKbnF5YnRsSGIzZS9VQlJ4dWZyYzA3Vk9CZXhy?=
 =?utf-8?B?aHAvbTV6bGRGQ1JhNXZ0U2dWTTE2Ym4rd1h1bjd3Z2FpbTE4ZHdiVm5ZenhG?=
 =?utf-8?B?VEN5aUNiWDdPRUZzektwRGpIcU1FbnA4VmNkNkpPNnF5QjFiQXIxMnA4WDNv?=
 =?utf-8?B?U3diNWpSUXNvKzBvWjdPMDVTR0FpRjRETzJGa3BSWTc4R3pucmJMRG9UWFpo?=
 =?utf-8?B?SGtLUHZjVDBwLzViMWtWdnljUWx1bE55di9RQjlyWFRtZlRERnEwR2MyaGZ4?=
 =?utf-8?B?MElvS01jZzMrdFovbzREODJhaFRkNyt0cCtwNzVnSmJaUFRnMzlaQ0FQN0xU?=
 =?utf-8?B?K2E1OWVCVEJhc2NvNUFyT1psNU92SUhEUVhhSmpSL0NWc21peFNNOVhMZ3FV?=
 =?utf-8?B?SFE5WS9JVEJmN051YVF2b3Jiamprb0dTV0gxeURqYU43RjlqL0M5NjNYRFh1?=
 =?utf-8?Q?3/Qw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17f19952-54f4-41d2-b666-08dc2bee4e11
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 17:16:09.3613
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tPBb1bKRs04CHn5DhqtORgP+i1ALm4PLFO4FIakMiKtJG7GTpG2uBbhm16/CwOi0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8121

Hi Tony,

On 2/9/24 13:23, Tony Luck wrote:
> On Fri, Feb 09, 2024 at 09:29:03AM -0600, Moger, Babu wrote:
>> Hi Tony,
>>
>> This patch probably needs to be merged with with patch 7.
> 
> If it just added RESCTRL_NODE to the enum and the switch() I'd
> agree (as patch 7 is where RESCTRL_NODE first used). But this
> patch also adds the sanity checks on scope where it has to be
> a cache level.
> 
> Patch 7 is already on the big side (119 lines added to core.c).
> 
> If you really think this series needs to cut back the
> number of patches, I could move the sanity check pieces
> from here to patch 3 (where the enum is introduced) and
> just the RESCTRL_NODE bits to patch 7.

No. You dont have to cut back on number of patches. I think it is easy to
review if these changes are merged with patch 7.


-- 
Thanks
Babu Moger