Received-SPF: pass (google.com: domain of linux-kernel+bounces-62128-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <989fa518-4f02-4725-97a4-2f711126939d@quicinc.com>
Date: Mon, 12 Feb 2024 09:47:09 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] soc: qcom: llcc: Check return value on Broadcast_OR
 reg read
Content-Language: en-US
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
        Bjorn Andersson
	<andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Abel Vesa
	<abel.vesa@linaro.org>
CC: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel@quicinc.com>, Elliot Berman <quic_eberman@quicinc.com>
References: <20240210011415.3440236-1-quic_uchalich@quicinc.com>
 <cfc42c1f-ff17-4d66-8e88-cbd4230e7d7b@quicinc.com>
From: Unnathi Chalicheemala <quic_uchalich@quicinc.com>
In-Reply-To: <cfc42c1f-ff17-4d66-8e88-cbd4230e7d7b@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 2/9/2024 5:30 PM, Jeff Johnson wrote:
> On 2/9/2024 5:14 PM, Unnathi Chalicheemala wrote:
>> Commit c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
>> introduced a new 4.1 if statement in llcc_update_act_ctrl() without
>> considering that ret might be overwritten. So, adding return value check
> 
> nit: s/adding/add/ (use imperative voice)
> 

Ack.

>> after Broadcast_OR register read in llcc_update_act_ctrl().
>>
>> Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support">
> 
> remove this blank line -- the Fixes tag should be grouped with the other
> tags
> 

Ack. I'll post v3 with these changes, thanks Jeff.

>> Signed-off-by: Unnathi Chalicheemala <quic_uchalich@quicinc.com>
>> Reviewed-by: Elliot Berman <quic_eberman@quicinc.com>