Received-SPF: pass (google.com: domain of linux-kernel+bounces-62177-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240212163510.859822-1-zi.yan@sent.com> <20240212163510.859822-4-zi.yan@sent.com>
In-Reply-To: <20240212163510.859822-4-zi.yan@sent.com>
From: Yu Zhao <yuzhao@google.com>
Date: Mon, 12 Feb 2024 11:27:38 -0700
Message-ID: <CAOUHufYz2P8w_kqxSjmOghbEG8CZmO2cfb4UzP7dkduBQbHhQw@mail.gmail.com>
Subject: Re: [PATCH v4 3/3] mm/compaction: optimize >0 order folio compaction
 with free page split.
To: Zi Yan <ziy@nvidia.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, 
	"Huang, Ying" <ying.huang@intel.com>, Ryan Roberts <ryan.roberts@arm.com>, 
	Andrew Morton <akpm@linux-foundation.org>, "Matthew Wilcox (Oracle)" <willy@infradead.org>, 
	David Hildenbrand <david@redhat.com>, "Yin, Fengwei" <fengwei.yin@intel.com>, 
	Vlastimil Babka <vbabka@suse.cz>, "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>, 
	Johannes Weiner <hannes@cmpxchg.org>, Baolin Wang <baolin.wang@linux.alibaba.com>, 
	Kemeng Shi <shikemeng@huaweicloud.com>, Mel Gorman <mgorman@techsingularity.net>, 
	Rohan Puri <rohan.puri15@gmail.com>, Mcgrof Chamberlain <mcgrof@kernel.org>, 
	Adam Manzanares <a.manzanares@samsung.com>, "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 12, 2024 at 9:35=E2=80=AFAM Zi Yan <zi.yan@sent.com> wrote:
>
> From: Zi Yan <ziy@nvidia.com>
>
> During migration in a memory compaction, free pages are placed in an arra=
y
> of page lists based on their order.  But the desired free page order
> (i.e., the order of a source page) might not be always present, thus
> leading to migration failures and premature compaction termination.  Spli=
t
> a high order free pages when source migration page has a lower order to
> increase migration successful rate.
>
> Note: merging free pages when a migration fails and a lower order free
> page is returned via compaction_free() is possible, but there is too much
> work.  Since the free pages are not buddy pages, it is hard to identify
> these free pages using existing PFN-based page merging algorithm.
>
> Signed-off-by: Zi Yan <ziy@nvidia.com>
> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Tested-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> Cc: Adam Manzanares <a.manzanares@samsung.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Huang Ying <ying.huang@intel.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Kemeng Shi <shikemeng@huaweicloud.com>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
> Cc: Mel Gorman <mgorman@techsingularity.net>
> Cc: Ryan Roberts <ryan.roberts@arm.com>
> Cc: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Yin Fengwei <fengwei.yin@intel.com>
> Cc: Yu Zhao <yuzhao@google.com>
> ---
>  mm/compaction.c | 36 +++++++++++++++++++++++++++++++-----
>  1 file changed, 31 insertions(+), 5 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index d0a05a621b67..25908e36b97c 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1832,15 +1832,41 @@ static struct folio *compaction_alloc(struct foli=
o *src, unsigned long data)
>         struct compact_control *cc =3D (struct compact_control *)data;
>         struct folio *dst;
>         int order =3D folio_order(src);
> +       bool has_isolated_pages =3D false;
> +       int start_order;
> +       struct page *freepage;
> +       unsigned long size;
> +
> +again:
> +       for (start_order =3D order; start_order < NR_PAGE_ORDERS; start_o=
rder++)
> +               if (!list_empty(&cc->freepages[start_order]))
> +                       break;
>
> -       if (list_empty(&cc->freepages[order])) {
> -               isolate_freepages(cc);
> -               if (list_empty(&cc->freepages[order]))
> +       /* no free pages in the list */
> +       if (start_order =3D=3D NR_PAGE_ORDERS) {
> +               if (!has_isolated_pages) {
> +                       isolate_freepages(cc);
> +                       has_isolated_pages =3D true;
> +                       goto again;
> +               } else
>                         return NULL;

Nit: remove the "else" above, or just:

        if (has_isolated_pages)
                return NULL;
        isolate_freepages(cc);
        has_isolated_pages =3D true;
        goto again;