Received-SPF: pass (google.com: domain of linux-kernel+bounces-62180-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Zi Yan <ziy@nvidia.com>
To: Yu Zhao <yuzhao@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 "\"Huang, Ying\"" <ying.huang@intel.com>,
 Ryan Roberts <ryan.roberts@arm.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
 David Hildenbrand <david@redhat.com>,
 "\"Yin, Fengwei\"" <fengwei.yin@intel.com>, Vlastimil Babka <vbabka@suse.cz>,
 "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
 Johannes Weiner <hannes@cmpxchg.org>,
 Baolin Wang <baolin.wang@linux.alibaba.com>,
 Kemeng Shi <shikemeng@huaweicloud.com>,
 Mel Gorman <mgorman@techsingularity.net>,
 Rohan Puri <rohan.puri15@gmail.com>, Mcgrof Chamberlain <mcgrof@kernel.org>,
 Adam Manzanares <a.manzanares@samsung.com>,
 "\"Vishal Moola (Oracle)\"" <vishal.moola@gmail.com>
Subject: Re: [PATCH v4 3/3] mm/compaction: optimize >0 order folio compaction
 with free page split.
Date: Mon, 12 Feb 2024 13:29:38 -0500
Message-ID: <7026A932-5750-4CFD-B370-80A46E47434E@nvidia.com>
In-Reply-To: <CAOUHufYz2P8w_kqxSjmOghbEG8CZmO2cfb4UzP7dkduBQbHhQw@mail.gmail.com>
References: <20240212163510.859822-1-zi.yan@sent.com>
 <20240212163510.859822-4-zi.yan@sent.com>
 <CAOUHufYz2P8w_kqxSjmOghbEG8CZmO2cfb4UzP7dkduBQbHhQw@mail.gmail.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_1E7BBDBC-5FBD-42DE-9213-BB83A3F74918_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V2FhREtqMmF4RVdNUnQ1T1Aza3kzaFNUV0E3NStid0JkUjFSYzhBV21MK1lM?=
 =?utf-8?B?VldaekxxWXNENWQ0ckNFMjlNRDA2Mk9tTEoreE9sT0VxY3RtSHFyMEd1eEw2?=
 =?utf-8?B?S3pzcFRkK3R3TUZkY3E1TkZNVmF4eVkwa3U5UGJ5MktSMzcrQ1c2dmNVSC8y?=
 =?utf-8?B?T1c5WVZzbm9xcE9ZUVkxZ0x0WlZlU2Fya25xSVhkd3JybUlPSUc1ZlFtM0Jl?=
 =?utf-8?B?aGtwanhZaVB2aGxzZ1h5T2doSW5WZnB6ZEEwS0N4VkhubzJSb0JubDI2TFY3?=
 =?utf-8?B?bDg4UTFaZjQvQ2xyMGIxN3FmYUxMaHVjYzF1L0F1NXNJTUNUM3FiRHNWWUha?=
 =?utf-8?B?QXNsdStmZm9XcXY1OFdkcDdrYzljSlFUWDJkZ0hMRGJLb1RRSXgzbm0wemdm?=
 =?utf-8?B?Z1pNVWEvU2hvRW5LNDliNDhZU3BiUkhqTzA3ZVVIbWsrM1NRREZ0c2xzbnRj?=
 =?utf-8?B?Vzdmc0xMem5xYlJIaldrQVZMT1B3ZmI5aTBIRXJnRDdDcDJiaGxXS01JbjBi?=
 =?utf-8?B?MDg3SFRjWW1XUUpqallNaStsb1BIZjVOdjA1Y3RXQ29Ic0tubWkyeGtEb1B0?=
 =?utf-8?B?bEVHQmgwNnY4VWlocHVXTDcyaVVCck9BL0Q1TmUrMkkzbXBHVEVqek5PbjFo?=
 =?utf-8?B?ekVnVjVuNk15QTc5SG1iRUR0TjdTa3lpbHVta2xWUk5TbnREazlHMDhOYU9Q?=
 =?utf-8?B?TnpjaGpMeERjb1FsczlDV01WaUgvd0N2ekJSNmJ3cUl1Sko0OTQxcGxYVy9u?=
 =?utf-8?B?NlhMenlGVEo4eS93MmFJNllCU1VLLzdMOE5MaU92cEIvR0FtYXBpYVFSWnV6?=
 =?utf-8?B?QlFGWjlzbDVTeFNOSW1IRERVcTFJbm10UmYwNmY4T2JhWTVwcEpzcUU4UDRO?=
 =?utf-8?B?MERQam9icmVqdFFDYjJVMkxqY3o0Si84Nk5Ccm9vOTBsb2h5RFcxTmVON2hh?=
 =?utf-8?B?SG1VRHJ6YW95eC9MMlFkQ1owd1plc1BUbDhKaDdROStuK2hHNzFoZUxHYm90?=
 =?utf-8?B?eUR4bG03QmoxLzRrRDNoSjZBY2xSWVVGbExTdXVWWGJYT0RaZEVyd3FyMGhZ?=
 =?utf-8?B?UCtoODNPM1UxZFcxbzZiUUhhbjg5b2s5Y0tBcVcwcDZ6M0dwSWlWUUdsMEV2?=
 =?utf-8?B?aUxZKzdPbU1DS0lLTDBmRndNVDN5RHBuWkZIT1d0Tk80VUtML09RWUNHQzR5?=
 =?utf-8?B?NytqMWhTckIwZVNRZGtLTGJYSm5jbTR0b0ZoVEZvREJ6dHZxRVE0ZE9pRmhi?=
 =?utf-8?B?UnhMYXd0Ly9KY3I1c3g0S1UzaGNCVUJyaEh2UlQwU1RraVd5UjBxY0plb2Zr?=
 =?utf-8?B?RVU1M3VaTWIxaElFZWtUM24vWVltU2cwdTRGNm9scFNGYVFtYlYxS2xZTXNh?=
 =?utf-8?B?eU56ZU9haHJQb2tsN2JoRkp1cnN3QjQzeWZRU2ZGbmdSVFNtSDhCbzd5Y1Ey?=
 =?utf-8?B?TzRDcVpveWk5UFNqTWJ0WnZjQkxMenlWbUpic1RvNWFDN2pGMjMwOFRCaW5v?=
 =?utf-8?B?bUhSQWNZemlvWjRoYnNwN2o5YmNHVGRheU9jdEY5UzlPa0lKSnRWOTV5eWNV?=
 =?utf-8?B?S2s3RSs1WGJVd3lDc09ONU1xcGFzUjg3cUVudFUrZjU4VWFHNTg0ZDB6Z05M?=
 =?utf-8?B?NlRFZU56OHdFM0VUUHAyb3VzZW1qZnZnMElKc0J1NzJCa2x6OUJzdXdaT1M1?=
 =?utf-8?B?blFGeklVV2JPVFliaDh4WGFGZVJDWVRxZktkUGlvc1B3a3dJNDRCeFB3ekts?=
 =?utf-8?B?WVZBSkd6Q2xNdHoxRzlvdmdQT29NWTZZL0ZFQVFnMXIxcXBPNDBCekZOM3Vp?=
 =?utf-8?B?M1d5NE9TeXB3M2dSdmI5TUtYWnJiOFhWUUVYWVhFYlNWZndVQ2Mzd1QvSWpi?=
 =?utf-8?B?SXc2b1UvS2FNd1lBcVNKWldWZ2cybjVERWJCQ0xrcEVVb2hMSU5ZQUxyL2VU?=
 =?utf-8?B?bldPTEpwcjRHVHVGSWlVUHh0ZWxmY0ZHQklIT05WelFObjRzN2xYRnQwUVg3?=
 =?utf-8?B?Rll4V3ZxV3NkUVZlYy9ZcUFDQ0FmK0gwc1NtMzc4eXBCSy9CZWcvVGF3bzc1?=
 =?utf-8?B?ekhBMkFMQVhHbWtQTGdwQlJVMFg5eXp2ODlsT0ZYc01EVnRucGhGcVAvL09L?=
 =?utf-8?Q?bORO+8OP7mDpY2mtSMupMcOns?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78655759-4e42-418f-6b80-08dc2bf89418
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 18:29:41.8039
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8QiH4qRzmLkHkQpO0QrJkrqIVTUNUPFt6anXs+GCdI+ZEiPYXKtC/y/upxi1CK9e
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9214

--=_MailMate_1E7BBDBC-5FBD-42DE-9213-BB83A3F74918_=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 12 Feb 2024, at 13:27, Yu Zhao wrote:

> On Mon, Feb 12, 2024 at 9:35=E2=80=AFAM Zi Yan <zi.yan@sent.com> wrote:=

>>
>> From: Zi Yan <ziy@nvidia.com>
>>
>> During migration in a memory compaction, free pages are placed in an a=
rray
>> of page lists based on their order.  But the desired free page order
>> (i.e., the order of a source page) might not be always present, thus
>> leading to migration failures and premature compaction termination.  S=
plit
>> a high order free pages when source migration page has a lower order t=
o
>> increase migration successful rate.
>>
>> Note: merging free pages when a migration fails and a lower order free=

>> page is returned via compaction_free() is possible, but there is too m=
uch
>> work.  Since the free pages are not buddy pages, it is hard to identif=
y
>> these free pages using existing PFN-based page merging algorithm.
>>
>> Signed-off-by: Zi Yan <ziy@nvidia.com>
>> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>> Tested-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>> Cc: Adam Manzanares <a.manzanares@samsung.com>
>> Cc: David Hildenbrand <david@redhat.com>
>> Cc: Huang Ying <ying.huang@intel.com>
>> Cc: Johannes Weiner <hannes@cmpxchg.org>
>> Cc: Kemeng Shi <shikemeng@huaweicloud.com>
>> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>> Cc: Luis Chamberlain <mcgrof@kernel.org>
>> Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
>> Cc: Mel Gorman <mgorman@techsingularity.net>
>> Cc: Ryan Roberts <ryan.roberts@arm.com>
>> Cc: Vishal Moola (Oracle) <vishal.moola@gmail.com>
>> Cc: Vlastimil Babka <vbabka@suse.cz>
>> Cc: Yin Fengwei <fengwei.yin@intel.com>
>> Cc: Yu Zhao <yuzhao@google.com>
>> ---
>>  mm/compaction.c | 36 +++++++++++++++++++++++++++++++-----
>>  1 file changed, 31 insertions(+), 5 deletions(-)
>>
>> diff --git a/mm/compaction.c b/mm/compaction.c
>> index d0a05a621b67..25908e36b97c 100644
>> --- a/mm/compaction.c
>> +++ b/mm/compaction.c
>> @@ -1832,15 +1832,41 @@ static struct folio *compaction_alloc(struct f=
olio *src, unsigned long data)
>>         struct compact_control *cc =3D (struct compact_control *)data;=

>>         struct folio *dst;
>>         int order =3D folio_order(src);
>> +       bool has_isolated_pages =3D false;
>> +       int start_order;
>> +       struct page *freepage;
>> +       unsigned long size;
>> +
>> +again:
>> +       for (start_order =3D order; start_order < NR_PAGE_ORDERS; star=
t_order++)
>> +               if (!list_empty(&cc->freepages[start_order]))
>> +                       break;
>>
>> -       if (list_empty(&cc->freepages[order])) {
>> -               isolate_freepages(cc);
>> -               if (list_empty(&cc->freepages[order]))
>> +       /* no free pages in the list */
>> +       if (start_order =3D=3D NR_PAGE_ORDERS) {
>> +               if (!has_isolated_pages) {
>> +                       isolate_freepages(cc);
>> +                       has_isolated_pages =3D true;
>> +                       goto again;
>> +               } else
>>                         return NULL;
>
> Nit: remove the "else" above, or just:
>
>         if (has_isolated_pages)
>                 return NULL;
>         isolate_freepages(cc);
>         has_isolated_pages =3D true;
>         goto again;

Will do. Thanks.

--
Best Regards,
Yan, Zi

--=_MailMate_1E7BBDBC-5FBD-42DE-9213-BB83A3F74918_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXKY5MPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUsIAP/RqGJ9+gFo9jGU0wF5yn9bfE0qvreZ1r5C+s
P9HL+0WYqk5rCakXbCJQkTmKcpadf/F+0VYD8tjM+hYDtPJteZCSu9UvsB9cTahz
kU/57uQ8xqvhjfnWflrn9bqeW011BAADUvOoYITiYGPFZ4zJJx2Zt4LzvBlqT14C
e7Sfx6cFlKf2pATZNH1QgNFPRmQhif8gXNLWBhxz5kCwjR/ZZ0W9GxELZJLOOtlU
a3hELvbPTUVm1fMFXc52NNRdWvfJOb4ffisBGvXQAIvCkA8Lkwx6eBQZ2oVbHRyh
p8izFFgDe3ayHJ+cvuau+Aj3y4wN0IMeAUnV9SYKOwvadOS5ieZB58Wa+hUUpE4F
4QND2Tt7ssqBb0IxTe/muFt5WsXAX8A4ccNc/tFiRkfn8cGUC/JogspTCsKXRm64
Nl8aLj5n95D7Zb+cg6kuQA0orbG1ukeGligOp55JF3cDXQs271GXb8rU3cjnCuam
QIr1WqzYbJ3XNwzcS+03x+VGTuGvIdlmeV+wpwiy7688167+Ve+Uy5xu2SrMH4ne
FlL2F2llL1R8vlC8eaK92TvY0ydikZAYZbLb080mIWlIeSR0ATz/H7v+1sJhuZjk
0RSddKiztUTZ5bBgVEN+1jnOHi/aqqsAQy6OenPb5lZF8vGNqZk+hKrceU41WhdM
oHPcdrPQ
=/7Qn
-----END PGP SIGNATURE-----

--=_MailMate_1E7BBDBC-5FBD-42DE-9213-BB83A3F74918_=--