Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755218AbXLWJcx (ORCPT ); Sun, 23 Dec 2007 04:32:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752156AbXLWJcq (ORCPT ); Sun, 23 Dec 2007 04:32:46 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:38517 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007AbXLWJcp (ORCPT ); Sun, 23 Dec 2007 04:32:45 -0500 Date: Sun, 23 Dec 2007 09:32:41 +0000 From: Al Viro To: clameter@sgi.com Cc: Linus Torvalds , linux-kernel@vger.kernel.org Subject: tlb_finish_mmu() bogisity Message-ID: <20071223093241.GR8181@ftp.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 597 Lines: 12 tlb->need_flush += &__get_cpu_var(quicklist)[0].nr_pages != 0; makes no sense whatsoever. How the hell can you ever get the address of __get_cpu_var(quicklist)[0].nr_pages to be NULL? Postfix operators have higher precedence than prefix ones, so that's &(((__get_cpu_var(quicklist))[0]).nr_pages) What did you intend here? s/&//, perhaps? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/