Received-SPF: pass (google.com: domain of linux-kernel+bounces-62207-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Kees Cook <keescook@chromium.org>
To: Tycho Andersen <tycho@tycho.pizza>,
	Arnd Bergmann <arnd@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] samples: user-trap: fix strict-aliasing warning
Date: Mon, 12 Feb 2024 10:42:27 -0800
Message-Id: <170776334482.2557794.95461406898503535.b4-ty@chromium.org>
In-Reply-To: <20240212111737.917428-1-arnd@kernel.org>
References: <20240212111737.917428-1-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Mon, 12 Feb 2024 12:17:31 +0100, Arnd Bergmann wrote:
> I started getting warnings for this one file, though I can't see what changed
> since it was originally introduced in commit fec7b6690541 ("samples: add an
> example of seccomp user trap").
> 
> samples/seccomp/user-trap.c: In function 'send_fd':
> samples/seccomp/user-trap.c:50:11: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
>    50 |         *((int *)CMSG_DATA(cmsg)) = fd;
>       |          ~^~~~~~~~~~~~~~~~~~~~~~~
> samples/seccomp/user-trap.c: In function 'recv_fd':
> samples/seccomp/user-trap.c:83:18: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
>    83 |         return *((int *)CMSG_DATA(cmsg));
>       |                 ~^~~~~~~~~~~~~~~~~~~~~~~
> 
> [...]

Applied to for-next/seccomp, thanks!

[1/1] samples: user-trap: fix strict-aliasing warning
      https://git.kernel.org/kees/c/9ad28ca5238d

Take care,

-- 
Kees Cook