Received-SPF: pass (google.com: domain of linux-kernel+bounces-62173-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 12 Feb 2024 10:26:03 -0800
From: Kees Cook <keescook@chromium.org>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	kernel test robot <lkp@intel.com>, Rich Felker <dalias@libc.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nicolas Schier <n.schier@avm.de>, linux-sh@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] sh: Fix build with CONFIG_UBSAN=y
Message-ID: <202402121025.B0B6E47@keescook>
References: <20240130232717.work.088-kees@kernel.org>
 <494586ed5a0871cf7cfd005f513577952306a0bc.camel@physik.fu-berlin.de>
 <fe057f57aba0f8a9040d4700d27f5bd478032925.camel@physik.fu-berlin.de>
 <202402020228.BBEF7DAC@keescook>
 <9fda57fc1b1ba6ad9bd6f7df3fb12674d0f4f940.camel@physik.fu-berlin.de>
 <cd1a36a234c8fc61c5febe646ae0f05ed20ae32a.camel@physik.fu-berlin.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cd1a36a234c8fc61c5febe646ae0f05ed20ae32a.camel@physik.fu-berlin.de>

On Sun, Feb 11, 2024 at 11:39:49AM +0100, John Paul Adrian Glaubitz wrote:
> Hi Kees,
> 
> On Fri, 2024-02-02 at 12:06 +0100, John Paul Adrian Glaubitz wrote:
> > > When I use GCC 13.2 (I'm specifically on Ubuntu 23.10) and the randconfig
> > > linked from the report:
> > > https://download.01.org/0day-ci/archive/20240131/202401310416.s8HLiLnC-lkp@intel.com/config
> > > (which is notably enabling CONFIG_UBSAN=y and CONFIG_UBSAN_SHIFT=y) then I
> > > see at the final link stage:
> > > 
> > > /usr/bin/sh4-linux-gnu-ld: arch/sh/boot/compressed/misc.o: in function `zlib_inflate_table':
> > > misc.c:(.text+0x650): undefined reference to `__ubsan_handle_shift_out_of_bounds'
> > > ...
> > > 
> > > After the patch, it's solved.
> > 
> > OK, let me test with gcc 13.x. My build host is currently running openSUSE Leap 15.5.
> 
> I just wanted to try reproduce the problem again with the reproducer in [1] as well
> as with gcc-13.2.0, but your branch devel/overflow/ubsan-only no longer exists.
> 
> Can you tell me where to find the patches now?

Sure, they're in -next, but for an -rc2 based tree, see:
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/kspp

-- 
Kees Cook