Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2633655rdb; Mon, 12 Feb 2024 10:58:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGaWUC1kENB3DUi02ikLuEHMu1ZwFANHng6iXOYS6DGkK3AR84yN4VhSse3rU9uvJ1o6Cs X-Received: by 2002:a05:622a:1752:b0:42c:6ade:d107 with SMTP id l18-20020a05622a175200b0042c6aded107mr8086619qtk.4.1707764290488; Mon, 12 Feb 2024 10:58:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707764290; cv=pass; d=google.com; s=arc-20160816; b=QMDkQkZv2gvy5XB52BM41CgedbV8s6x9SihjOPoUNXw2KQ1iICiKckZ10Ox9K/x3zU FVVNZIqi4tEoxAMwPmZHR9IqExNMPSMvWVdfOKuSchi7fPeXsTDIKiBcrLHQX9YwQNxB VF9gXI5ekJexKZ/dJDF5K4FRvkLI+gkWPa8UJLSMom1ElsOwM7YUkqovoUDy8tIx0r9C OASgNe1TG+Evqu04FEsbYyofe6LJEGwwih0HhQzs9XQTiGtd73ONKg/JwcM+Y5oYq4Fd 7QRgUaouiHodqklKtSLFnsupI0R0Jcom1VeAIPdXMcDbfAJ0nS8cD7Lb5M0qE83LVkAZ iaaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from; bh=HQjWjjiZvKMzKWleoPOFTcgyRb222Axt5C0dg0C6fqI=; fh=xo7eVmlo6TR86XaMrAfUe4ztDfdKTc0nmk9ghCpML2U=; b=wsFoW9aG+Ri5Jg97fsrn/q3E+TKTq4tR65bNgHQGn22+9Yfi1o70kj0avlCqnMWThq Bog+CzeN/d/WomXB+OTJVShl4i3rPwt5qF55O8PKbRgAHzPE7D0bmiYQ8LNYy2PgTXBc cPmQ/5Yr3KVmcTwdRhTJYFfJ3YwSn8Mc3MFLiSMiq/maKOq/gyXgn+4yNSpMzcrVvNAY VTKZB5Sqjgs6dcSMG15v22IK/MDk0WViZ1r58ocVI8zYUSFi6Hrm7HHoc+vMVOHlSxfR LcwkEJ8c/UfYjF8WNd4WQzMiJJQA/vC1HzBnX75as2WFTXDVFguljf1qJ6hvTPAoVOCw hDlw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=etezian.org); spf=pass (google.com: domain of linux-kernel+bounces-62237-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62237-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUjtumhgOXrr8LaHWexNFwAM/ppptXn5wzwNqK0eiq/dGWx5BsI0nOTOLcOxzinsDxWb3nUJz2COnJ5i8Th09/3OSvvDHFju4nsC9kqNQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id q13-20020a05622a030d00b0042c72478d20si1166300qtw.70.2024.02.12.10.58.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 10:58:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62237-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=etezian.org); spf=pass (google.com: domain of linux-kernel+bounces-62237-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62237-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3F1EB1C22674 for ; Mon, 12 Feb 2024 18:58:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4B77645018; Mon, 12 Feb 2024 18:58:04 +0000 (UTC) Received: from 3.mo576.mail-out.ovh.net (3.mo576.mail-out.ovh.net [188.165.52.203]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09B7341233 for ; Mon, 12 Feb 2024 18:58:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.165.52.203 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707764283; cv=none; b=U2ISnuru999kzobsZA56CA9TOQ10DlYMxuZrrOIcyDDUpP0ZGVHqK4UXR/hV+m8D8UI9mIyhYjINEXK547RiGuztiMXUADdurEOI77EJDguXVfwwY9BiWGHHN/OlfMlPmFD9o9Hr6h6seKbJKYwVq7aMokr5q7AHmScHQlG47qI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707764283; c=relaxed/simple; bh=jO/LDfn6aDcYiqRM9lNKahIwQkbLK8dKdTIoaO+VCXE=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=SklZADKJitNd9oFMBtbezIp0tcVPf/+GSyyF8aAO8Q+4ttMv1iyuLGyHUDYsm58jDYDVIkKDI2jO4nBMit+NDTvS4tnAcV0KcRj1xNv0fipgwMxn9dnPuNeeGl94LaFfnaEk7jyAIyJGQAH+HbJ2XVFJvbP32gTnorEMQ816+yw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=etezian.org; arc=none smtp.client-ip=188.165.52.203 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etezian.org Received: from director10.ghost.mail-out.ovh.net (unknown [10.108.2.160]) by mo576.mail-out.ovh.net (Postfix) with ESMTP id 4TYVLY5xLbz1Tyb for ; Mon, 12 Feb 2024 16:30:29 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-r9552 (unknown [10.110.96.92]) by director10.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 5F6291FD3F; Mon, 12 Feb 2024 16:30:27 +0000 (UTC) Received: from etezian.org ([37.59.142.95]) by ghost-submission-6684bf9d7b-r9552 with ESMTPSA id 6FC5CKNHymUtFhgA7JOU9g (envelope-from ); Mon, 12 Feb 2024 16:30:27 +0000 Authentication-Results:garm.ovh; auth=pass (GARM-95G0010dc3974b-9b21-4c2d-b831-50956c5a016a, DC9C46711153F1AB5CCD62E60A4660431976F56E) smtp.auth=andi@etezian.org X-OVh-ClientIp:89.217.109.169 From: Andi Shyti To: andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, quic_bjorande@quicinc.com, manivannan.sadhasivam@linaro.org, bryan.odonoghue@linaro.org, dmitry.baryshkov@linaro.org, Viken Dadhaniya Cc: quic_msavaliy@quicinc.com, quic_vtanuku@quicinc.com In-Reply-To: <20240212125239.7764-1-quic_vdadhani@quicinc.com> References: <20240212125239.7764-1-quic_vdadhani@quicinc.com> Subject: Re: [PATCH v4] i2c: i2c-qcom-geni: Correct I2C TRE sequence Message-Id: <170775542582.4034843.13903178827406662061.b4-ty@kernel.org> Date: Mon, 12 Feb 2024 17:30:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.4 X-Ovh-Tracer-Id: 5162532548027026139 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrudefgdekkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvvegjfhfukfffgggtgffosehtjeertdertdejnecuhfhrohhmpeetnhguihcuufhhhihtihcuoegrnhguihdrshhhhihtiheskhgvrhhnvghlrdhorhhgqeenucggtffrrghtthgvrhhnpeffteehudffvdfhudfgffdugfejjeduheehgeefgeeuhfeiuefghffgueffvdfgfeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecukfhppeduvdejrddtrddtrddupdekledrvddujedruddtledrudeiledpfeejrdehledrudegvddrleehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeorghnughisegvthgviihirghnrdhorhhgqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdpoffvtefjohhsthepmhhoheejiedpmhhouggvpehsmhhtphhouhht Hi On Mon, 12 Feb 2024 18:22:39 +0530, Viken Dadhaniya wrote: > For i2c read operation in GSI mode, we are getting timeout > due to malformed TRE basically incorrect TRE sequence > in gpi(drivers/dma/qcom/gpi.c) driver. > > I2C driver has geni_i2c_gpi(I2C_WRITE) function which generates GO TRE and > geni_i2c_gpi(I2C_READ)generates DMA TRE. Hence to generate GO TRE before > DMA TRE, we should move geni_i2c_gpi(I2C_WRITE) before > geni_i2c_gpi(I2C_READ) inside the I2C GSI mode transfer function > i.e. geni_i2c_gpi_xfer(). > > [...] Applied to i2c/i2c-host-fixes on git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git Thank you, Andi Patches applied =============== [1/1] i2c: i2c-qcom-geni: Correct I2C TRE sequence commit: 32e9b680de4b46cfe835cbc7ee3dc721f7cc65fb