Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2642099rdb; Mon, 12 Feb 2024 11:13:27 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXaoKpaE05E2t1KPLt89Z3iPwdsZQaI7mB531+Dvvo4DChCR16PUrS6uJr+Rv7jJFl2+voj37y9U/ytTG1JzS4KGIMmZfilmO6V6Qusyg== X-Google-Smtp-Source: AGHT+IEyOnNa5K4mEo2jNzasUPNScPLiH/p1LZdDxgjvyJ5G9jFde1akH1x4IM1sAGhDClKGo5gt X-Received: by 2002:a17:906:7d8e:b0:a3b:ff60:a242 with SMTP id v14-20020a1709067d8e00b00a3bff60a242mr312270ejo.34.1707765207434; Mon, 12 Feb 2024 11:13:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707765207; cv=pass; d=google.com; s=arc-20160816; b=YoWVPadHgyHWrjyjzH4QiYLKK6wkwZoRh+p4Pr6reMk+7nsN8whK1U5knDVu9JBzJJ Tz5skzBZYDfwcGTrH2GMU3aFDfqgt8z0ZhqkkNAf4sYqyDz2cxqoJvEgHpGOkyXaPpwX gPtpL207zXcqhGlrIGTsaUdNZ5cBn4L5Tq0l5FL3in3lHBdLfcnZ3KTG7UHrNItbH019 L54cDkK+A/KBsLIDSeDHDRw2k3w7Kf+9fwcUpVaSxhQFr4vljMRnj7Dv8UgkmhIiFR+X lt/Gd7OyeJ9Oc/ITCpsAtlg1xLxRvl6KOrJKVSEw7L8z/2wBLuj235cP8rq17ovJm7/n tqrg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:to:from:dkim-signature; bh=8f9LY1ZyHWO82lhJq2020aaoctljdfi71oceFtcDZSo=; fh=bkv/WzrMlPZsXiOtDharKJ7dOQ0bmLnMBWqyIeft+eI=; b=ZOKoJFwWc+Q/RwBsmRVSLsofKpN2TOgAyv1e2U/rueyci0AoBmFZGonwhQ1q6SmHMW qhG8pwIDaUOi7ACXr/MHUD1bVYU+yh2B52iA6rzBcOw0cj4sd606HWvQOOn5tB+p4bXw TqS4m1ewO+gOAWpjR2Vf+LiAHKr5C+oLtkOS/CDA2I96IhsZUVzGzPYbEG660Nauhnco ljyYbn9mDsT/nTGfdd3ZLMen+/GjkTi9+t4v6NXMmVxkXvzr4Kcy0gHxiO7QHl6CZci8 eGeXdqhXtOFAAdJQ5bYiYmwd9zIDArHZBeBV2iydzH7mtah2t7ymbuuc6X/srrP/VutE puww==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QsSsA6Vg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62260-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62260-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWSC5E8ntflJ8U3t/Xxgs75YxsBNTNHSrZcScVBxZAo8WcwEG9ze9d3PxqIyLnLRTSTQ+o9YDG62UYy4T6NUCze67WpuIna3ThZ0eg3KA== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id dk7-20020a170906f0c700b00a3caddd0812si415841ejb.980.2024.02.12.11.13.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 11:13:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62260-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QsSsA6Vg; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-62260-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62260-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D81B51F22267 for ; Mon, 12 Feb 2024 19:12:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CF32547A7A; Mon, 12 Feb 2024 19:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QsSsA6Vg" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7D5647779; Mon, 12 Feb 2024 19:11:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707765114; cv=none; b=qHE1XSd9lCie90PRoUm6ToxDpdcer4WShFY6KuutuDQPLcQN3reMLTgTBlCPD9Q90uPpgoNQlZIaoKXZgE78ENs+Iq+0D7cdjc86cLbcK2xZ40EybiN7My0byIkvIR8yuNUGAVpEfb7AwPbw+uILpQSA/wYKl2TYTIQG36k8ee4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707765114; c=relaxed/simple; bh=QNO5lfS3LKOrsPQYo3VzoWDJViGZD1S5lJ1NNbq7H/E=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oVPjYP26N5ZxyNgQh2qwsQayevz6wUhOKN0LMYLVpWGLekrPJyYqd44K1CZnCphORo84PDRFlwWE6xAp5PMUreITGTqANe7XR/jYUm7ofclj0kOV3G8bcrQDRXrKS0e1p94M20Wm7f6R46f73BxXlUVj3xON+BealgSwzBi1QTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QsSsA6Vg; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFED5C433C7; Mon, 12 Feb 2024 19:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707765113; bh=QNO5lfS3LKOrsPQYo3VzoWDJViGZD1S5lJ1NNbq7H/E=; h=From:To:Subject:Date:In-Reply-To:References:From; b=QsSsA6VgQwwadd3WcHVJXeqewmu158F9ocJ6hs4kWs4tebZ/rp4H/xihDt6UiaWx+ +lXrqNMB3d4GkbEBI8ieluJQ3mMu48FLtlQSFOL+dgWB9z6WIPow17873nsVFt6rgj 3kOQ0DTAyHLfphI8LKlgZFS4E8kjPusd+OdV5AjhX8ALSAOBArkdidyBEaz0NrLdwY 2KdX9GoamFaeLSTg8ZZ7rnO3rLpCMIzHv+Gowhm7wNYyOLGCDJCwsIcwh+aI8DV9hY ixgafg6IEtFjEB94KeIKi/UV5kmPCGrraljO1of2xEmHIADLxyg0l6ZZwjGpOVBPGT MGLHUO5ZPeTOg== From: Namhyung Kim To: Jiri Olsa , Mark Rutland , Nathan Chancellor , llvm@lists.linux.dev, Alexander Shishkin , Kan Liang , Tom Rix , James Clark , Ravi Bangoria , Peter Zijlstra , Ingo Molnar , Adrian Hunter , John Garry , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Ian Rogers , Arnaldo Carvalho de Melo , Nick Desaulniers Subject: Re: [PATCH v2 8/9] perf srcline: Add missed addr2line closes Date: Mon, 12 Feb 2024 11:11:51 -0800 Message-ID: <170776504998.3461281.1826440393211565265.b4-ty@kernel.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog In-Reply-To: <20240201001504.1348511-8-irogers@google.com> References: <20240201001504.1348511-1-irogers@google.com> <20240201001504.1348511-8-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Wed, 31 Jan 2024 16:15:02 -0800, Ian Rogers wrote: > The child_process for addr2line sets in and out to -1 so that pipes > get created. It is the caller's responsibility to close the pipes, > finish_command doesn't do it. Add the missed closes. > > Applied to perf-tools-next, thanks! Best regards, -- Namhyung Kim