Received-SPF: pass (google.com: domain of linux-kernel+bounces-62266-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61
Precedence: bulk
MIME-Version: 1.0
Message-Id: <2cacd8dc-6150-4aa2-af9e-830a202fb0a8@app.fastmail.com>
In-Reply-To: <4869921.GXAFRqVoOG@radijator>
References: <20240212111819.936815-1-arnd@kernel.org>
 <20240212124428.GB4593@aspen.lan> <4869921.GXAFRqVoOG@radijator>
Date: Mon, 12 Feb 2024 20:14:20 +0100
From: "Arnd Bergmann" <arnd@arndb.de>
To: =?UTF-8?Q?Duje_Mihanovi=C4=87?= <duje.mihanovic@skole.hr>,
 "Arnd Bergmann" <arnd@kernel.org>,
 "Daniel Thompson" <daniel.thompson@linaro.org>
Cc: "Lee Jones" <lee@kernel.org>, "Jingoo Han" <jingoohan1@gmail.com>,
 "Helge Deller" <deller@gmx.de>, "Linus Walleij" <linus.walleij@linaro.org>,
 "Flavio Suligoi" <f.suligoi@asem.it>, "Hans de Goede" <hdegoede@redhat.com>,
 "Jianhua Lu" <lujianhua000@gmail.com>,
 "Matthew Wilcox" <willy@infradead.org>, dri-devel@lists.freedesktop.org,
 linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] backlight: ktd2801: fix LED dependency
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 12, 2024, at 15:31, Duje Mihanovi=C4=87 wrote:
> On Monday, February 12, 2024 1:44:28 PM CET Daniel Thompson wrote:
>> On Mon, Feb 12, 2024 at 12:18:12PM +0100, Arnd Bergmann wrote:
> I believe this would be the best thing to do here. Making LEDS_EXPRESS=
WIRE=20
> user selectable doesn't make much sense to me as the library is rather=
 low-
> level (a quick grep turns up BTREE as an example of something similar)=
 and IMO=20
> the GPIOLIB dependency should be handled by LEDS_EXPRESSWIRE as it's t=
he one=20
> actually using the GPIO interface (except maybe for KTD2692 as it has =
some=20
> extra GPIOs not present in the other one and thus handles them itself).

Agree, let's do it this way. Maybe the leds-expresswire.c file should
not be in drivers/leds either, but it's already there and I can't think
of a better place for it.so just adapting Kconfig should be enough.

Please add the corresponding Makefile change as well though:

--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -135,7 +135,7 @@ obj-$(CONFIG_CPU_IDLE)              +=3D cpuidle/
 obj-y                          +=3D mmc/
 obj-y                          +=3D ufs/
 obj-$(CONFIG_MEMSTICK)         +=3D memstick/
-obj-$(CONFIG_NEW_LEDS)         +=3D leds/
+obj-y                          +=3D leds/
 obj-$(CONFIG_INFINIBAND)       +=3D infiniband/
 obj-y                          +=3D firmware/
 obj-$(CONFIG_CRYPTO)           +=3D crypto/

Without this, the expresswire library module won't
get built unless NEW_LEDS is enabled.

     Arnd