Received-SPF: pass (google.com: domain of linux-kernel+bounces-62294-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: SeongJae Park <sj@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>,
	SeongJae Park <sj@kernel.org>,
	Bernd Edlinger <bernd.edlinger@hotmail.de>,
	linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	damon@lists.linux.dev,
	linux-mm@kvack.org
Subject: Re: [PATCH v2 4/4] selftests: damon: add access_memory to .gitignore
Date: Mon, 12 Feb 2024 11:53:28 -0800
Message-Id: <20240212195328.73406-1-sj@kernel.org>
In-Reply-To: <20240212-selftest_gitignore-v2-4-75f0de50a178@gmail.com>
References: 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hello,

On Mon, 12 Feb 2024 20:43:39 +0100 Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:

> This binary is missing in the .gitignore and stays as an untracked file.
> 
> Reported-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

'checkpatch.pl' complains as below:

    WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
    #11:
    Reported-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
    Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

I guess the 'Closes:' could this link?
https://lore.kernel.org/r/AS8P193MB1285C963658008F1B2702AF7E4792@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM

Also, note that this conflicts on mm-unstable.

Other than those,

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ


> ---
>  tools/testing/selftests/damon/.gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/damon/.gitignore b/tools/testing/selftests/damon/.gitignore
> index c6c2965a6607..79b32e30fce3 100644
> --- a/tools/testing/selftests/damon/.gitignore
> +++ b/tools/testing/selftests/damon/.gitignore
> @@ -1,2 +1,3 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  huge_count_read_write
> +access_memory
> 
> -- 
> 2.40.1