Received-SPF: pass (google.com: domain of linux-kernel+bounces-62314-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <34986860-41e5-4d03-a0c5-72af12e7e97c@gmail.com>
Date: Mon, 12 Feb 2024 21:07:34 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 4/4] selftests: damon: add access_memory to .gitignore
To: SeongJae Park <sj@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>, Bernd Edlinger
 <bernd.edlinger@hotmail.de>, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org, damon@lists.linux.dev, linux-mm@kvack.org
References: <20240212195328.73406-1-sj@kernel.org>
Content-Language: en-US
From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
In-Reply-To: <20240212195328.73406-1-sj@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 12.02.24 20:53, SeongJae Park wrote:
> Hello,
> 
> On Mon, 12 Feb 2024 20:43:39 +0100 Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:
> 
>> This binary is missing in the .gitignore and stays as an untracked file.
>>
>> Reported-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> 
> 'checkpatch.pl' complains as below:
> 
>     WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
>     #11:
>     Reported-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
>     Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> 
> I guess the 'Closes:' could this link?
> https://lore.kernel.org/r/AS8P193MB1285C963658008F1B2702AF7E4792@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM
>

I will add the Closes tag with the right link, thank you.

> Also, note that this conflicts on mm-unstable.

Should I use mm-unstable as basis to make sure no conflicts are introduced?

> 
> Other than those,
> 
> Reviewed-by: SeongJae Park <sj@kernel.org>
> 
> 
> Thanks,
> SJ
> 
> 
>> ---
>>  tools/testing/selftests/damon/.gitignore | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/damon/.gitignore b/tools/testing/selftests/damon/.gitignore
>> index c6c2965a6607..79b32e30fce3 100644
>> --- a/tools/testing/selftests/damon/.gitignore
>> +++ b/tools/testing/selftests/damon/.gitignore
>> @@ -1,2 +1,3 @@
>>  # SPDX-License-Identifier: GPL-2.0-only
>>  huge_count_read_write
>> +access_memory
>>
>> -- 
>> 2.40.1

Best regards,
Javier Carrasco