Received-SPF: pass (google.com: domain of linux-kernel+bounces-62313-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 12 Feb 2024 21:06:46 +0100
From: Jean Delvare <jdelvare@suse.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>, Anjelique
 Melendez <quic_amelende@quicinc.com>, Arnd Bergmann <arnd@arndb.de>,
 linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: qcom-lpg: add QCOM_PBS dependency
Message-ID: <20240212210646.7175bc84@endymion.delvare>
In-Reply-To: <20240212111526.829122-1-arnd@kernel.org>
References: <20240212111526.829122-1-arnd@kernel.org>
Organization: SUSE Linux
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 12 Feb 2024 12:15:02 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The lpg driver fails to link now when the pbs driver is in a loadable module:
> 
> x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_brightness_set':
> leds-qcom-lpg.c:(.text+0xe7f): undefined reference to `qcom_pbs_trigger_event'
> x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_probe':
> leds-qcom-lpg.c:(.text+0x16a5): undefined reference to `get_pbs_client_device'
> 
> Add a dependency to avoid the broken configuration. Apparently there is still
> a use for lpg with pbs disabled entirely for certain chips, so allow both
> but not LEDS_QCOM_LPG=y with QCOM_PBS=m.
> 
> Fixes: 214110175679 ("leds: rgb: leds-qcom-lpg: Add support for PPG through single SDAM")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/leds/rgb/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
> index e66bd21b9852..eaeafdd5eaae 100644
> --- a/drivers/leds/rgb/Kconfig
> +++ b/drivers/leds/rgb/Kconfig
> @@ -41,6 +41,7 @@ config LEDS_QCOM_LPG
>  	tristate "LED support for Qualcomm LPG"
>  	depends on OF
>  	depends on PWM
> +	depends on QCOM_PBS || !QCOM_PBS
>  	depends on SPMI
>  	help
>  	  This option enables support for the Light Pulse Generator found in a

Reviewed-by: Jean Delvare <jdelvare@suse.de>

Thanks,
-- 
Jean Delvare
SUSE L3 Support