Received-SPF: pass (google.com: domain of linux-kernel+bounces-62251-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <1d12e130-d3db-4eb5-a1d0-bc994c97a175@infradead.org>
Date: Mon, 12 Feb 2024 11:04:24 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] PM: hibernate: Support to select compression algorithm
Content-Language: en-US
To: Nikhil V <quic_nprakash@quicinc.com>, Pavel Machek <pavel@ucw.cz>,
 Len Brown <len.brown@intel.com>, Jonathan Corbet <corbet@lwn.net>,
 "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>, Tejun Heo <tj@kernel.org>,
 Yan-Jie Wang <yanjiewtw@gmail.com>, Peter Zijlstra <peterz@infradead.org>,
 "Steven Rostedt (Google)" <rostedt@goodmis.org>,
 Catalin Marinas <catalin.marinas@arm.com>, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
 quic_pkondeti@quicinc.com, quic_kprasan@quicinc.com,
 quic_mpilaniy@quicinc.com, quic_shrekk@quicinc.com,
 mpleshivenkov@google.com, ericyin@google.com
References: <3776355f920c1af44490e076072f93bafdf128cc.1707740870.git.quic_nprakash@quicinc.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <3776355f920c1af44490e076072f93bafdf128cc.1707740870.git.quic_nprakash@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2/12/24 04:32, Nikhil V wrote:
> Currently the default compression algorithm is selected based on
> compile time options. Introduce a module parameter "hibernate.compressor"
> to override this behaviour.
> 
> Different compression algorithms have different characteristics and
> hibernation may benefit when it uses any of these algorithms, especially
> when a secondary algorithm(LZ4) offers better decompression speeds over a
> default algorithm(LZO), which in turn reduces hibernation image restore
> time.
> 
> Users can override the default algorithm in two ways:
>  1) Passing "hibernate.compressor" as kernel command line parameter.
>     Usage:
>     	LZO: hibernate.compressor=lzo
>     	LZ4: hibernate.compressor=lz4
> 
>  2) Specifying the algorithm at runtime.
>     Usage:
> 	LZO: echo lzo > /sys/module/hibernate/parameters/compressor
> 	LZ4: echo lz4 > /sys/module/hibernate/parameters/compressor
> 
> Currently LZO and LZ4 are the supported algorithms. LZO is the default
> compression algorithm used with hibernation.
> 
> Signed-off-by: Nikhil V <quic_nprakash@quicinc.com>
> ---
> This patch is dependent on the patch series, [1] (patches 1/4 to 3/4).
> This is picked in linux-next, [2].
>  [1] https://lore.kernel.org/all/cover.1705927916.git.quic_nprakash@quicinc.com/
>  [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/kernel/power?h=next-20240212
> 
>  .../admin-guide/kernel-parameters.txt         | 10 ++++
>  kernel/power/hibernate.c                      | 57 ++++++++++++++++++-
>  2 files changed, 64 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 31b3a25680d0..522155056645 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1748,6 +1748,16 @@
>  				(that will set all pages holding image data
>  				during restoration read-only).
>  

Hi,
Please add something like:


> +	hibernate.compressor= 	[HIBERNATION] Compression algorithm to be
> +				used with hibernation.
> +				Format: { lzo | lz4 }
				Default: lzo
> +
> +				lzo: Select LZO compression algorithm to
> +				compress/decompress hibernation image.
> +
> +				lz4: Select LZ4 compression algorithm to
> +				compress/decompress hibernation image.
> +
>  	highmem=nn[KMG]	[KNL,BOOT] forces the highmem zone to have an exact
>  			size of <nn>. This works even on boxes that have no
>  			highmem otherwise. This also works to reduce highmem


thanks.
-- 
#Randy