Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp2692084rdb; Mon, 12 Feb 2024 13:11:39 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUBItGG44HCzaX+jZ76E8ZofYZzfoyJLBFqOuYCuiiNuSG0pcUmT9k64GK6rO9JSY+yHH/2705VtkXCUQKQ2JO+CCpNOBwVW+oAZd7QWA== X-Google-Smtp-Source: AGHT+IHg79QTHLhdQxvupXvfeaJX7E+v2xuGQuTWV0WV9ZUXYsNIIGV+pn6+J8xK6spNXHNNp5B+ X-Received: by 2002:a05:6a21:1645:b0:19e:a353:81b0 with SMTP id no5-20020a056a21164500b0019ea35381b0mr6615894pzb.11.1707772299638; Mon, 12 Feb 2024 13:11:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707772299; cv=pass; d=google.com; s=arc-20160816; b=WOmyqi0/Clw8OZ3S0FrHP/dxNiHXp2/8jsHGWqz+m6EpCxAthq7mQ8FVWtWY43nbkW HzOR8QvQrDto6PVYcrj13ZX3rfOSbL6c3AFudGTgJ4LGgswxbCI0CI4WfePnrl7ctIny 2/nKW5IzjTqPi6tqZFN5du2ExvsNV7Z+8zOr0g/rT6RapT1VUwNokI/5K/MheFckR/Q+ pt0GnWndKn0SNUrd8k+O85+Eyz4wrO/fsR71ZVaSCSitG8QtgFnkminLK8XEj+CH65PH l/8AJg/g18mbfAQ3W9hhCq/G1fkJSV1qPNoC4aHDLlIGsgmNfbV0vqTFwGZdMSkelp6d 1jLw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=ho2ychX5rzcZXGqMft5IUPj+UTWREdBWn8Koftkvhk0=; fh=UxMEezGwGp8uWFsW6kTchzB58R02UfbMtwAIgtTDPXc=; b=hasQe4KjoV20z/PM//b51DMp4XRLdjt96TYpaXDuhmO3n1FJuEUOdxD/Drpu0a16fi o113HxA0HYRTEvnfogL6VKWMk15EJsldd3seI+xqvmr7N1mrK2yf2qvs+nFEQj7zVY3y xsj8VF8tKqpU8OR4jvHoNb/C39bo0XZKn3eCg/l2gsaUqhN8rT6f97FmnYsRfSXzMBP1 g2dIfbcxOe85grTvFKYkQzUnuSBbSP2EQLo/4lv5RDrc07mwfJco9sGqg6OziOSkOgYt GZw90iWcbLqTKXVfkrUusMJ/TSyQnK8GRxAcv/YV+1ipDxwcufp9cwUx/6j2EzJE1eZ5 3qaQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=d9ei9th8; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-62370-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62370-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev X-Forwarded-Encrypted: i=2; AJvYcCVFItxj5Fh+gUKgsMapbz8ulMCaQ4d6TlrtpnbgAywy6SsoxcjEFdwmd94irHjwrR/Yt4BCUQt5YkJ2ClfpZB27Svoe42gGSgHXA/guTw== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id k192-20020a633dc9000000b005dc504e597csi757433pga.513.2024.02.12.13.11.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 13:11:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-62370-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=d9ei9th8; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-62370-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-62370-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BDC53B21D93 for ; Mon, 12 Feb 2024 21:10:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1289C4C622; Mon, 12 Feb 2024 21:10:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="d9ei9th8" Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D73CF4BA88 for ; Mon, 12 Feb 2024 21:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707772212; cv=none; b=t8cB9LiSXKpa1jkosnrLLNljDBEIyH27l1q9MF1mKrYPbqnZhC0YaGi4w26a6TUjxNUpqY0vZtRHnrgut5WKHwiS0sbe4xpNZ5RtWa68OMTAVjHqArlE0X0MBVlr8hMVMco+iZ/0eNlxZWDMS9qUxVJyuc0IrvEu+GRnGGzlkIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707772212; c=relaxed/simple; bh=V2K3Tqa8gFu4PA1KW3ElYY3Gm+CaB0UlpxRc/Dm88V4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lQzgejQbUGrF5cHgkTWQpIWOCPE1You5otRpQloRoN2UPnFKFyTh1Og+IxdQkIsEXHceEtzwK9YPs+tp0SfBqlzJzKDTmywUEFaX6FtFpICBkk4MuREqToPw9uWwk9oF8QGPWwuqmCYvBcxvXtjDTeoMBt12cf9EMcm7g9wNh0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=d9ei9th8; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707772207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ho2ychX5rzcZXGqMft5IUPj+UTWREdBWn8Koftkvhk0=; b=d9ei9th8fcogKE0TDUvOgUz6IIwo3rQmVdChHOVKeZ0S1+n3rZ3FgUStc9VVsDUEbJD1R0 QoYZvxKJJftGdkfCirawYzO+KT4wFkeMK6+LPwuPxr53YfunovI0mDgz94yL2bPbkItKAU SVfmES5t3kgv86WmHRXSt1oGwe5f5kY= From: Oliver Upton To: kvmarm@lists.linux.dev Cc: kvm@vger.kernel.org, Marc Zyngier , James Morse , Suzuki K Poulose , Zenghui Yu , Raghavendra Rao Ananta , linux-kernel@vger.kernel.org, Oliver Upton Subject: [PATCH] KVM: selftests: Print timer ctl register in ISTATUS assertion Date: Mon, 12 Feb 2024 21:09:33 +0000 Message-ID: <20240212210932.3095265-2-oliver.upton@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Zenghui noted that the test assertion for the ISTATUS bit is printing the current timer value instead of the control register in the case of failure. While the assertion is sound, printing CNT isn't informative. Change things around to actually print the CTL register value instead. Reported-by: Zenghui Yu Closes: https://lore.kernel.org/kvmarm/3188e6f1-f150-f7d0-6c2b-5b7608b0b012@huawei.com/ Signed-off-by: Oliver Upton --- Applies to kvmarm/next. tools/testing/selftests/kvm/aarch64/arch_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/aarch64/arch_timer.c b/tools/testing/selftests/kvm/aarch64/arch_timer.c index d5e8f365aa01..ab4b604d8ec0 100644 --- a/tools/testing/selftests/kvm/aarch64/arch_timer.c +++ b/tools/testing/selftests/kvm/aarch64/arch_timer.c @@ -160,7 +160,7 @@ static void guest_validate_irq(unsigned int intid, __GUEST_ASSERT(xcnt >= cval, "xcnt = 0x%lx, cval = 0x%lx, xcnt_diff_us = 0x%lx", xcnt, cval, xcnt_diff_us); - __GUEST_ASSERT(xctl & CTL_ISTATUS, "xcnt = 0x%lx", xcnt); + __GUEST_ASSERT(xctl & CTL_ISTATUS, "xctl = 0x%lx", xctl); WRITE_ONCE(shared_data->nr_iter, shared_data->nr_iter + 1); } base-commit: 680f749c272378a796388a3244bab53b5a952d67 -- 2.43.0.687.g38aa6559b0-goog