Received-SPF: pass (google.com: domain of linux-kernel+bounces-62400-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 12 Feb 2024 21:33:48 +0000
From: Tom Parkin <tparkin@katalix.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: James Chapman <jchapman@katalix.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>, edumazet@google.com,
	gnault@redhat.com, davem@davemloft.net, pabeni@redhat.com,
	corbet@lwn.net, netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3] PPPoL2TP: Add more code snippets
Message-ID: <ZcqOvDgXsG2W8t8l@katalix.com>
References: <20240203223513.f2nfgaamgffz6dno@begin>
 <20240209082046.6a87f7f8@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="DPH0nXQ1L/7W8EfL"
Content-Disposition: inline
In-Reply-To: <20240209082046.6a87f7f8@kernel.org>


--DPH0nXQ1L/7W8EfL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On  Fri, Feb 09, 2024 at 08:20:46 -0800, Jakub Kicinski wrote:
> On Sat, 3 Feb 2024 23:35:13 +0100 Samuel Thibault wrote:
> > The existing documentation was not telling that one has to create a PPP
> > channel and a PPP interface to get PPPoL2TP data offloading working.
> >=20
> > Also, tunnel switching was not mentioned, so that people were thinking
> > it was not supported, while it actually is.
> >=20
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>=20
> James, Tom, looks good?

Sorry for the silence -- I think for v2 we had some discussion of
whether the PPPIOCBRIDGECHAN docs really belonged in l2tp.rst or not
and I wasn't sure whether the same issue would be raised again.

For me I'm happy enough having it mentioned in the l2tp documentation,
so long as the example is clear and accurate.  I've responded to the
patch now with a couple of suggestions on that front.

Thanks,
Tom
--=20
Tom Parkin
Katalix Systems Ltd
https://katalix.com
Catalysts for your Embedded Linux software development

--DPH0nXQ1L/7W8EfL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEsUkgyDzMwrj81nq0lIwGZQq6i9AFAmXKjrsACgkQlIwGZQq6
i9Bo9gf+M2HejzgmlPv3lvUmunb+CR9btn3EyqFs8s+Nov178iSOPaLXpRJRavrt
EQ8ktZIf3Umn3fnYE6fnClNK/iu1R/8Uzc3Rsy4TRYFDQPGGxJE9AUot2HAfSjne
wVHz6YciXfCvNZJXjf8SEh8uyhpjXRK/PuESPjgkpH1lo2+4Ju+i336f0UtWPR06
fcZ4ACeGcaHIE4dDKT3J8C1hSXFsy9AK0z758mT0ESDC2vtfkAxtzUgDcf/h8OVk
giyl84hvIrNJK6aTLYXEv7HPZIdK58G281Jhi2VTwNFbeSoQafTQlQhsKxGL9bM3
wo1wMJ8uPsbMEUAk2/a9tqtIZP2HGA==
=/yw/
-----END PGP SIGNATURE-----

--DPH0nXQ1L/7W8EfL--