Received-SPF: pass (google.com: domain of linux-kernel+bounces-62442-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <16a63923-2fd2-4d44-a8a3-32d8d6eeee9e@intel.com>
Date: Mon, 12 Feb 2024 13:43:56 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v15-RFC 0/8] Add support for Sub-NUMA cluster (SNC)
 systems
Content-Language: en-US
To: "Luck, Tony" <tony.luck@intel.com>, "babu.moger@amd.com"
	<babu.moger@amd.com>, "Yu, Fenghua" <fenghua.yu@intel.com>, Peter Newman
	<peternewman@google.com>, Jonathan Corbet <corbet@lwn.net>, Shuah Khan
	<skhan@linuxfoundation.org>, "x86@kernel.org" <x86@kernel.org>
CC: Shaopeng Tan <tan.shaopeng@fujitsu.com>, James Morse
	<james.morse@arm.com>, Jamie Iles <quic_jiles@quicinc.com>, Randy Dunlap
	<rdunlap@infradead.org>, Drew Fustini <dfustini@baylibre.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"patches@lists.linux.dev" <patches@lists.linux.dev>
References: <20240126223837.21835-1-tony.luck@intel.com>
 <20240130222034.37181-1-tony.luck@intel.com>
 <91bd281e-e21f-4b60-9e73-2f14fcbec316@amd.com>
 <642f81da-669b-4057-8b97-2894dd57842b@intel.com>
 <SJ1PR11MB6083036DC25D4FA55B02589AFC482@SJ1PR11MB6083.namprd11.prod.outlook.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <SJ1PR11MB6083036DC25D4FA55B02589AFC482@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sjhoa0QrdGtEVkFKMlhySXJiamtSVTNINW0xbVBBZ1RLZnlpdDVzdjlEWEZQ?=
 =?utf-8?B?RzBSaHRMQk5JbldzYnZtTEhiWENPTWFidk1RaEp0VGVzS2RpRndpbFB2d2Qz?=
 =?utf-8?B?NENVek5iYks0Qng0NmpwT25NN2pGeVh2TXJBbW0vU3BBdHRpa3JyQjZML1E1?=
 =?utf-8?B?V0o2dmdwRll5SnR0SE15RzJRRnd1Y0VxaEl4OUFSWUtBZFNGNTlmMkJ3SGZ3?=
 =?utf-8?B?YUdzL3d1VUhoTFZ6OVdTQ200YmtIMjJUdEVrdXhWeEJNL1VaYlNENG5SNFZ0?=
 =?utf-8?B?ajhab0NScm4wRytIdlZpYUFzYWhtdHJXQ1c5N08yN1l6Y1FqSTdsMTRiRk9h?=
 =?utf-8?B?SU1QeFlDZFRXZHF0MnFmYlB6aC9JdnNLL1p1NWVKZURESGlsTithaTIxaUhN?=
 =?utf-8?B?a2ZrVFZmVGRwR2FnVmJobEVzMG9vUyt1Q01aODVUeTNCNGIyazJ0eGVnQVEz?=
 =?utf-8?B?T004cTRkV2IvbnBGRVBtTDY0SnQ3UTl1WEl6UUpQUVBCcTdqdDVHeS9UbjNX?=
 =?utf-8?B?Zkw3RjZSRXBKWWZ2aGtaUWFLZWFCaUFGek40ZXF1NnU2SjkrNUZJbytmUFF1?=
 =?utf-8?B?MHc3Mml3TnZTOWRLUkFWTnd0eFhjOVhnTmRsUEVhc3JtMDNqbEJYODllVkh0?=
 =?utf-8?B?NVBkbndFMU90RWRPa2NwczNtYWZmMTR3TitQNDBWTlQ4My80bk4vV0J1dlor?=
 =?utf-8?B?Zkg1SkJoTFNtVXZBYUcyV3ExQlVubTRGU3Rra0pLRVlFNDErMCtLaVJJYlcy?=
 =?utf-8?B?aE9PQk8ramdUYmVMRGpmWnNFRDN2OVk3L2lNUlRONGJxZHpHMVg1NjA4V1Rz?=
 =?utf-8?B?akcyTlhIZHdNKzd6UXRKYXNtQnMvZ3poaGNSdGhCQkpqcHpocGNZdU1ETlJJ?=
 =?utf-8?B?dUQrQ1ZxZm5EQzRyQm9yYWxDVERQKzFYN2JDU2VGeGNianE5TmhjOFlRVHF2?=
 =?utf-8?B?ZG5JMzdkMk16Mlo2NjBHNzQzaHNsazZ0NHFyaExuR3htTWNtSjNZaGJWR25V?=
 =?utf-8?B?YmR4aWJlL0hLbWYySFF1QTZZQ1g5bVRndXd0TjNTMlJLbmVOM1l1NXAxMWRk?=
 =?utf-8?B?cU5HM3IySEtYUnplNVlLK2lJbWhobnc2K29LZC9NK0VSMStnRDVhdTdyMkhT?=
 =?utf-8?B?VmVNWkp1bjV1NUx0dGFNZjlneU0vQ3hZd0dMeFViNkNHT3RzMndnQ0h1b3V6?=
 =?utf-8?B?eUJndkRDS1M5bGRrU1FEdnNERWVXekN4R2ZaQjVzMzNscWFBTU4vbkN2K3Y1?=
 =?utf-8?B?SnNOOVZBYnM0UmRnVmhaSnhQZ2NLa3BDNkZPT2U4VXN5QUZWdzB5WCs5VXU4?=
 =?utf-8?B?MWlqd29SSElUUjVHdGNDSDE1TU9NV3U5dUR6Zmc0RzRwSmcwamRXL2c0OTdU?=
 =?utf-8?B?d2lTd0tSMk5mRVZjSHJmWkloQjRvaHJQNTdVT1VMTHBFdlhoODhjUnVIV01r?=
 =?utf-8?B?MTdQNWpIYnZJTkY0VEJ0TkJYTXRqYlQ2allQd3d0ZGNhdUM4VkNTSmY3ZFhS?=
 =?utf-8?B?OHdqQk9namdrSkcwY0VwQS9YeFMyb0E3eE84QVBSTVNSd2srTHpnQTJudHlB?=
 =?utf-8?B?ZkxNNjVyNUZnbmdwV3Z4SGpCQ1diU1puS09jL3Q3ZzFQQjVSTHFIM045QWF0?=
 =?utf-8?B?T1FRY1EyYStWOGVYdFo1dXBKcXFsRnE5RURxWk9iVHF1K3k1UDRjL0hKazFw?=
 =?utf-8?B?N1RYWUtlOUZvVXdzOElsVE1zOTl4WlgreWtiRVJDU29JTG5tajVuRVRPNnFy?=
 =?utf-8?B?Ym41NUt0d25QN0JmaVQ0d2VuWEZNL0lRSDFRUHEwQVNycDI4S2REa2trWklU?=
 =?utf-8?B?MG5kdjBaNnc2bVZCdFlvczJvd1RBa1FkRmxlWXloVEJBaklaeWg4cHpMZktK?=
 =?utf-8?B?ejN6QXdTMHVZUldXY0xQVC9xdGttaVVwUytwRTlZK1A5WDIvalpSMnNlMW1N?=
 =?utf-8?B?anlXdnNTb3lpUWRRQVZ0YVpncGtCZlNXNVVxMktDZlkzZFRiVzRaRjJRMldX?=
 =?utf-8?B?TE1CZE1TU0RWWHkzaUcxOGdMQ1haRVVBR3JJcUN2R252dm9kV0w0RGxNemlW?=
 =?utf-8?B?cXFnMjFVaTViU09DTlh5Y2g2bEtNekEyeWtnbkhjMTdQa0tBZm9GYzdxbVZr?=
 =?utf-8?B?VWEyTWdSTUFmU01TRjhYSU0yUWY5Yis5NzVQejhCdThxaGkyalpUaDcya1kv?=
 =?utf-8?B?OVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d16e43d-7b2c-4c51-ccac-08dc2c13b890
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2024 21:43:59.3558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vb5Ro9pQkauiF5TkY5c4dbyrPYJQmaZxzrhvwWs3yjfnRgKm8VK5tDWLTjA6arqQPLrHvx0IUGIgL3mVEncoXGiQE/SLWXWt0ZcwKSuXFVM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7598
X-OriginatorOrg: intel.com

Hi Tony,

On 2/12/2024 11:57 AM, Luck, Tony wrote:
>>> To be honest, I like this series more than the previous series. I always
>>> thought RDT_RESOURCE_L3_MON should have been a separate resource by itself.
>>
>> Would you prefer that your "Reviewed-by" tag be removed from the
>> previous series?
> 
> I'm thinking that I could continue splitting things and break "struct rdt_resource" into
> separate "ctrl" and "mon" structures. Then we'd have a clean split from top to bottom.

It is not obvious what you mean with "continue splitting things". Are you
speaking about "continue splitting from v14" or "continue splitting from v15-RFC"?

I think that any solution needs to consider what makes sense for resctrl
as a whole instead of how to support SNC with smallest patch possible.

There should not be any changes that makes resctrl harder to understand
and maintain, as exemplified by confusion introduced by a simple thing as
resource name choice [1].

> 
> Doing that would get rid of the rdt_resources_all[] array. Replacing with individual
> rdt_hw_ctrl_resource and rdt_hw_mon_resource declarations for each feature.
>
> Features found on a system would be added to a list of ctrl or list of mon resources.

Could you please elaborate what is architecturally wrong with v14 and how this
new proposal addresses that?

Reinette

[1] https://lore.kernel.org/lkml/ZcZyqs5hnQqZ5ZV0@agluck-desk3/